[Cluster-devel] [RFC PATCH 1/3] gfs2: allow map_journal_extents() to take a journal descriptor as argument

2018-05-29 Thread Abhi Das
This function now maps the extents for the journal whose descriptor is passed in as argument. Signed-off-by: Abhi Das --- fs/gfs2/log.h| 1 + fs/gfs2/ops_fstype.c | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/gfs2/log.h b/fs/gfs2/log.h index

[Cluster-devel] [RFC PATCH 2/3] gfs2: add timing info for various stages of journal recovery

2018-05-29 Thread Abhi Das
Tells you how many milliseconds each stage of journal recovery takes. Signed-off-by: Abhi Das --- fs/gfs2/ops_fstype.c | 5 + fs/gfs2/recovery.c | 20 ++-- 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index

[Cluster-devel] [RFC PATCH 3/3] gfs2: read journal in large chunks to locate the head

2018-05-29 Thread Abhi Das
Use bio(s) to read in the journal sequentially in large chunks and locate the head of the journal. This is faster in most cases when compared to the existing bisect method which operates one block at a time. Signed-off-by: Abhi Das --- fs/gfs2/incore.h | 7 +++- fs/gfs2/log.c | 2 +-

Re: [Cluster-devel] [PATCH 11/34] iomap: move IOMAP_F_BOUNDARY to gfs2

2018-05-29 Thread Darrick J. Wong
On Wed, May 23, 2018 at 04:43:34PM +0200, Christoph Hellwig wrote: > Just define a range of fs specific flags and use that in gfs2 instead of > exposing this internal flag flobally. > > Signed-off-by: Christoph Hellwig Looks ok to me, but better if the gfs2 folks [cc'd now] ack this...

Re: [Cluster-devel] [PATCH 09/34] iomap: inline data should be an iomap type, not a flag

2018-05-29 Thread Darrick J. Wong
On Wed, May 23, 2018 at 04:43:32PM +0200, Christoph Hellwig wrote: > Inline data is fundamentally different from our normal mapped case in that > it doesn't even have a block address. So instead of having a flag for it > it should be an entirely separate iomap range type. > > Signed-off-by:

Re: [Cluster-devel] [RFC PATCH 3/3] gfs2: read journal in large chunks to locate the head

2018-05-29 Thread Steven Whitehouse
Hi, On 29/05/18 09:05, Abhi Das wrote: Use bio(s) to read in the journal sequentially in large chunks and locate the head of the journal. This is faster in most cases when compared to the existing bisect method which operates one block at a time. Overall this looks very good. One thing that

Re: [Cluster-devel] [RFC PATCH 0/3] Speed up journal head lookup

2018-05-29 Thread Steven Whitehouse
Hi, On 29/05/18 09:05, Abhi Das wrote: This patchset uses bio(s) to read in the journal in large chunks to lookup the journal head. This will replace the existing bisect method of reading the journal block-by-block to find the head. These are RHEL7 patches because it was simpler for me to

Re: [Cluster-devel] [RFC PATCH 2/3] gfs2: add timing info for various stages of journal recovery

2018-05-29 Thread Steven Whitehouse
Hi, Looks good. Acked-by: Steven Whitehouse Steve. On 29/05/18 09:05, Abhi Das wrote: Tells you how many milliseconds each stage of journal recovery takes. Signed-off-by: Abhi Das --- fs/gfs2/ops_fstype.c | 5 + fs/gfs2/recovery.c | 20 ++-- 2 files changed, 19

Re: [Cluster-devel] [RFC PATCH 1/3] gfs2: allow map_journal_extents() to take a journal descriptor as argument

2018-05-29 Thread Steven Whitehouse
Hi, Looks good. Acked-by: Steven Whitehouse Steve. On 29/05/18 09:05, Abhi Das wrote: This function now maps the extents for the journal whose descriptor is passed in as argument. Signed-off-by: Abhi Das --- fs/gfs2/log.h| 1 + fs/gfs2/ops_fstype.c | 5 ++--- 2 files changed,