Re: [Cluster-devel] [GFS2] Don't use journal lock type

2007-08-07 Thread David Teigland
On Tue, Aug 07, 2007 at 10:26:06AM +0100, Steven Whitehouse wrote: error = gfs2_glock_nq_num(sdp, sdp-sd_lockstruct.ls_jid, - gfs2_journal_glops, + gfs2_inode_glops,

Re: [Cluster-devel] [PATCH] for a header-file-cannot-found building error

2007-08-20 Thread David Teigland
On Sun, Aug 19, 2007 at 07:32:57AM +0200, Fabio Massimo Di Nitto wrote: David Teigland wrote: I believe that the correct solution is to install the necessary kernel headers into /usr/include/linux/ prior to building cluster. This usually means doing something like this: cd /usr

Re: [Cluster-devel] [PATCH] dlm/test Makefile cleanup

2007-08-24 Thread David Teigland
On Fri, Aug 24, 2007 at 02:06:29PM +0200, Fabio Massimo Di Nitto wrote: Hi David, any objections to this cleanup? It's very simple and just put inline the makefile with all the others. note that we don't build tests by default or ship them. This is not changed. Looks good, thanks.

Re: [Cluster-devel] [GFS2] Remove ail2 list from the ai

2007-08-27 Thread David Teigland
On Mon, Aug 27, 2007 at 05:00:06PM +0100, Steven Whitehouse wrote: From 2a666f519dd12e8b3a82d1e16cad3114cfdd917d Mon Sep 17 00:00:00 2001 From: Steven Whitehouse [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 16:42:29 +0100 Subject: [PATCH] [GFS2] Remove ail2 list from the ai The ail2 list wasn't

[Cluster-devel] configure sbindir default

2007-09-06 Thread David Teigland
It looks to me like configure should be setting the default sbindir to {prefix}/usr/sbin instead of {prefix}/sbin. As it is now, using openais DESTDIR=/ and the default cluster/configure settings, aisexec is installed to /usr/sbin/aisexec but cman_tool looks for it in /sbin/aisexec and fails.

[Cluster-devel] -O2 -Werror

2007-09-06 Thread David Teigland
configure was recently changed from a default of -O0 to -O2. A couple of places in the tree also use -Werror. The new combination of -O2 and -Werror breaks the build when using default configure setting. [using gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)] We need to remove the -Werror's, go

[Cluster-devel] Re: configure sbindir default

2007-09-06 Thread David Teigland
On Thu, Sep 06, 2007 at 08:36:25PM +0200, Fabio Massimo Di Nitto wrote: David Teigland wrote: It looks to me like configure should be setting the default sbindir to {prefix}/usr/sbin instead of {prefix}/sbin. As it is now, using openais DESTDIR=/ and the default cluster/configure

Re: [Cluster-devel] STABLE cluster branch?!

2007-09-11 Thread David Teigland
On Tue, Sep 11, 2007 at 11:04:58AM +0200, Marc - A. Dahlhaus [ Administration | Westermann GmbH ] wrote: Hello, are there any plans to merge the changes/fixes from the RHEL4 branch into STABLE? A new 1.0# release would be nice after that. We don't have any plans to do that, but would be

Re: [Cluster-devel] STABLE cluster branch?!

2007-09-12 Thread David Teigland
On Wed, Sep 12, 2007 at 12:12:00PM +0200, Marc - A. Dahlhaus [ Administration | Westermann GmbH ] wrote: Am Dienstag, den 11.09.2007, 11:48 -0500 schrieb David Teigland: On Tue, Sep 11, 2007 at 11:04:58AM +0200, Marc - A. Dahlhaus [ Administration | Westermann GmbH ] wrote: Hello

Re: [Cluster-devel] [PATCH] [GFS2] bz 276631 : GFS2: chmod hung - TRY 2

2007-09-14 Thread David Teigland
On Thu, Sep 13, 2007 at 11:04:43PM -0500, Bob Peterson wrote: diff -pur a/fs/gfs2/locking/dlm/thread.c b/fs/gfs2/locking/dlm/thread.c --- a/fs/gfs2/locking/dlm/thread.c2007-09-13 17:33:58.0 -0500 +++ b/fs/gfs2/locking/dlm/thread.c2007-09-13 22:47:14.0 -0500 @@ -279,8

Re: [Cluster-devel] [PATCH] gfs2: fix lock cancelling

2007-09-20 Thread David Teigland
On Thu, Sep 20, 2007 at 10:55:29AM -0400, J. Bruce Fields wrote: +int gdlm_plock_cancel(void *lockspace, struct lm_lockname *name, + struct file *file, struct file_lock *fl) +{ + struct gdlm_ls *ls = lockspace; + struct plock_xop *xop; + struct plock_op *op;

[Cluster-devel] [PATCH] dlm: schedule during recovery loops

2007-09-25 Thread David Teigland
Call schedule() in a bunch of places where the recovery code loops through lists of locks. The theory is that these lists become so long that looping through them triggers the softlockup watchdog. (usually on ia64, doesn't seem to happen often on other arch's). Signed-off-by: David Teigland

Re: [Cluster-devel] [PATCH] Updated fence_manual docs for HEAD

2007-09-25 Thread David Teigland
On Tue, Sep 25, 2007 at 03:09:55PM -0400, Lon Hohberger wrote: +fence_manual used to implement a manual fencing agent. It has been +supplanted by the manual fence override. See the section fenced(8) +entitled 'Fencing override', as well as fence_ack_manual(8) for more +details. + +.P +In

Re: [Cluster-devel] [PATCH] dlm: schedule during recovery loops

2007-09-26 Thread David Teigland
On Wed, Sep 26, 2007 at 08:18:55AM +0100, Patrick Caulfield wrote: David Teigland wrote: Call schedule() in a bunch of places where the recovery code loops through lists of locks. The theory is that these lists become so long that looping through them triggers the softlockup watchdog

[Cluster-devel] [PATCH] dlm: block dlm_recv in recovery transition

2007-09-27 Thread David Teigland
versa. Races are avoided by blocking dlm_recv when setting the flag that switches between modes. Signed-off-by: David Teigland [EMAIL PROTECTED] --- diff --git a/fs/dlm/dlm_internal.h b/fs/dlm/dlm_internal.h index 74901e9..d2fc238 100644 --- a/fs/dlm/dlm_internal.h +++ b/fs/dlm/dlm_internal.h

Re: [Cluster-devel] time for STABLE2 branch

2007-10-09 Thread David Teigland
On Tue, Sep 18, 2007 at 04:40:45PM -0500, David Teigland wrote: I believe the time has arrived for a STABLE2 cluster branch. CVS HEAD hasn't been usable by most people for quite a while, partly due to ugly build requirements and partly due to instability of new code. Building HEAD currently

Re: [Cluster-devel] spectator setting in cluster.conf

2007-10-23 Thread David Teigland
On Tue, Oct 23, 2007 at 06:58:32PM +0200, Fabio Massimo Di Nitto wrote: An explicit votes= setting for a node would override the 0 votes implied by spectator/. So ok. I need to understand you better because I think what I wrote before is in contradiction with this override. In my patch

Re: [Cluster-devel] [PATCH][GFS2] Given device ID rather than s_id in id sysfs file

2007-11-02 Thread David Teigland
On Fri, Nov 02, 2007 at 09:37:15AM -0500, Bob Peterson wrote: Hi, This patch changes the /sys/fs/gfs2/s_id/id file to give the device id major:minor rather than the s_id. That enables gfs2_tool to match devices properly (by id, not name) when locating the tuning files. We have to be

[Cluster-devel] Re: [2.6 patch] fs/dlm/: proper prototypes

2007-11-05 Thread David Teigland
On Sat, Nov 03, 2007 at 01:04:30AM +0100, Adrian Bunk wrote: This patch adds a proper prototype for some functions in fs/dlm/dlm_internal.h Acked-by: David Teigland [EMAIL PROTECTED] Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- fs/dlm/dlm_internal.h | 16 fs

[Cluster-devel] [PATCH] gfs2: check kthread_should_stop when waiting

2007-11-07 Thread David Teigland
Use wait_event_interruptible() in the lock_dlm thread instead of an open coded equivalent, and include a kthread_should_stop() check in the wait test so we don't miss a kthread_stop(). Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/gfs2/locking/dlm/thread.c |9 ++--- 1 files

[Cluster-devel] [PATCH] dlm: use dlm prefix on alloc and free functions

2007-11-07 Thread David Teigland
The dlm functions in memory.c should use the dlm_ prefix. Also, use kzalloc/kfree directly for dlm_direntry's, removing the wrapper functions. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/dir.c | 10 +- fs/dlm/lock.c | 26 +- fs/dlm

[Cluster-devel] [PATCH] dlm: don't print common non-errors

2007-11-07 Thread David Teigland
Change log_error() to log_debug() for conditions that can occur in large number in normal operation. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 3915b8e..c21deba

[Cluster-devel] [PATCH] gfs2: tidy up error message

2007-11-16 Thread David Teigland
Print error with log_error() to be consistent with others. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/gfs2/locking/dlm/mount.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/locking/dlm/mount.c b/fs/gfs2/locking/dlm/mount.c index ab30102..f2efff4

Re: [Cluster-devel] cluster/group/gfs_controld lock_dlm.h

2007-11-21 Thread David Teigland
On Wed, Nov 21, 2007 at 05:50:16PM -, [EMAIL PROTECTED] wrote: CVSROOT: /cvs/cluster Module name: cluster Branch: RHEL5 Changes by: [EMAIL PROTECTED] 2007-11-21 17:50:16 Modified files: group/gfs_controld: lock_dlm.h Log message: ASSERT was doing

[Cluster-devel] [PATCH] gfs2: use pid for plock owner for nfs clients

2007-12-06 Thread David Teigland
The fl_owner is that of lockd when posix locks arrive from nfs clients, so it can't be used to distinguish between lock holders. Use fl_pid as owner instead; it's the pid of the process on the nfs client. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/gfs2/locking/dlm/plock.c | 18

Re: [Cluster-devel] [PATCH] dlm_controld: add multi-home

2007-12-10 Thread David Teigland
On Mon, Dec 10, 2007 at 04:44:20PM +0100, Fabio M. Di Nitto wrote: On Mon, 10 Dec 2007, Patrick Caulfield wrote: This patch adds multi-home capability to dlm_controld. If a node has more than one address then the DLM will be told about all of them, rather than just the first as at present.

Re: [Cluster-devel] [PATCH] dlm_controld: add multi-home

2007-12-10 Thread David Teigland
On Mon, Dec 10, 2007 at 12:48:49PM -0800, Joel Becker wrote: On Mon, Dec 10, 2007 at 09:59:35AM -0600, David Teigland wrote: These addresses come from the openais multiring configuration. The jump from 1 to 2 openais rings is going to be challenging enough, IME. As Patrick points out, dlm

Re: [Cluster-devel] Re: [PATCH] DLM: Fix static buffer alignment

2008-01-15 Thread David Teigland
Hi Steven, you can try to pull from here: git pull git://git.fugedabout.it/people/fabbione/gfs2-2.6-nmw.git [DLM] Fix endian issue when transmitting or receiving LOCK_REPLY [DLM] align static buffer gitweb: http://git.fugedabout.it/?p=people/fabbione/gfs2-2.6-nmw.git;a=summary

Re: [Cluster-devel] [PATCH] gfs2 umount: support fake -r option

2008-01-21 Thread David Teigland
On Sat, Jan 19, 2008 at 06:58:17AM +0100, Fabio M. Di Nitto wrote: Hi guys, in certain situations where gfs2 init scripts are not used to umount gfs2 volume, we endup with umount.gfs2 being invoked with -r option and this fails because we don't know what to do with this option. The

[Cluster-devel] current dlm patches

2008-01-21 Thread David Teigland
This is the current set of dlm patches that I'm collecting at http://people.redhat.com/teigland/dlm-patches-testing/ I'm preparing to send these upstream for 2.6.25 in the next week or so, depending on review and testing. They come mainly from - the mixed architecture testing and fixing that

[Cluster-devel] [PATCH] dlm: close othercons

2008-01-21 Thread David Teigland
all objects and the DLM cannot be restarted without a system reboot. See bz#428119 Signed-off-by: Patrick Caulfield [EMAIL PROTECTED] Signed-off-by: Fabio M. Di Nitto [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lowcomms.c |2 ++ 1 files changed, 2 insertions

[Cluster-devel] [PATCH] dlm: proper prototypes

2008-01-21 Thread David Teigland
From: Adrian Bunk [EMAIL PROTECTED] This patch adds a proper prototype for some functions in fs/dlm/dlm_internal.h Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/dlm_internal.h | 16 fs/dlm/lock.c |1 - fs

[Cluster-devel] [PATCH] dlm: don't print common non-errors

2008-01-21 Thread David Teigland
Change log_error() to log_debug() for conditions that can occur in large number in normal operation. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 7bc6ad9..63fe74d

[Cluster-devel] [PATCH] dlm: use fixed errno values in messages

2008-01-21 Thread David Teigland
the platform-specific ones at the other end. Many thanks to Fabio for testing this patch. Initial patch from Patrick. Signed-off-by: Patrick Caulfield [EMAIL PROTECTED] Signed-off-by: Fabio M. Di Nitto [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/util.c | 57

[Cluster-devel] [PATCH] dlm: swap bytes for rcom lock reply

2008-01-21 Thread David Teigland
From: Fabio M. Di Nitto [EMAIL PROTECTED] DLM_RCOM_LOCK_REPLY messages need byte swapping. Signed-off-by: Fabio M. Di Nitto [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/util.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/dlm

[Cluster-devel] [PATCH] dlm: bind connections from known local address when using TCP

2008-01-21 Thread David Teigland
to fix their systems or use clever routing tricks. Signed-off-by: Lon Hohberger [EMAIL PROTECTED] Signed-off-by: Patrick Caulfield [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lowcomms.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git

[Cluster-devel] [PATCH] dlm: clear ast_type when removing from astqueue

2008-01-21 Thread David Teigland
time. Appears when process calls libdlm dlm_release_lockspace() which first closes the ls dev triggering clear_proc_locks, and then removes the ls (a write to control dev) causing release_lockspace(). Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c |1 + 1 files changed, 1

[Cluster-devel] [PATCH] dlm: recover locks waiting for overlap replies

2008-01-21 Thread David Teigland
start doing recovery in the presence of a many overlapping unlock/cancel ops. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c | 37 - 1 files changed, 32 insertions(+), 5 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 43ca2a3

[Cluster-devel] [PATCH] dlm: another call to confirm_master in receive_request_reply

2008-01-21 Thread David Teigland
When a failed request (EBADR or ENOTBLK) is unlocked/canceled instead of retried, there may be other lkb's waiting on the rsb_lookup list for it to complete. A call to confirm_master() is needed to move on to the next waiting lkb since the current one won't be retried. Signed-off-by: David

[Cluster-devel] [PATCH] dlm: limit dir lookup loop

2008-01-21 Thread David Teigland
, the infinite loop is dangerous since some other unknown condition may appear causing the loop to never break. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index fa68e9b

[Cluster-devel] [PATCH] dlm: change error message to debug

2008-01-21 Thread David Teigland
The invalid lockspace messages are normal and can appear relatively often. They should be suppressed without debugging enabled. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm

[Cluster-devel] second batch of dlm patches for 2.6.25

2008-02-06 Thread David Teigland
I've sent a second batch of dlm patches to lkml for review prior to another pull request for 2.6.25, beginning here: http://lkml.org/lkml/2008/2/7/10 They are also in the test branch of dlm.git: http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/teigland/dlm.git;a=shortlog;h=test

[Cluster-devel] Re: [2.6 patch] make dlm_print_rsb() static

2008-02-19 Thread David Teigland
On Wed, Feb 13, 2008 at 11:29:38PM +0200, Adrian Bunk wrote: dlm_print_rsb() can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Thanks, added to dlm.git. Dave

[Cluster-devel] STABLE2 cluster branch

2008-02-22 Thread David Teigland
I've created a new STABLE2 branch from master in the new cluster.git. The point of STABLE2 is: - build/run with the current stable release of openais, (now 0.80.3) - build/run with the current stable release of the kernel, (now 2.6.24) I think we're in good shape already for the kernel, but

Re: [Cluster-devel] STABLE2 cluster branch

2008-03-03 Thread David Teigland
On Sat, Mar 01, 2008 at 02:52:05PM -0700, Steven Dake wrote: This is reasonable but requires having quite a bit of conditional compilation in cman and other tools. I don't know if anyone is working on this, but I'd imagine maintenance of such a scheme would be complicated since the trunk of

Re: [Cluster-devel] STABLE2 cluster branch

2008-03-03 Thread David Teigland
On Mon, Mar 03, 2008 at 05:10:54PM +0100, Fabio M. Di Nitto wrote: If we are to say this conditional compilation only works with trunk of openais up to a certain point such as version 0.84 then that certain point becomes a branch point which I really do not want. What I prefer is that trunk

Re: [Cluster-devel] STABLE2 cluster branch

2008-03-03 Thread David Teigland
On Mon, Mar 03, 2008 at 10:07:26AM -0700, Steven Dake wrote: On Mon, 2008-03-03 at 09:10 -0600, David Teigland wrote: On Sat, Mar 01, 2008 at 02:52:05PM -0700, Steven Dake wrote: This is reasonable but requires having quite a bit of conditional compilation in cman and other tools. I

[Cluster-devel] avoid polluting the git history

2008-03-05 Thread David Teigland
I've gone and looked at the cluster.git history and realize that we're not using git quite as we should. We're polluting the cluster.git history with unnecessary merge commits. It's not that git is being used wrongly per se, just not nicely. Not to blame anyone, but pull up git web in your

Re: [Cluster-devel] cluster-2.02.00

2008-03-11 Thread David Teigland
On Tue, Mar 11, 2008 at 03:24:24PM +0100, Kadlecsik Jozsef wrote: On Thu, 6 Mar 2008, David Teigland wrote: A new source tarball of cluster code has been released: cluster-2.02.00 Is there a changelog available somewhere? I could not find it in the tarball. No, sorry, I wish

Re: [Cluster-devel] libdlm dlm_ls_lock_wait() doesn't.

2008-03-20 Thread David Teigland
On Wed, Mar 19, 2008 at 03:35:11PM -0700, Joel Becker wrote: Folks, Another problem I've run into with libdlm - call dlm_ls_lock_wait() on a lock that another node holds, and it returns instead of blocking. This is not a trylock (LKF_NOQUEUE). Trylocks work as expected. A blocking

[Cluster-devel] cluster-2.03.00

2008-04-11 Thread David Teigland
work properly. Christine Caulfield (5): [DLM] Don't segfault if lvbptr is NULL [CMAN] Free up any queued messages when someone disconnects [CMAN] Limit outstanding replies [CMAN] valid port number don't use it before validation Remove references to broadcast. David

Re: [Cluster-devel] cluster-2.03.00

2008-04-14 Thread David Teigland
On Sun, Apr 13, 2008 at 01:56:12PM +0200, Fabio M. Di Nitto wrote: On Fri, 11 Apr 2008, David Teigland wrote: A new source tarball of cluster code has been released: cluster-2.03.00 This has been taken from the STABLE2 branch in the cluster git tree. It is compatible with the current stable

[Cluster-devel] kernel for building master

2008-04-14 Thread David Teigland
On Fri, Apr 11, 2008 at 04:29:52PM -, [EMAIL PROTECTED] wrote: - Log - commit 77bce77b5034adf8f00090b13dde7c7d481b0dd9 Author: David Teigland [EMAIL PROTECTED] Date: Wed Mar 19 16:05:20 2008 -0500 dlm_controld: new

[Cluster-devel] [PATCH 0/6] dlm patches for 2.6.26

2008-04-15 Thread David Teigland
This is a review series of dlm patches that are awaiting the 2.6.26 merge.

[Cluster-devel] [PATCH 1/6] dlm: match signedness between dlm_config_info and cluster_set

2008-04-15 Thread David Teigland
type in argument 3 (different signedness) fs/dlm/config.c:149:1:expected unsigned int *info_field fs/dlm/config.c:149:1:got int extern [toplevel] *noident Signed-off-by: Harvey Harrison [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/config.c |2 +- 1

[Cluster-devel] [PATCH 3/6] dlm: save master info after failed no-queue request

2008-04-15 Thread David Teigland
is to simply leave res_master value alone. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 1e9e8eb..2d3d102 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c @@ -1956,8 +1956,7

[Cluster-devel] [PATCH 2/6] dlm: make dlm_print_rsb() static

2008-04-15 Thread David Teigland
From: Adrian Bunk [EMAIL PROTECTED] dlm_print_rsb() can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c |2 +- fs/dlm/lock.h |1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/dlm

[Cluster-devel] [PATCH 6/6] dlm: common max length definitions

2008-04-15 Thread David Teigland
Add central definitions for max lockspace name length and max resource name length. The lack of central definitions has resulted in scattered private definitions which we can now clean up, including an unused one in dlm_device.h. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm

[Cluster-devel] [PATCH 4/6] dlm: recover nodes that are removed and re-added

2008-04-15 Thread David Teigland
is already in the member list. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/config.c | 48 +++- fs/dlm/config.h |3 ++- fs/dlm/dlm_internal.h |4 +++- fs/dlm/member.c | 34 +- fs/dlm

Re: [Cluster-devel] [PATCH 5/6] dlm: move plock code from gfs2

2008-04-15 Thread David Teigland
On Tue, Apr 15, 2008 at 04:02:26PM -0500, David Teigland wrote: Move the code that handles cluster posix locks from gfs2 into the dlm so that it can be used by both gfs2 and ocfs2. Attached is a patch to gfs_controld in STABLE2 to adapt to this change. Since the cluster STABLE2 branch is meant

Re: [Cluster-devel] [PATCH 5/6] dlm: move plock code from gfs2

2008-04-16 Thread David Teigland
On Wed, Apr 16, 2008 at 05:53:43AM +0200, Fabio M. Di Nitto wrote: On Tue, 15 Apr 2008, David Teigland wrote: On Tue, Apr 15, 2008 at 04:02:26PM -0500, David Teigland wrote: Move the code that handles cluster posix locks from gfs2 into the dlm so that it can be used by both gfs2 and ocfs2

Re: [Cluster-devel] [PATCH 5/6] dlm: move plock code from gfs2

2008-04-16 Thread David Teigland
On Wed, Apr 16, 2008 at 08:35:57AM -0500, David Teigland wrote: On Wed, Apr 16, 2008 at 05:53:43AM +0200, Fabio M. Di Nitto wrote: On Tue, 15 Apr 2008, David Teigland wrote: On Tue, Apr 15, 2008 at 04:02:26PM -0500, David Teigland wrote: Move the code that handles cluster posix locks

Re: [Cluster-devel] [PATCH 5/6] dlm: move plock code from gfs2

2008-04-16 Thread David Teigland
On Wed, Apr 16, 2008 at 08:42:11AM -0500, David Teigland wrote: On Wed, Apr 16, 2008 at 08:35:57AM -0500, David Teigland wrote: On Wed, Apr 16, 2008 at 05:53:43AM +0200, Fabio M. Di Nitto wrote: On Tue, 15 Apr 2008, David Teigland wrote: On Tue, Apr 15, 2008 at 04:02:26PM -0500, David

Re: [Cluster-devel] Cluster Project branch, STABLE2, updated. cluster-2.03.02-7-ga6b6a30

2008-05-13 Thread David Teigland
On Tue, May 13, 2008 at 09:01:13PM +0100, Steven Whitehouse wrote: Hi, It might be a silly question, but this looks to me like trying to fix a kernel bug by adding a userland one. Why not simply update the kernel to return the correct value? Yes, there's already a kernel fix in dlm.git, see

Re: [Cluster-devel] Cluster Project branch, STABLE2, updated. cluster-2.03.02-7-ga6b6a30

2008-05-14 Thread David Teigland
On Wed, May 14, 2008 at 09:56:11AM +0100, Steven Whitehouse wrote: Hi, On Tue, 2008-05-13 at 15:13 -0500, David Teigland wrote: On Tue, May 13, 2008 at 09:01:13PM +0100, Steven Whitehouse wrote: Hi, It might be a silly question, but this looks to me like trying to fix a kernel

Re: [Cluster-devel] [PATCH] checking NULL pointer in device_write of dlm-control

2008-05-28 Thread David Teigland
On Wed, May 28, 2008 at 02:45:10PM +0900, Masatake YAMATO wrote: Hi, I found a way to let linux dereference NULL pointer in gfs2-2.6-nmw/fs/dlm/user.c. If `device_write' method is called via dlm-control, file-private_data is NULL. (See ctl_device_open() in user.c. ) Through proc-flags

[Cluster-devel] Re: [Ocfs2-devel] [PATCH 0/3] ocfs2: move hb_ctl into stack glue

2008-06-02 Thread David Teigland
On Fri, May 30, 2008 at 05:36:41PM -0700, Joel Becker wrote: We have determined that ocfs2 can only leave a cluster group safely in put_super(7). The presence of bind mounts, rbind mounts, and shared subtrees make tracking mountpoints impossible in userspace. To solve this, we move the

Re: [Cluster-devel] Cluster Project branch, master, updated. cluster-2.99.03-3-ge879971

2008-06-03 Thread David Teigland
On Tue, Jun 03, 2008 at 08:55:49AM +0200, Fabio M. Di Nitto wrote: On Mon, 2 Jun 2008, Joel Becker wrote: On Tue, Jun 03, 2008 at 05:57:35AM -, [EMAIL PROTECTED] wrote: commit e879971090c6821bb966f17875874d11aa740a5c Author: Fabio M. Di Nitto [EMAIL PROTECTED] Date: Tue Jun 3 07:54:37

[Cluster-devel] cluster3 config system

2008-06-23 Thread David Teigland
It seems there's been some confusion about what the config system (ccs replacement) should be and do in cluster3. There were just two ideas I offered way back at the beginning: 1. Move the update mechanism outside the config system. 2. What remains is the part that reads the local cluster.conf

Re: [Cluster-devel] logsys in fenced

2008-06-25 Thread David Teigland
On Wed, Jun 25, 2008 at 06:19:00PM +0200, Fabio M. Di Nitto wrote: . Leave log_debug() unchanged, The only change is that it uses logsys to print instead fprintf to stderr. Like Christine already pointed out, the change to logsys is to have log output the same across the whole system. No

Re: [Cluster-devel] logsys in fenced

2008-06-26 Thread David Teigland
On Thu, Jun 26, 2008 at 05:48:56AM +0200, Fabio M. Di Nitto wrote: On Wed, 25 Jun 2008, David Teigland wrote: Attached two patches: fenced-revert.patch reverts the current logsys changes to fenced. If you revert, please do it by meaning of git-revert. That was a series of git-revert -n

Re: [Cluster-devel] [RFC] Common cluster connection handler API

2008-06-27 Thread David Teigland
On Fri, Jun 27, 2008 at 08:19:36PM +0200, Fabio M. Di Nitto wrote: I was actually hoping that with no more ccsd there'd be no more connecting to ccs, but that's probably a topic for one of the ccs meetings... The only partial advantage you have, as i documented and wrote to cluster-devel,

[Cluster-devel] logsys in cluster3

2008-06-30 Thread David Teigland
Main points from the logsys discussion we had - initialization: use functions instead of macros, don't always need logging to be working from the start of execution, can wait until function is called to start it, don't need notion of subsystems or per-source-file logging features -

[Cluster-devel] Re: [PATCH] dlm: fix uninitialized variable for search_rsb_list callers

2008-06-30 Thread David Teigland
On Mon, Jun 30, 2008 at 07:59:14PM +0300, Benny Halevy wrote: gcc 4.3.0 correctly emits the following warning. search_rsb_list does not *r_ret if no dlm_rsb is found and _search_rsb may pass the uninitialized value upstream on the error path when both calls to search_rsb_list return non-zero

Re: [Cluster-devel] logsys in cluster3

2008-06-30 Thread David Teigland
On Mon, Jun 30, 2008 at 06:38:48PM +0200, Fabio M. Di Nitto wrote: On Mon, 30 Jun 2008, David Teigland wrote: - configuration setup: big blocks of setup code are repeated and largely the same, make this less I will take care of this bit since i already done it. the api will look like

Re: [Cluster-devel] logsys in cluster3

2008-07-01 Thread David Teigland
On Tue, Jul 01, 2008 at 07:01:42AM +0200, Fabio M. Di Nitto wrote: No. You can just install the callback and be done with it. The ccs fd was never a real fd to poll. OK, it's a cman callback. If the ccs connection isn't really a connection and if it's not necessary then can we get rid of the

Re: [Cluster-devel] logsys in cluster3

2008-07-01 Thread David Teigland
On Tue, Jul 01, 2008 at 12:21:21PM -0500, David Teigland wrote: (What doesn't work yet is the test 1 output following the logsys_init() call.) was missing logsys_flush() +int logsys_init(char *name, int mode, int facility, int priority, char *file) +{ + char *errstr; Thinking about

[Cluster-devel] fenced logsys/cman/ccs setup

2008-07-01 Thread David Teigland
setup uses cman_is_active - cman setup retries cman_init and cman_is_active Signed-off-by: David Teigland [EMAIL PROTECTED] diff --git a/fence/fenced/Makefile b/fence/fenced/Makefile index 1e9bbc9..61ec989 100644 --- a/fence/fenced/Makefile +++ b/fence/fenced/Makefile @@ -15,7 +15,8

Re: [Cluster-devel] fenced logsys/cman/ccs setup

2008-07-02 Thread David Teigland
On Wed, Jul 02, 2008 at 06:31:10AM +0200, Fabio M. Di Nitto wrote: @@ -9,18 +11,62 @@ static int open_ccs(void) sleep(1); if (++i 9 !(i % 10)) log_error(connect to ccs error %d, - check ccsd or cluster status, cd);

Re: [Cluster-devel] fenced logsys/cman/ccs setup

2008-07-02 Thread David Teigland
On Wed, Jul 02, 2008 at 10:49:05AM -0500, David Teigland wrote: #define DEFAULT_FILE LOGDIR /fenced.log LOGDIR is set by the build system (same reasons as SYSLOGFACILITY). We want files by default consistently across the board. I think that by default we should probably have all

Re: [Cluster-devel] fenced logsys/cman/ccs setup

2008-07-02 Thread David Teigland
On Wed, Jul 02, 2008 at 08:22:54PM +0200, Fabio M. Di Nitto wrote: I was thinking about the error messages we're switching from syslog to logsys. So, how do we tell logsys to use /var/log/messages for errors and a separate file for debug output? Why do you need this? Remember that you are

[Cluster-devel] cluster.git at fedorahosted.org

2008-07-22 Thread David Teigland
We're planning to move the cluster git tree to fedorahosted.org, to take advantage of the CLA system in place there. To push changes to the new git tree you'll need to: - Set up an account at https://admin.fedoraproject.org/accounts/user/new - Sign the CLA on your new account page - Request

Re: [Cluster-devel] [PATCH/RFC] Standardize on /etc/sysconfig/cluster for init script

2008-07-30 Thread David Teigland
On Mon, Jul 28, 2008 at 10:20:49AM +0200, Fabio M. Di Nitto wrote: Hi guys, I just noticed that we have a very inconsistent way to set init script defaults by using /etc/sysconfig/{cman,cluster,scsi_reserve}. the patch in attachment is very simple and standardize everything to

[Cluster-devel] some new daemon code in cluster3

2008-08-04 Thread David Teigland
is used. groupd is used for the detection of old nodes. Previously, the daemons defaulted to groupd_compat=1. After the commit below, the daemons were changed to default to groupd_compat=2. - Forwarded message from David Teigland [EMAIL PROTECTED] - Subject: master - groupd: detect

[Cluster-devel] unifying fencing/stonith

2008-10-08 Thread David Teigland
As discussed at the Prague cluster summit, here is a description of what a unified fencing/stonith system might look like. I've used fenced as a starting point, and added/changed things according to what I learned about pacemaker/stonith. . what causes fencing The fenced daemon will join a cpg.

Re: [Cluster-devel] When is fencing considered successful?

2008-10-29 Thread David Teigland
On Wed, Oct 29, 2008 at 11:12:41AM -0500, Kevin Anderson wrote: Hi all, Recently we had cluster customer where the fencing agent successfully powered off a node, but the script failed to power the node back on due to firmware changes on the fencing device. Question is whether we should

[Cluster-devel] cluster/logging settings

2008-10-30 Thread David Teigland
The new logging section in cluster.conf has the following settings: to_stderr to_syslog to_file syslog_facilty syslog_level logfile debug Here is my interpretation of how they all work: a,b,c,x,y,z are connections that are all *controlled independently* a is always on b is always on c is

Re: [Cluster-devel] cluster/logging settings

2008-10-30 Thread David Teigland
On Thu, Oct 30, 2008 at 07:20:21PM +0100, Fabio M. Di Nitto wrote: a,b,c,x,y,z are connections that are all *controlled independently* a is always on b is always on c is connected if debug=on x is connected if to_stderr=yes y is connected if to_syslog=yes z is connected if to_file=yes

Re: [Cluster-devel] cluster/logging settings

2008-11-04 Thread David Teigland
On Thu, Oct 30, 2008 at 11:26:14PM -0700, Steven Dake wrote: There are two types of messages. Those intended for users/admins and those intended for developers. Both of these message types should always be recorded *somewhere*. The entire concept of LOG_LEVEL_DEBUG is dubious to me. If

Re: [Cluster-devel] cluster/logging settings

2008-11-04 Thread David Teigland
On Tue, Nov 04, 2008 at 02:58:47PM -0600, David Teigland wrote: the cluster.conf logging/ section? My suggestion is: syslog_level=foo logfile_level=bar FWIW, I'm not set on this if someone has a better suggestion. I just want something unambiguous. debug=on has been shown to mean

Re: [Cluster-devel] logging: final call on configuration, output and implementation

2008-11-10 Thread David Teigland
On Mon, Nov 10, 2008 at 08:09:10PM +0100, Fabio M. Di Nitto wrote: Hi all, those logging threads have been going on for way too long. It's time to close them and make a final decision. This is a long email, so please take time to read it all. This is a recap of what I believe a user would

[Cluster-devel] Re: [DLM] Fix up memory alloc/kmap

2008-11-13 Thread David Teigland
On Thu, Nov 13, 2008 at 09:56:18AM +, Steven Whitehouse wrote: It is left as an exercise for the reader to consider whether its a bug that DLM isn't using highmem pages for its internal buffers (in which case we'd have to solve the allocation problem at kmap time), or whether its a bug

Re: [Cluster-devel] [RFC] Splitting cluster.git into separate projects/trees

2008-11-14 Thread David Teigland
On Fri, Nov 14, 2008 at 10:18:13AM +0100, Fabio M. Di Nitto wrote: At this point we haven't really settled how many (sub) project will be created out of this split. This will come once we agree how to split. I like the third option as long as the number of new git trees doesn't explode

Re: [Ocfs2-devel] [Cluster-devel] [RFC] Splitting cluster.git into separate projects/trees

2008-11-14 Thread David Teigland
On Fri, Nov 14, 2008 at 10:11:00PM +0100, Andrew Beekhof wrote: I'd have thought fence.git and fence-agents.git in one and cman.git and rgmanager.git in another. But I may be missing some of the interdependencies. I wouldn't mind either of those combinations. Maybe rgmanager's last stand will

[Cluster-devel] Re: Groupd uevent clean up

2008-11-25 Thread David Teigland
On Tue, Nov 25, 2008 at 02:08:42PM +, Steven Whitehouse wrote: The following patch is designed to clean up a number of items relating to gfs_controld's handling of uevent notifications. When a uevent is received is consists of a number of strings whose total length is bounded by the

Re: [Cluster-devel] Re: cluster: master - GFS: Send sensible sysfs stuff

2008-12-01 Thread David Teigland
On Wed, Nov 26, 2008 at 07:28:57PM +0100, Fabio M. Di Nitto wrote: On Wed, 26 Nov 2008, Steven Whitehouse wrote: Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=248b15142287c002e232f5a0595d9e3ca446a31e Commit:

Re: [Cluster-devel] GFS2: Send useful information with uevent messages

2008-12-01 Thread David Teigland
On Thu, Nov 27, 2008 at 10:45:21AM +, Steven Whitehouse wrote: From 04b985e291c464092516d0d1a4387b866389a85d Mon Sep 17 00:00:00 2001 From: Steven Whitehouse [EMAIL PROTECTED] Date: Thu, 27 Nov 2008 09:42:51 + Subject: [PATCH] GFS2: Send useful information with uevent messages In

[Cluster-devel] Re: Groupd uevent clean up

2008-12-01 Thread David Teigland
On Fri, Nov 28, 2008 at 11:07:56AM +, Steven Whitehouse wrote: LOCKTABLE=clustername:fsname LOCKPROTO=[lock_dlm|lock_nolock] to avoid all the messy parsing of the initial event string. Also I've added come further information to the two change events, so that we now have:

[Cluster-devel] gfs uevent and sysfs changes

2008-12-01 Thread David Teigland
Here are the compatibility aspects to the recent ideas about changes to the user/kernel interface between gfs (1 2) and gfs_controld. . gfs_controld can remove id from hostdata string in mount options - no compat issues AFAICT . getting rid of id sysfs file from lock_dlm - new

Re: [Cluster-devel] gfs uevent and sysfs changes

2008-12-04 Thread David Teigland
On Thu, Dec 04, 2008 at 01:32:31PM -0500, david m. richter wrote: On Mon, Dec 1, 2008 at 12:31 PM, David Teigland [EMAIL PROTECTED] wrote: Here are the compatibility aspects to the recent ideas about changes to the user/kernel interface between gfs (1 2) and gfs_controld. . gfs_controld

  1   2   3   4   >