inconsistant -> inconsistent
filesytem -> filesystem
hexidecimal -> hexadecimal
---
gfs2/convert/gfs2_convert.c | 2 +-
gfs2/fsck/metawalk.c| 2 +-
gfs2/man/gfs2_edit.8| 4 ++--
po/gfs2-utils.pot | 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/gfs
---
gfs2/scripts/gfs2_lockcapture | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/gfs2/scripts/gfs2_lockcapture b/gfs2/scripts/gfs2_lockcapture
index 5fe92bc3..424499e6 100644
--- a/gfs2/scripts/gfs2_lockcapture
+++ b/gfs2/scripts/gfs2_lockcap
---
gfs2/scripts/gfs2_trace | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/gfs2/scripts/gfs2_trace b/gfs2/scripts/gfs2_trace
index 38b3d185..b19cade5 100644
--- a/gfs2/scripts/gfs2_trace
+++ b/gfs2/scripts/gfs2_trace
@@ -119,7 +119,7 @@ class FileUtils:
On Fri, Apr 06, 2018 at 11:24:16AM +0100, Andrew Price wrote:
> Both patches pushed - thanks!
Great, thanks. Please also check the spelling patch from yesterday :)
--
Valentin
Hello,
We are starting to see mkfs segfaults after updating
linux-libc-dev from 4.15.17-1 to 4.16.5-1 due to a
change in gfs2_ondisk.h. Hope there is enough info
below for a fix? :)
Reading symbols from ./gfs2-utils-3.1.10/gfs2/mkfs/mkfs.gfs2...done.
(gdb) run -p lock_nolock test
Starting progr
On Fri, May 04, 2018 at 11:42:31AM +0200, Valentin Vidic wrote:
> We are starting to see mkfs segfaults after updating
> linux-libc-dev from 4.15.17-1 to 4.16.5-1 due to a
> change in gfs2_ondisk.h. Hope there is enough info
> below for a fix? :)
Here goes another trace:
Replace call to nonexisting util_max_blocks.
Signed-off-by: Valentin Vidic
---
tests/mkfs.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/mkfs.at b/tests/mkfs.at
index 7ae6fcc2..ee444f50 100644
--- a/tests/mkfs.at
+++ b/tests/mkfs.at
@@ -52,7 +52,7 @@ AT_CLEANUP
On Fri, May 04, 2018 at 11:27:35AM +0100, Andrew Price wrote:
> One other thing to check is whether ./configure was re-run after
> gfs2_ondisk.h was upgraded.
Yes, just restoring the previous version (4.15) of
/usr/include/linux/gfs2_ondisk.h
fixes the tests.
--
Valentin
On Fri, May 04, 2018 at 11:46:08AM +0100, Andrew Price wrote:
> Ok, so just to be clear, after installing the 4.16 gfs2_ondisk.h and then
> doing "./configure && make clean && make" the bug still occurs?
That is correct, attaching 4.16 gfs2_ondisk.h so you can test.
--
Valentin
/* SPDX-License-I
On Fri, May 04, 2018 at 12:07:01PM +0100, Andrew Price wrote:
> Hm curious. I *can* reproduce the same segfaults but only if I build with
> the 4.15 header and then rebuild with the 4.16 header *without* first
> running ./configure. If I run ./configure the problem resolves itself.
Thanks, I remov
On Fri, May 04, 2018 at 02:16:24PM +0100, Andrew Price wrote:
> Try this.
Thanks, only meta test fails now, probably size check in some other place:
## - ##
## Test results. ##
## - ##
ERROR: All 30 tests were run,
1 failed unexpectedly.
## ##
##
Parallel distclean removes testsuite before it is finished
running, causing make error.
Signed-off-by: Valentin Vidic
---
tests/Makefile.am | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 1dedc2b2..e52aab4c 100644
--- a/tests
On Wed, May 09, 2018 at 05:53:19PM +0100, Andrew Price wrote:
> You should be able to fix this by using the configure.ac and
> gfs2/libgfs2/meta.c files from master. The diff should be very small. It'll
> need an ./autogen.sh to rebuild the configure script.
>
> The downside of that approach is th
On Wed, May 09, 2018 at 05:53:19PM +0100, Andrew Price wrote:
> You should be able to fix this by using the configure.ac and
> gfs2/libgfs2/meta.c files from master. The diff should be very small. It'll
> need an ./autogen.sh to rebuild the configure script.
>
> The downside of that approach is th
On Mon, May 14, 2018 at 02:24:38PM +0100, Andrew Price wrote:
> We can still keep this minimal if that's better for the Debian package.
>
> The issue is due to the log header checksum (lh_hash) being calculated using
> sizeof(struct gfs2_log_header) and that size has increased in the latest
> kern
Tests fail when /bin/sh is not /bin/bash due to missing let command:
21: Values of rg_data0, rg_data, rg_bitbytesFAILED (mkfs.at:146)
/<>/tests/rgrifieldscheck.sh: 19: let: not found
---
tests/rgrifieldscheck.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/r
Check exit codes from each of the subdirectories.
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index dd29bcea..ab069a1c 100644
--- a/Makefile
+++ b/Makefile
@@ -1,2 +1,2 @@
all install clean: %:
- for d in libdlm dlm_controld dlm_tool
plock.c: In function ‘write_result’:
plock.c:691:2: warning: ignoring return value of ‘write’, declared with
attribute warn_unused_result [-Wunused-result]
write(plock_device_fd, in, sizeof(struct dlm_plock_info));
^
---
dlm_controld/plo
From: Helmut Grohne
dlm fails to cross build from source, because the upstream Makefile
hard codes the build architecture pkg-config. The attached patch
makes pkg-config substitutable.
Signed-off-by: Valentin Vidic
---
dlm_controld/Makefile | 5 +++--
1 file changed, 3 insertions(+), 2
On Fri, Sep 04, 2020 at 04:13:08AM +0100, Andrew Price wrote:
> The "Bus error"s suggest it's failing on an unaligned access somewhere in
> restoremeta, so just armhf and sparc64 are affected. I'll look into it.
Thanks, there is a lot of [-Wcast-align] warnings in the build log that
could be relev
On Fri, Sep 04, 2020 at 02:42:10PM +0100, Andrew Price wrote:
> I'm pretty sure I know which change added the bug, but my Debian sparc64 vm
> is hitting this problem too frequently to test:
>
> https://lkml.org/lkml/2020/5/18/1455
>
> So probably the best I can do is build with -Wcast-align=stric
On Mon, Sep 07, 2020 at 02:00:41PM +0100, Andrew Price wrote:
> It should be consistent if it's the same alignment issue, I think. Perhaps
> the build machines are different flavours of arm?
That is possible, second build was scheduled on a different machine.
> Could you give this one a try:
>
>
On Mon, Feb 13, 2023 at 04:54:26PM +, Andrew Price wrote:
> It's now in main: https://pagure.io/gfs2-utils/c/a3f3aadc
Great, thank you for the quick response. Updated package is building
correctly now:
https://buildd.debian.org/status/package.php?p=gfs2-utils
--
Valentin
On Tue, Feb 14, 2023 at 06:18:55AM +0100, Fabio M. Di Nitto wrote:
> The process would have to look like:
>
> (usual)
> apt-get install
> git clone gfs2-utils
> export CFLAGS/LDFLAGS/CC or whatever env var
>
> ./autogen.sh
> ./configure..
> make
> make
>
> Using other build tools like debbuil
24 matches
Mail list logo
