If allocation fails on last elements of array need to free already
allocated elements.
Fixes 789924ba635f ("dlm: fix race between remove and lookup")
Cc: sta...@kernel.org # 3.6
Signed-off-by: Vasily Averin
---
fs/dlm/lockspace.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletio
Dear David,
I've noticed that release_lockspace() lacks idr_destroy(&ls->ls_recover_idr),
though it is called on rollback in new_lockspace().
It seems for me it is not critical, and should not lead to any leaks,
however could you please re-check it?
Thank you,
Vasily Averin
ned-off-by: Vasily Averin
---
fs/dlm/lock.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 03d767b94f7b..a928ba008d7d 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -5795,20 +5795,20 @@ int dlm_user_request(struct dlm_ls *
If allocation fails on last elements of array need to free already
allocated elements.
v2: just move existing out_rsbtbl label to right place
Fixes 789924ba635f ("dlm: fix race between remove and lookup")
Cc: sta...@kernel.org # 3.6
Signed-off-by: Vasily Averin
---
fs/dlm/locks
Fixes 6d40c4a708e0 ("dlm: improve error and debug messages")
Cc: sta...@kernel.org # 3.5
Signed-off-by: Vasily Averin
---
fs/dlm/lock.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 2cb125cc21c9..03d767b94f7b 100644
--- a/fs/dlm/lock.c
++
Fixes 3d6aa675fff9 ("dlm: keep lkbs in idr")
Cc: sta...@kernel.org # 3.1
Signed-off-by: Vasily Averin
---
fs/dlm/lock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index cc91963683de..2cb125cc21c9 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
are lot of other affected files, I've found 30+ including
/proc/net/ip_tables_matches and /proc/sysvipc/*
Following patch fixes the problem in dlm-related file
https://bugzilla.kernel.org/show_bug.cgi?id=206283
Vasily Averin (1):
table_seq_next should increase position index
fs/dlm/debug_
if seq_file .next fuction does not change position index,
read after some lseek can generate unexpected output.
https://bugzilla.kernel.org/show_bug.cgi?id=206283
Signed-off-by: Vasily Averin
---
fs/dlm/debug_fs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/dlm
utput following bash script will
never finish.
$ q=;while read -r r;do echo "$((++q)) $r";done < AFFECTED_FILE
Thank you,
Vasily Averin
On 1/24/20 9:03 AM, Vasily Averin wrote:
> if seq_file .next fuction does not change position index,
> read after some lseek can