Re: [Cluster-devel] [GFS2 PATCH] gfs2: Panic when an io error occurs writing

2018-12-19 Thread Steven Whitehouse
-devel] [GFS2 PATCH] gfs2: Panic when an io error occurs writing - Original Message - Hi Bob, I agree, it's a hard problem. I'm just trying to understand that we've done the absolute best we can and that if this condition is hit then the best solution really is to just kill the node. I

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Panic when an io error occurs writing

2018-12-18 Thread Mark Syms
: 18 December 2018 15:52 To: Mark Syms Cc: cluster-devel@redhat.com Subject: Re: [Cluster-devel] [GFS2 PATCH] gfs2: Panic when an io error occurs writing - Original Message - > Hi Bob, > > I agree, it's a hard problem. I'm just trying to understand that we've > done the abso

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Panic when an io error occurs writing

2018-12-18 Thread Bob Peterson
- Original Message - > Hi Bob, > > I agree, it's a hard problem. I'm just trying to understand that we've done > the absolute best we can and that if this condition is hit then the best > solution really is to just kill the node. I guess it's also a question of > how common this actually

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Panic when an io error occurs writing

2018-12-18 Thread Mark Syms
PATCH] gfs2: Panic when an io error occurs writing - Original Message - > I think a reasonable alternative to this is to just sit in an infinite > retry loop until the i/o succeeds. > > Dave > [Mark Syms] I would hope that this code would only trigger after some > e

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Panic when an io error occurs writing

2018-12-17 Thread Bob Peterson
- Original Message - > I think a reasonable alternative to this is to just sit in an infinite retry > loop until the i/o succeeds. > > Dave > [Mark Syms] I would hope that this code would only trigger after some effort > has been put into retrying as panicing the host on the first I/O

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Panic when an io error occurs writing

2018-12-17 Thread Mark Syms
On Mon, Dec 17, 2018 at 09:58:47AM -0500, Bob Peterson wrote: > Dave Teigland recommended. Unless I'm mistaken, Dave has said that > GFS2 should never withdraw; it should always just kernel panic (Dave, > correct me if I'm wrong). At least this patch confines that behavior > to a small subset

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Panic when an io error occurs writing to the journal

2018-12-17 Thread David Teigland
On Mon, Dec 17, 2018 at 09:58:47AM -0500, Bob Peterson wrote: > Dave Teigland recommended. Unless I'm mistaken, Dave has said that GFS2 > should never withdraw; it should always just kernel panic (Dave, correct > me if I'm wrong). At least this patch confines that behavior to a small > subset of

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Panic when an io error occurs writing to the journal

2018-12-17 Thread Bob Peterson
Hi, - Original Message - > On 17/12/2018 09:04, Edwin Török wrote: > >> If we get an io error writing to the journal, the only correct > >> thing to do is to kernel panic. > > Hi, > > > > That may be required for correctness, however are we sure there is no > > other way to force the DLM

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Panic when an io error occurs writing to the journal

2018-12-17 Thread Steven Whitehouse
Hi, On 17/12/2018 09:04, Edwin Török wrote: On 17/12/2018 13:54, Bob Peterson wrote: Hi, Before this patch, gfs2 would try to withdraw when it encountered io errors writing to its journal. That's incorrect behavior because if it can't write to the journal, it cannot write revokes for the

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Panic when an io error occurs writing to the journal

2018-12-17 Thread Edwin Török
On 17/12/2018 13:54, Bob Peterson wrote: > Hi, > > Before this patch, gfs2 would try to withdraw when it encountered > io errors writing to its journal. That's incorrect behavior > because if it can't write to the journal, it cannot write revokes > for the metadata it sends down. A withdraw will