Re: [Cluster-devel] [PATCH] gfs2: skip dlm_unlock calls in unmount

2012-11-14 Thread Steven Whitehouse
Hi, Now pushed to the -nmw git tree. Thanks, Steve. On Tue, 2012-11-13 at 10:58 -0500, David Teigland wrote: > When unmounting, gfs2 does a full dlm_unlock operation on every > cached lock. This can create a very large amount of work and can > take a long time to complete. However, the vast ma

Re: [Cluster-devel] [PATCH] gfs2: skip dlm_unlock calls in unmount

2012-11-12 Thread David Teigland
On Mon, Nov 12, 2012 at 10:44:36AM +, Steven Whitehouse wrote: > > - save 64 bytes of memory for every local lock > > (32 in gfs2_glock, 32 in dlm_rsb) > > > > - save 96 bytes of memory for every remote lock > > (32 in gfs2_glock, 32 in local dlm_rsb, 32 in remote dlm_lkb) > > > > - save

Re: [Cluster-devel] [PATCH] gfs2: skip dlm_unlock calls in unmount

2012-11-12 Thread Steven Whitehouse
Hi, On Fri, 2012-11-09 at 10:30 -0500, David Teigland wrote: > On Fri, Nov 09, 2012 at 09:45:17AM +, Steven Whitehouse wrote: > > > + if (test_bit(SDF_SKIP_DLM_UNLOCK, &sdp->sd_flags) && > > > + (!gl->gl_lvb[0] || gl->gl_state != LM_ST_EXCLUSIVE)) { > > I'm still not happy with using !gl->

Re: [Cluster-devel] [PATCH] gfs2: skip dlm_unlock calls in unmount

2012-11-09 Thread David Teigland
On Fri, Nov 09, 2012 at 09:45:17AM +, Steven Whitehouse wrote: > > + if (test_bit(SDF_SKIP_DLM_UNLOCK, &sdp->sd_flags) && > > + (!gl->gl_lvb[0] || gl->gl_state != LM_ST_EXCLUSIVE)) { > I'm still not happy with using !gl->gl_lvb[0] to determine whether the > LVB is in use or not. I think

Re: [Cluster-devel] [PATCH] gfs2: skip dlm_unlock calls in unmount

2012-11-09 Thread Steven Whitehouse
Hi, On Thu, 2012-11-08 at 16:34 -0500, David Teigland wrote: > When unmounting, gfs2 does a full dlm_unlock operation on every > cached lock. This can create a very large amount of work and can > take a long time to complete. However, the vast majority of these > dlm unlock operations are unnece