Re: [Cluster-devel] [PATCH] idr: fix a subtle bug in idr_get_next()

2013-02-05 Thread David Teigland
On Sat, Feb 02, 2013 at 03:11:35PM -0800, Tejun Heo wrote: On Sat, Feb 02, 2013 at 03:10:48PM -0800, Tejun Heo wrote: Fix it by ensuring proceeding to the next slot doesn't carry over the unaligned offset - ie. use round_up(id + 1, slot_distance) instead of id += slot_distance.

Re: [Cluster-devel] [PATCH] idr: fix a subtle bug in idr_get_next()

2013-02-03 Thread Randy Dunlap
On 02/02/13 15:11, Tejun Heo wrote: On Sat, Feb 02, 2013 at 03:10:48PM -0800, Tejun Heo wrote: Fix it by ensuring proceeding to the next slot doesn't carry over the unaligned offset - ie. use round_up(id + 1, slot_distance) instead of id += slot_distance. Signed-off-by: Tejun Heo

Re: [Cluster-devel] [PATCH] idr: fix a subtle bug in idr_get_next()

2013-02-02 Thread Tejun Heo
On Sat, Feb 02, 2013 at 03:10:48PM -0800, Tejun Heo wrote: Fix it by ensuring proceeding to the next slot doesn't carry over the unaligned offset - ie. use round_up(id + 1, slot_distance) instead of id += slot_distance. Signed-off-by: Tejun Heo t...@kernel.org Reported-by: David Teigland