Re: [Cluster-devel] [PATCH 07/12] gfs2: Get rid of on-stack transactions

2020-12-14 Thread Steven Whitehouse
Hi, On 14/12/2020 14:02, Bob Peterson wrote: Hi, - Original Message - + ret = __gfs2_trans_begin(sdp, 0, revokes, GFP_NOFS | __GFP_NOFAIL); The addition of __GFP_NOFAIL means that this operation can now block. Looking at the code, I don't think it will be a problem because it

Re: [Cluster-devel] [PATCH 07/12] gfs2: Get rid of on-stack transactions

2020-12-14 Thread Bob Peterson
Hi, - Original Message - > + ret = __gfs2_trans_begin(sdp, 0, revokes, GFP_NOFS | __GFP_NOFAIL); The addition of __GFP_NOFAIL means that this operation can now block. Looking at the code, I don't think it will be a problem because it can already block in the log_flush operations that