Re: [Cluster-devel] [libgfs2 PATCH] libgfs2: Make rg repair do better sanity checks on rindex

2017-01-16 Thread Andrew Price
Hi Bob, On 13/01/17 20:26, Bob Peterson wrote: Hi Andy, I debugged all this. Here is a replacement patch for the bug you found in my patch, and I'll post three others shortly, for the bug(s) I found in testing it. All I changed, really was: I added: "*sane && " to the if. Bob Peterson --- This

Re: [Cluster-devel] [libgfs2 PATCH] libgfs2: Make rg repair do better sanity checks on rindex

2017-01-13 Thread Bob Peterson
- Original Message - | Hi Bob, | | On 13/01/17 13:40, Bob Peterson wrote: | > Hi, | > | > This patch changes the checks done on the rindex file. Before, if | > the rindex addresses weren't perfectly aligned and equally spaced, | > it considered the rindex not sane. However, in most cases i

Re: [Cluster-devel] [libgfs2 PATCH] libgfs2: Make rg repair do better sanity checks on rindex

2017-01-13 Thread Bob Peterson
- Original Message - | Hi Bob, | | On 13/01/17 13:40, Bob Peterson wrote: | > Hi, | > | > This patch changes the checks done on the rindex file. Before, if | > the rindex addresses weren't perfectly aligned and equally spaced, | > it considered the rindex not sane. However, in most cases i

Re: [Cluster-devel] [libgfs2 PATCH] libgfs2: Make rg repair do better sanity checks on rindex

2017-01-13 Thread Andrew Price
Hi Bob, On 13/01/17 13:40, Bob Peterson wrote: Hi, This patch changes the checks done on the rindex file. Before, if the rindex addresses weren't perfectly aligned and equally spaced, it considered the rindex not sane. However, in most cases it should be sane. Rather than flag this as a violati