Re: [cmake-developers] [PATCH] CMakeFindPackageMode.cmake: fix 32/64bit detection if `file' is a symlink

2012-02-24 Thread Brad King
On 2/23/2012 4:39 PM, Yury G. Kudryashov wrote: From: Yury G. Kudryashovurkud.ur...@gmail.com Applied, thanks: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=19ab5819 -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at

Re: [cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Alexander Neundorf
On Friday 24 February 2012, Brad King wrote: On 2/24/2012 5:31 AM, Stephen Kelly wrote: When building with Qt5, we want to change the convention away from USE files, and towards a concept of using packages whose variables have conventional names, mostly those conventions in the

Re: [cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Alexander Neundorf
On Friday 24 February 2012, Stephen Kelly wrote: Hi there, When building Qt5 projects with CMake, you will use something like this: find_package(Qt5Widgets REQUIRED) find_package(Qt5Xml REQUIRED) The result is that several variables are populated with information needed to build your

Re: [cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Brad King
On 2/24/2012 12:19 PM, Alexander Neundorf wrote: On Friday 24 February 2012, Brad King wrote: and INCLUDE_DIRECTORIES. This will require C++ implementation but will be much more powerful than the proposed macro. Just the simple target_link_libraries(A B) command would be enough to

[cmake-developers] compiler version variables

2012-02-24 Thread Brad King
On 2/24/2012 11:50 AM, Rolf Eike Beer wrote: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c28e2769482c12da53a3c01ea45f9ae6cdc1de34 commit c28e2769482c12da53a3c01ea45f9ae6cdc1de34 Author: Rolf Eike Beere...@sf-mail.de AuthorDate: Fri Feb 24 17:48:02 2012 +0100 Commit: Rolf Eike

Re: [cmake-developers] compiler version variables

2012-02-24 Thread Rolf Eike Beer
Brad King wrote: On 2/24/2012 11:50 AM, Rolf Eike Beer wrote: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c28e2769482c12da53a3c01 ea45f9ae6cdc1de34 commit c28e2769482c12da53a3c01ea45f9ae6cdc1de34 Author: Rolf Eike Beere...@sf-mail.de AuthorDate: Fri Feb 24 17:48:02 2012 +0100

Re: [cmake-developers] compiler version variables

2012-02-24 Thread Brad King
On 2/24/2012 1:15 PM, Rolf Eike Beer wrote: Brad King wrote: FYI, this variable is not set by all generators yet. It is computed as Ok, but they should work for GCC and Intel, no? And this stuff as part of CMake qualifies as internal use? So I have nothing to change? Sure it is internal

Re: [cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Clinton Stimpson
On Friday, February 24, 2012 03:31:35 am Stephen Kelly wrote: Hi there, When building Qt5 projects with CMake, you will use something like this: find_package(Qt5Widgets REQUIRED) find_package(Qt5Xml REQUIRED) The result is that several variables are populated with information needed to

Re: [cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Brad King
On 2/24/2012 1:56 PM, Clinton Stimpson wrote: What about a more generic approach like the following? add_library(foo IMPORTED ...) set_target_properties(foo PROPERTIES DEPENDENT_COMPILE_DEFINITIONS FOO_DEFINE DEPENDENT_INCLUDE_DIRECTORIES /path/to/foo/include) add_executable(bar

Re: [cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Clinton Stimpson
On Feb 24, 2012, at 12:00 PM, Brad King wrote: On 2/24/2012 1:56 PM, Clinton Stimpson wrote: What about a more generic approach like the following? add_library(foo IMPORTED ...) set_target_properties(foo PROPERTIES DEPENDENT_COMPILE_DEFINITIONS FOO_DEFINE

[cmake-developers] Coding style questions

2012-02-24 Thread Yury G. Kudryashov
Hi! I have a few questions about cmake coding style: 1. Some classes/methods have doxygen comments, others haven't. Will you accept patches that add such comments? 2. The same about 'const' qualifiers on methods. 3. When do you use std::string vs char *? 3a. What is the difference between

Re: [cmake-developers] [PATCH] Remove unused file cmake.1

2012-02-24 Thread Brad King
On 2/24/2012 2:29 PM, Yury G. Kudryashov wrote: From: Yury G. Kudryashovurkud.ur...@gmail.com --- cmake.1 | 112 --- 1 files changed, 0 insertions(+), 112 deletions(-) delete mode 100644 cmake.1 Wow, I totally forgot about that

Re: [cmake-developers] Coding style questions

2012-02-24 Thread Brad King
On 2/24/2012 2:32 PM, Yury G. Kudryashov wrote: 1. Some classes/methods have doxygen comments, others haven't. Will you accept patches that add such comments? Sure, as long as they are accurate :) We started that way back in the beginning but haven't really maintained it. As more

[cmake-developers] [PATCH] Fix typo in documentation

2012-02-24 Thread Yury G. Kudryashov
From: Yury G. Kudryashov urkud.ur...@gmail.com --- Source/cmDocumentVariables.cxx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Source/cmDocumentVariables.cxx b/Source/cmDocumentVariables.cxx index 1cab2b5..366ebaa 100644 --- a/Source/cmDocumentVariables.cxx +++

Re: [CMake] apply for maintainer of FindOpenCL.cmake

2012-02-24 Thread Michael Wild
On 02/24/2012 10:52 AM, yao wang wrote: Hi, We've written a module finding AMD's APP SDK's include abd library paths. And set OPENCL_INCLUDE_DIR and OPENCL_LIBRARY, which are useful for compiling OpenCL programs. Is it possible for me to contribute to the share modules and make it included

Re: [CMake] apply for maintainer of FindOpenCL.cmake

2012-02-24 Thread Daniel Dekkers
It would be nice to have an OpenCL find module. But it should include easy access to the Intel and NVIDIA libraries as well, I think, not just AMD. And what about the different OpenCL versions? And does it work on Mac OS as well? Finding the OpenCL framework? Daniel Op 24 feb. 2012 om 06:00

Re: [CMake] mingw vs MSYS makefiles

2012-02-24 Thread Andrea Crotti
On 02/23/2012 10:55 PM, Bill Hoffman wrote: On 2/23/2012 6:20 AM, Andrea Crotti wrote: I don't think anyone really addressed your question. Your question seems to have taken on a whole new life The problem seems to be that your cmake file is creating makefiles that use a python

Re: [CMake] apply for maintainer of FindOpenCL.cmake

2012-02-24 Thread Stefan Fendt
Hi, It would be nice to have an OpenCL find module. But it should include easy access to the Intel and NVIDIA libraries as well, I think, not just AMD. I'm not an CMake-expert... but maybe my variant of a FindOpenCL.cmake might be of some use for someone... best regards Stefan Fendt #

Re: [CMake] apply for maintainer of FindOpenCL.cmake

2012-02-24 Thread Sergiu Dotenco
On 24.02.2012 11:11, Daniel Dekkers wrote: It would be nice to have an OpenCL find module. But it should include easy access to the Intel and NVIDIA libraries as well, I think, not just AMD. And what about the different OpenCL versions? And does it work on Mac OS as well? Finding the OpenCL

Re: [CMake] mingw vs MSYS makefiles

2012-02-24 Thread Bill Hoffman
On 2/24/2012 5:25 AM, Andrea Crotti wrote: Ideally yes, unfortunately it's not really possible to avoid the python call, without rewriting a lot of code in CMake/C (which is not a good idea). I will check what is the requirement, if the MinGW make is fine then I'll just use that otherwise

Re: [CMake] Code and API review request for Qt5 CMake files

2012-02-24 Thread Stephen Kelly
Just forwarding to the cmake users list. Stephen Kelly wrote: Hi there, Qt5 generates its own CMake files, which you will be able to use to find Qt5 and build with it. That is, you will port from, eg find_package(Qt4 REQUIRED Core Gui Xml) to find_package(Qt5Widgets

Re: [CMake] lexical scoping ... back to the future !

2012-02-24 Thread aaron . meadows
Very fascinating! I've similarly had to deal with spiraling dependencies in our local code. I had two thoughts toward the problems you mentioned below. To handle unique naming of temporaries, you could do something like introduce a counter (probably as a global property) and append it to

Re: [CMake] simplest possible NSIS package

2012-02-24 Thread Eric Noulard
2012/2/23 Andrea Crotti andrea.crott...@gmail.com: On 02/23/2012 04:48 PM, John Drescher wrote: Just to make you laugh I found the source of the problem. Apparently if you try to run an installer from a directory which is on a shared directory (with the virtualbox sharing) it just won't run

[CMake] add_executable and extension of source file

2012-02-24 Thread Kris Thielemans
Hi I have a project where I have C++ and C source files. I'm adding executables for this (via macros) like this foreach(executable ${SOURCES}) add_executable(${executable} ${executable} ) target_link_libraries(${executable} ${STIR_LIBRARIES}) endforeach() where ${SOURCES} is a list of

Re: [CMake] Is there a cookbook?

2012-02-24 Thread Oliver Smith
On 2/23/2012 9:37 PM, John Drescher wrote: You probably want to do some type of file GLOBBING for that Here is an example of file globbing (along with its pitfalls): http://www.cmake.org/pipermail/cmake/2010-September/039558.html I am sorry. It does not look like the code to glob is there.

Re: [CMake] Is there a cookbook?

2012-02-24 Thread John Drescher
but my point here is that we really need a CMake CookBook or snippet repository. I always hit the FAQ first, but that /explains/ when what a coder tends to need in that frame of mind is a living example. Maybe some user committed examples in the wiki just like what has been done for the vtk

[CMake] Can't generate Release build in Visual Studio 9

2012-02-24 Thread Mauricio Klein
Hello fellows! I'm using CMake to compile and CPack to pack my codes. The Linux version is working very well. But now i'm porting the CMakeLists.txt to Windows and i'm having some problems: My main problem is: how can i set the build type in Visual Studio to Release instead Debug? I've already

Re: [CMake] Can't generate Release build in Visual Studio 9

2012-02-24 Thread Kris Thielemans
Hi Mauricio The SLN solution contains all possible build-types. The user just have to select which one they want (i.e. in Visual Studio, not cmake) Kris -Original Message- From: cmake-boun...@cmake.org [mailto:cmake-boun...@cmake.org] On Behalf Of Mauricio Klein Sent: 24 February

Re: [CMake] Can't generate Release build in Visual Studio 9

2012-02-24 Thread John Drescher
2. Do batch building. I do this option. Look at the cmake --build command Here is an example of this for one of my current projects (not exactly what I do but close enough): rem configure pushd . cd X:\64Bit\VC.100\Qt\StudyManager cmake X:/CMakeBased/Qt/StudyManager popd rem build the nsis

Re: [CMake] Code and API review request for Qt5 CMake files

2012-02-24 Thread Michael Hertling
On 02/24/2012 03:34 PM, Stephen Kelly wrote: Just forwarding to the cmake users list. Stephen Kelly wrote: Hi there, Qt5 generates its own CMake files, which you will be able to use to find Qt5 and build with it. That is, you will port from, eg find_package(Qt4 REQUIRED Core

Re: [CMake] add_executable and extension of source file

2012-02-24 Thread Michael Hertling
On 02/24/2012 06:16 PM, Kris Thielemans wrote: Hi I have a project where I have C++ and C source files. I'm adding executables for this (via macros) like this foreach(executable ${SOURCES}) add_executable(${executable} ${executable} ) target_link_libraries(${executable}

Re: [CMake] apply for maintainer of FindOpenCL.cmake

2012-02-24 Thread yao wang
Hi, My script now only include AMD's OpenCL finding, and it works for both Windows and Linux. Stefan's script has one step ahead, which enable both AMD and Nvidia's OpenCL finding. And Daniel's script has one more step, which enable AMD, Nvidia and Intel's OpenCL finding. If this script can work

[CMake] How to recursively copy directories and subdirectories...

2012-02-24 Thread Sumit Kumar
Hello I would like to recursively copy folders/subfolders when I do a make install. In addition, I would like to copy certain file patterns (typically *.h) files that may be in these folders. I can do this for individual files (by doing a  glob / glob recurse). However, in doing this I lose

Re: [CMake] How to recursively copy directories and subdirectories...

2012-02-24 Thread Michael Hertling
On 02/25/2012 03:16 AM, Sumit Kumar wrote: Hello I would like to recursively copy folders/subfolders when I do a make install. In addition, I would like to copy certain file patterns (typically *.h) files that may be in these folders. I can do this for individual files (by doing a glob

[Cmake-commits] CMake branch, next, updated. v2.8.7-2850-g1427ddc

2012-02-24 Thread Clinton Stimpson
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 1427ddc20da9c47a85a639e004581fe85ccd183d (commit) via

[Cmake-commits] CMake branch, next, updated. v2.8.7-2852-gc1870a2

2012-02-24 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via c1870a21f6f955311580ff37542dd625f5d3171e (commit) via

[Cmake-commits] CMake branch, next, updated. v2.8.7-2856-g625c64a

2012-02-24 Thread Rolf Eike Beer
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 625c64a5f1243b9a8d1d6b5f55cadca81fb11715 (commit) via

[Cmake-commits] CMake branch, next, updated. v2.8.7-2858-g1e5cac6

2012-02-24 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 1e5cac640dcc7afbf73a749fcaea4b134a865045 (commit) via

[Cmake-commits] CMake branch, next, updated. v2.8.7-2860-gf0728dd

2012-02-24 Thread Rolf Eike Beer
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via f0728dd9e2b1fc85a653c124c7245881d79f865f (commit) via

[Cmake-commits] CMake branch, next, updated. v2.8.7-2864-g5dce3dd

2012-02-24 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 5dce3dd5de0f9bba8d946496747da4637214a203 (commit) via