Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case

2014-09-09 Thread Bach, Pascal
On 09/08/2014 05:35 AM, Pascal Bach wrote: Even better would be to make the search case insensitive. How do we know which flags are sensitive to case? It has nothing to do with Visual Studio as it doesn't care about the casing. The problem is in the CMake generator. The tables in (eg.

Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case

2014-09-09 Thread Brad King
On 09/09/2014 05:31 AM, Bach, Pascal wrote: Maybe a better solution would be to do this matching in a case insensitive way, this way it would work in any case even with user passed flags in lower case. I'm saying that some flags are case sensitive and others are not. We cannot blindly match

Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case

2014-09-09 Thread Bach, Pascal
Maybe a better solution would be to do this matching in a case insensitive way, this way it would work in any case even with user passed flags in lower case. I'm saying that some flags are case sensitive and others are not. We cannot blindly match all cl flags insensitive to case, for

Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case

2014-09-09 Thread Brad King
On 09/09/2014 09:48 AM, Bach, Pascal wrote: The values added to _PLATFORM_LINK_FLAGS do never end up in the .vcxproj file. The go into CMAKE_${lang}_CREATE_SHARED_LIBRARY [1] and CMAKE_${lang}_LINK_EXECUTABLE [2] However I can't see how this variables should end up in the VS generator. Any

Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case

2014-09-09 Thread Bach, Pascal
Those are all for the Makefile and Ninja generators, as are CMAKE_CREATE_WIN32_EXE and CMAKE_CREATE_CONSOLE_EXE. For VS generators the knowledge has always been hard-coded, with a special case for Windows CE: http://www.cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmLocalVisual

Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case

2014-09-09 Thread Brad King
On 09/09/2014 10:19 AM, Bach, Pascal wrote: Wouldn't it make sense to use the same variables in the VS10+ Generator too? It seems redundant to have the same information again. What's the reason it is hardcoded? That's just the way it was written. The rule variables like

Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case

2014-09-09 Thread Bach, Pascal
On 09/09/2014 10:19 AM, Bach, Pascal wrote: Wouldn't it make sense to use the same variables in the VS10+ Generator too? It seems redundant to have the same information again. What's the reason it is hardcoded? That's just the way it was written. The rule variables like

Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case

2014-09-09 Thread Brad King
On 09/09/2014 11:02 AM, Bach, Pascal wrote: I don't understand the purpose of the flag tables [1]. Aren't they there to map from command line to XML files? Yes, but they were created originally to support flags specified by users in CMAKE_C_FLAGS and a few other places. At first I tought the

[cmake-developers] [PATCH] FindIce: Remove unneeded search path modification

2014-09-09 Thread Roger Leigh
Hi, I have attached a minor fix to the FindIce module added a couple of weeks back. This can override the user's intended search path and was made unnecessary by the changes you requested prior to merging (the paths being added are already added as fallbacks via the list(APPEND ice_roots

Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case

2014-09-09 Thread Bach, Pascal
At first I tought the way things work was: Windows-MSVC.cmake and Co construct a commandline with the required flags. The VS generator parses this command line and uses the cmVS7FlagTable to translate the known flags to XML elements. (Unknown arguments get passed as additional

[cmake-developers] [CMake 0015144]: CMake is unable to locate FreeType within the XQuartz installation

2014-09-09 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15144 == Reported By:Sergey Kosarevsky Assigned To:

[cmake-developers] include(...) or find_package(...) within another Findpackage module

2014-09-09 Thread Richard Shaw
I'm working on trying to modernize the FindFLTK module but also stuck with making sure I don't break the established behavior. The problems with the module are extensive so I'm breaking them up into individual emails where possible. The part I'm questioning in this email is: Should this be

Re: [cmake-developers] [PATCH] FindIce: Remove unneeded search path modification

2014-09-09 Thread Roger Leigh
On Tue, Sep 09, 2014 at 11:48:53AM -0400, Brad King wrote: On 09/09/2014 11:35 AM, Roger Leigh wrote: I have attached a minor fix to the FindIce module added a couple of weeks back. Applied, thanks: FindIce: Remove unneeded search path modification

Re: [cmake-developers] [PATCH] FindIce: Remove unneeded search path modification

2014-09-09 Thread Brad King
On 09/09/2014 02:56 PM, Roger Leigh wrote: I have attached a patch to do this. Thanks, applied: FindIce: Respect Ice_FIND_QUIETLY when printing messages http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2131aedd -Brad -- Powered by www.kitware.com Please keep messages on-topic and check

Re: [cmake-developers] include(...) or find_package(...) within another Findpackage module

2014-09-09 Thread Brad King
On 09/09/2014 02:21 PM, Richard Shaw wrote: Should this be include(FindX11) as it shows or find_package(X11)? if(UNIX) include(FindX11) find_library(FLTK_MATH_LIBRARY m) set(FLTK_PLATFORM_DEPENDENT_LIBS ${X11_LIBRARIES} ${FLTK_MATH_LIBRARY}) endif() It should be find_package(X11).

[cmake-developers] Gold standard find module?

2014-09-09 Thread Richard Shaw
Everyone has been really helpful but I don't want to be a pest. Is there a specific find package module that one could point to that would be consider the gold standard of getting it right? One with sufficient complexity (not like the wiki example). Thanks, Richard -- Powered by

[cmake-developers] Modern cross-platform buildsystem design requirements

2014-09-09 Thread Stephen Kelly
Hi, I saw the addition of the VS_WINRT_COMPONENT property. This seems to be an attribute to mark an executable specially so that it is built with appropriate flags for the WinRT platform. This reminds me of this thread: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/9728

[CMake] Corrupted CmakeLists.txt File how to heal it ?

2014-09-09 Thread Sonya Blade
Dear All, I find ti very difficult to configure the project which has the following CMakeLists.txt at the attachement.The CMakeLists is automatically created with FireBreath Python script (fbgen.py) and is supposed to run on Win32/64 compiled with MSVS10~13 and MinGW compilers. After

[CMake] INCLUDE() guards

2014-09-09 Thread Nico Schlömer
Hi all, I have a project with multiple interdependent subpackages here, each of which has its own export config file. The dependency hierarchy is reflected in the `INCLUDE()` statements in the export files. I would like to avoid that an export config file is included more than once, so I'm

Re: [CMake] Corrupted CmakeLists.txt File how to heal it ?

2014-09-09 Thread Nils Gladitz
On 09/09/2014 01:34 PM, Sonya Blade wrote: I Use Cmake-GUI 2.8.12.2 to configure the CMakeLists.txt file but no matter which compiler I set ( I prefer Code::Blocks MinGW Makefile) Cmake-GUI produces the Error in configurition process, project files may be invalid dialog, with following report,

Re: [CMake] Corrupted CmakeLists.txt File how to heal it ?

2014-09-09 Thread Sonya Blade
Hi Nils,You guess is correct it is not top level CMakeLists.txt, but actually originator instruct to do soand even instruct to add the additional lines to sub-level CMakeLists.txt. Probably I misinterpreted it,and probably this is what he meant:Add the additional lines to the sub level

Re: [CMake] Request for added script intelligence

2014-09-09 Thread David Cole via CMake
Let's see if anybody else chimes in with an opinion. I've already given mine, and I don't think there's a good argument for making installing the debug runtime libraries any easier than it already is. You can certainly write a wrapper script around the existing CMake

Re: [CMake] Corrupted CmakeLists.txt File how to heal it ?

2014-09-09 Thread Nils Gladitz
On 09/09/2014 02:05 PM, Sonya Blade wrote: Hi Nils, You guess is correct it is not top level CMakeLists.txt, but actually originator instruct to do so and even instruct to add the additional lines to sub-level CMakeLists.txt. Probably I misinterpreted it, and probably this is what he meant: Add

[CMake] ITK compiling problem with CMake

2014-09-09 Thread Vincent L.Zhang
Hi, I'm learning ITK for some image registration project. But just at the first step, I met a problem compiling it with CMake. The CMakeError log as following: *Compiling the C compiler identification source file CMakeCCompilerId.c failed.* *Compiler: * *Build flags: * *Id flags: * *The

[CMake] Dinamically generated dependencies

2014-09-09 Thread Damián Nohales
Hi, I am trying to generate file that depends on a set of files that can change throughout different make invocations. To understand it better, let's show you the code: --- cmake_minimum_required(VERSION 2.8) project(demo-one C) add_custom_command( OUTPUT

[CMake] Building library with a collection of source + pre-existing object files (which are not compiled via the cmake build system)

2014-09-09 Thread Tom Kacvinsky
Hi, I have not been able to find this in the cmake documentation. I have a collection of source that needs to be compiled via the cmake build system, plus a collection of object files that were compiled outside the cmake build system. I want to combine the two of these to make a shared library,

Re: [CMake] Building library with a collection of source + pre-existing object files (which are not compiled via the cmake build system)

2014-09-09 Thread Nils Gladitz
On 09.09.2014 17:02, Tom Kacvinsky wrote: Hi, I have not been able to find this in the cmake documentation. I have a collection of source that needs to be compiled via the cmake build system, plus a collection of object files that were compiled outside the cmake build system. I want to

Re: [CMake] Building library with a collection of source + pre-existing object files (which are not compiled via the cmake build system)

2014-09-09 Thread Tom Kacvinsky
Thank you, Nils. Tom On Tue, Sep 9, 2014 at 11:25 AM, Nils Gladitz nilsglad...@gmail.com wrote: On 09.09.2014 17:02, Tom Kacvinsky wrote: Hi, I have not been able to find this in the cmake documentation. I have a collection of source that needs to be compiled via the cmake build system,

[Cmake-commits] CMake branch, master, updated. v3.0.1-1836-g7b2e3cc

2014-09-09 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via 7b2e3cc63b6dc38a458524a4edcdd43fe967098b (commit) via

[Cmake-commits] CMake branch, next, updated. v3.0.1-5251-g86bf8af

2014-09-09 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 86bf8afb4c085aef5e67bf8f37be89632aa2f5c2 (commit) via

[Cmake-commits] CMake branch, next, updated. v3.0.1-5257-gdf87e21

2014-09-09 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via df87e21c08e3845db5783d17b1a27a3e170738cd (commit) via

[Cmake-commits] CMake branch, next, updated. v3.0.1-5259-gb44bf88

2014-09-09 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via b44bf8890f8128b26184cfdf5de58aae13c8157b (commit) via

[Cmake-commits] CMake branch, next, updated. v3.0.1-5261-g621bd88

2014-09-09 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 621bd8816e011ac621d8db317b391be0e25d3045 (commit) via

[Cmake-commits] CMake branch, next, updated. v3.0.1-5263-g5c6635d

2014-09-09 Thread Brad King
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 5c6635d90de331677ae75f436d82239e1496998b (commit) via

[Cmake-commits] CMake branch, master, updated. v3.0.1-1839-ge03b474

2014-09-09 Thread Kitware Robot
20140909) +set(CMake_VERSION_PATCH 20140910) #set(CMake_VERSION_RC 1) --- Summary of changes: Source/CMakeVersion.cmake |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- CMake