>From (at least) CMake 2.8.9 to CMake 3.4, this CMakeLists.txt
---
cmake_minimum_required(VERSION 2.8.9)
project(bar)
include(CMakeParseArguments)
macro(foo)
set(_options )
set(_oneValueArgs FOO)
set(_multiValueArgs )
cmake_parse_arguments(_FOO1 "${_options}"
ow.
- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4668f9ed6842fee90007c6134710c0c2d9aa787d
commit 4668f9ed6842fee90007c6134710c0c2d9aa787d
Merge: 7b24b3b 5f933bd
Author: Daniele E. Domenichelli <daniele.domeniche...@gmail.com>
AuthorDate: Tue Nov 3 05:04:13 2
On 02/11/2015 20:53, Brad King wrote:
> LGTM. Please merge to 'next' for testing.
Done. Thanks.
Daniele
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake
Dear all,
Please review the topic FindGTK2_GTK2_TARGETS:
Previously, when GTK2_USE_IMPORTED_TARGETS was enabled, the
GTK2_LIBRARIES variable was still filled with the paths to the
libraries, and only the GTK2_XXX_LIBRARY variables contained the
imported targets.
This patch changes the behaviour
Hello Brad,
On 12/10/2015 17:00, Brad King wrote:
>> I understand this is a quite controversial module, but I would like to
>> stress that this is something that can already be done using CMake just
>> by executing file(DOWNLOAD) and include(), this module just makes it
>> easy to do it. Whether
https://cmake.org/cmake/help/v2.8.9/cmake.html
[3]https://cmake.org/cmake/help/v3.0/index.html
[4]https://cmake.org/cmake/help/git-master/release/index.html
[5]http://public.kitware.com/Bug/changelog_page.php?project_id=2
#=========
# Copyrig
ow.
- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6d0145dbeace6b7be1073796cf95154764378114
commit 6d0145dbeace6b7be1073796cf95154764378114
Merge: 5f678ee 8036c7f
Author: Daniele E. Domenichelli <daniele.domeniche...@gmail.com>
AuthorDate: Thu Oct 8 10:20:28 2
Hello Brad,
thanks for your comments.
On 08/10/2015 17:48, Brad King wrote:
> I wish you had come asking about this proposal to hold discussion
> before going through all the work to implement this.
We've been successfully using this module for about 2 years now and we
will continue to use it
ow.
- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9990befcd93999ac476dd78ef4c74514da0673d2
commit 9990befcd93999ac476dd78ef4c74514da0673d2
Merge: 16df189 33eb8fa
Author: Daniele E. Domenichelli <daniele.domeniche...@gmail.com>
AuthorDate: Wed Oct 7 03:25:09 2
On 06/10/2015 19:25, Brad King wrote:
> On 10/06/2015 12:20 PM, Daniele E. Domenichelli wrote:
>> I updated the topic according to your comments. The new commit is this:
>>
>> FindGTK2: Enable c++11 for sigc++ 2.5.1 or later
>> https://cmake.org/gitweb?p=stage/cmake
Hello all,
Please review the "IncludeUrl" topic[1] that adds a new "IncludeUrl"
module. This module adds the include_url command that is useful to
download and include other CMake modules from a given url.
[1]https://cmake.org/gitweb?p=stage/cmake.git;a=shortlog;h=refs/heads/IncludeUrl
The
Hello,
Starting with some recent update on my system that updated sigc++ from
2.4.0 to 2.6.1, I noticed that a few GTK2Targets tests depending on
sigc++ are failing.
According to the sigc++ changelog, starting with version 2.5.1, sigc++
requires c++11 enabled, hence this patch.
FindGTK2:
e: 6968cb0 7c5b6ed
Author: Daniele E. Domenichelli <daniele.domeniche...@gmail.com>
AuthorDate: Thu Sep 17 08:39:30 2015 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Thu Sep 17 08:39:30 2015 -0400
Merge topic 'ExternalProject_stash_save_all' into
-
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4bb795b709ebbd2b53d841bb810f4d1a7e6505aa
commit 4bb795b709ebbd2b53d841bb810f4d1a7e6505aa
Merge: e932b35 d4c6531
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Fri May 29 14:04:05 2015 -0400
Commit
On 22/12/14 19:38, Rolf Eike Beer wrote:
About the FindPkgConfig macros documentation, what is that is not clear?
It's not about the documentation of that module, but where I need to hack it
into the module. The code is quite a bit of indirections, I guess I would
need
to do this
Is there a way to separate components for a library with a SONAME and
the link?
For example if I do something like this:
add_library(foo ${foo_SRCS})
set_target_properties(foo PROPERTIES SOVERSION 1)
install(TARGETS foo
LIBRARY DESTINATION lib)
This will install
Hello all,
Please review the topic install_CMAKE_INSTALL_RELATIVE.
install: Add CMAKE_INSTALL_RELATIVE variable
http://www.cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=3b57fa0
This patch adds a a variable CMAKE_INSTALL_RELATIVE to install files in
CMAKE_INSTALL_PREFIX using relative path,
Hello Eike,
On 22/12/14 16:39, Rolf Eike Beer wrote:
What I would like to get is the following: when a list of libraries and
directories is returned by PkgConfig then for every of these libraries the
absolute path to the library is determined using find_library() using the
given
-
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=15162ca3106d95b0f867b9a89d9b3a6dd0008297
commit 15162ca3106d95b0f867b9a89d9b3a6dd0008297
Merge: bf87bec 6401639
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Mon Dec 22 11:25:59 2014 -0500
Commit
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=677d66d06472560a5c9dedfec73e093ee40db2c6
commit 677d66d06472560a5c9dedfec73e093ee40db2c6
Merge: 6fe2845 636f0c1
Author: Daniele E. Domenichelli daniele.domeniche
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=72edefcf8a04d5ee9404cccd33090dd0d2025005
commit 72edefcf8a04d5ee9404cccd33090dd0d2025005
Merge: b7f1ba1 0bdf245
Author: Daniele E. Domenichelli daniele.domeniche
On 01/12/14 16:03, Brad King wrote:
LGTM. Please also add a
Help/release/dev/ExternalProject_TEST_EXCLUDE_FROM_MAIN.rst
file with a release note advertising the feature.
Done... squashed everything in one commit:
* ExternalProject: Add TEST_EXCLUDE_FROM_MAIN option
On 10/11/14 15:18, Brad King wrote:
However, the test does not fail for me even without the fix. I
think for 3.1.0-rc2 I will take this fix but not the test yet.
Please extend the topic to revise the test:
The test fails for me on a ubuntu precise chroot using gcc 4.6.3 (I
wasn't able to
On 10/11/14 16:49, Brad King wrote:
Thanks. Please rename the 'foo' and 'bar' libs to 'case5Foo' and
'case5Bar' to avoid conflict with other cases in the future.
Done:
Rename the 'foo' and 'bar' libs to 'case5Foo' and 'case5Bar'
Hello,
Please review topic fix_link-line-dedup_regression:
Fix regression in link order introduced by the link-line-dedup topic
Some compilers will fail linking if an executable is linking to a
library that is not used and a static library that uses the shared one.
This patch reverse the
562a7b835a21cc395c76fde720f94d0547a6
Merge: ebac33c aba5cec
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Thu Nov 6 09:13:58 2014 -0500
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Thu Nov 6 09:13:58 2014 -0500
Merge topic
Hello,
Sorry for resuming an old thread, you can read the original thread here:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8680/
This topic was reviewed and merged into next, but there were some issues
in the unit tests with Ninja and with parallel builds.
I finally
On 03/11/14 16:02, Brad King wrote:
My only nitpick is that the work was spread out over so long
that the author dates are a little confusing. Please reset
them and then merge to 'next'.
Done. Thanks!
Daniele
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake
67cfbf8
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Mon Nov 3 10:17:33 2014 -0500
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Mon Nov 3 10:17:33 2014 -0500
Merge topic 'ExternalProject_independent-step-targets' into next
67cfbf8e
Hello Brad,
On 29/10/14 14:38, Brad King wrote:
In the updated docs for CMAKE_ARGS, CMAKE_CACHE_ARGS, and
CMAKE_CACHE_DEFAULT_ARGS, the intro line now needs a period.
The new RunCMake.ExternalProject test looks good. However, it
does not verify that the external project actually builds
0d58a36ede819753219c5f417db001182ade3ff9
Merge: 2d1d312 fdbfbaa
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Thu Oct 30 13:46:53 2014 -0400
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Thu Oct 30 13:46:53 2014 -0400
Merge topic
Hello Brad,
Sorry for the delay.
On 22/10/14 17:18, Brad King wrote:
How about a new option like CMAKE_CACHE_DEFAULT_ARGS for that?
I just pushed a new ExternalProject_CMAKE_CACHE_DEFAULT_ARGS topic, can
you please review it?
Cheers,
Daniele
--
Powered by www.kitware.com
Please keep
On 28/10/14 18:01, Brad King wrote:
Please rebase on those. You should find it much easier to add
more detail to the documentation of each option.
Done, thanks.
Daniele
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
On 20/10/14 15:52, Brad King wrote:
On 10/16/2014 11:26 AM, Daniele E. Domenichelli wrote:
#[CMAKE_ARGS args...]# Arguments to CMake command line
#[CMAKE_CACHE_ARGS args...] # Initial cache arguments, of the form
-Dvar:string=on
So, from what I understand, The first
Hello all,
I have question about CMAKE_ARGS and CMAKE_CACHE_ARGS, and I'm not sure
if this is the intended behaviour or not...
From the documentation:
#[CMAKE_ARGS args...]# Arguments to CMake command line
#[CMAKE_CACHE_ARGS args...] # Initial cache arguments, of the form
On 15/09/14 12:01, Daniele E. Domenichelli wrote:
Is there an alternative variable for CMAKE_CFG_INTDIR that can be used
in configure time, instead of build time?
If there is not, is it safe to assume that the name of the directory is
equal to the name of the current configuration?
Bump
Hello,
Is there an alternative variable for CMAKE_CFG_INTDIR that can be used
in configure time, instead of build time?
If there is not, is it safe to assume that the name of the directory is
equal to the name of the current configuration?
Cheers,
Daniele
--
Powered by www.kitware.com
On 04/08/14 20:35, Brad King wrote:
Please also add a check that the value given to the INSTALL_PREFIX
option passes if(IS_ABSOLUTE). It does not make sense to have a
relative value here.
Done and merged to next.
Thanks,
Daniele
--
Powered by www.kitware.com
Please keep messages
Hello Brad,
On 30/07/14 15:32, Brad King wrote:
Thanks. While reviewing the commits in 'next' again I realized
that assuming paths are relative to CMAKE_BINARY_DIR may not be
correct. Some projects may be nested inside others, and the
CMAKE_BINARY_DIR may not be the proper location for a
Hello Brad,
On 30/07/14 15:32, Brad King wrote:
Thanks. While reviewing the commits in 'next' again I realized
that assuming paths are relative to CMAKE_BINARY_DIR may not be
correct. Some projects may be nested inside others, and the
CMAKE_BINARY_DIR may not be the proper location for a
On 28/07/14 16:11, Brad King wrote:
On 07/25/2014 10:00 AM, Daniele E. Domenichelli wrote:
Sorry if I insist, but I still don't understand why not allowing to be
able to use CMakePackageConfigHelpers for the build tree
I didn't mean to imply that the patch is not acceptable. After
309d1a645e358d0b88414d6b95e0d13185d8c1f6
Merge: dea3d88 8bab445
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Mon Jul 28 11:06:30 2014 -0400
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Mon Jul 28 11:06:30 2014 -0400
Merge topic
[Changing subject in order to keep the conversation separate]
On 23/07/14 20:39, Brad King wrote:
Since you were asking if CMake misses some important feature, I believe
that a very useful feature to have would be to be able to have an option
for the install(FILES/PROGRAMS/DIRECTORY) command
On 23/07/14 20:39, Brad King wrote:
Returning to CMakePackageConfigHelpers, I work on several projects
that provide one pkgConfig.cmake file in the build tree and one
in the install tree. They are generated by hand. I do not use
CMakePackageConfigHelpers. IMO it is good for getting projects
On 21/07/14 21:04, Stephen Kelly wrote:
Can you give a more-concrete example of what the problem is?
The project is supposed to work both from build tree (using
export(TARGETS)) and from the install tree (using install(EXPORT)).
Your example is too abstract. What is the meaning of the
On 22/07/14 10:53, Stephen Kelly wrote:
Daniele E. Domenichelli wrote:
The first case is a folder that is appended to CMAKE_MODULE_PATH, and
that containing CMake files that can optionally be included by projects
using this package.
I still find this an odd user interface.
You provide
On 22/07/14 13:44, Stephen Kelly wrote:
Does this mean that if I set the PACKAGE_DIR environment variable to
the CMAKE_BINARY_DIR of my package, CMake will look into these folders
as well?
No, I don't think so. You would have to set it to the exact dir afaik.
Actually I tested it, and CMake
On 17/07/14 16:33, Brad King wrote:
+# .. command:: configure_package_config_file
+#
+# Create a config file for a project::
The definition of the command should be in an indented block so
that reST knows it is part of the explicit markup block.
I indented the whole command block, can you
On 21/07/14 14:23, Stephen Kelly wrote:
Can you give a more-concrete example of what the problem is?
I have a project that is similar to this small example:
--- CMakeLists.txt
cmake_minimum_required(VERSION 2.8.12)
project(FOO NONE)
set(FOO_VERSION 0.0.1)
On 21/07/14 16:17, Brad King wrote:
On 07/21/2014 04:54 AM, Daniele E. Domenichelli wrote:
I indented the whole command block, can you please have a look if that's
what you meant? Or is it just the brief description of the command
that should be indented?
I think just the signature summary
Hello all,
Please review the topic CMakePackageConfigHelpers_build_tree.
This patch adds an option BUILD_TREE to configure_package_config_file.
At the moment it is complicated to generate config files both for
install and build tree, usually combined with export(TARGETS) and
install(EXPORT),
Hello all,
Can anyone with OSX and Xcode check if this commit is correct?
http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=e475c067
I have no way to test it, but by looking at the code, it looks to me
that the name should be Xcode instead of XCode...
Thanks,
Daniele
--
Powered by
On 15/07/14 15:07, Brad King wrote:
Yes, please merge for testing in 'next'.
Done, Thanks.
Cheers,
Daniele
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f49799e996088f1bab6828be8df5ad818f45762e
commit f49799e996088f1bab6828be8df5ad818f45762e
Merge: 2fbe31f e475c06
Author: Daniele E. Domenichelli daniele.domeniche
for testing this.
What is your opinion? How should I use it? Should I just use the long
version?
Cheers,
Daniele
[1]http://sphinx-doc.org/latest/ext/intersphinx.html
[2]http://cmake.org/cmake/help/v3.0/
From 2f06136d7b18f14899b8bb7238837d877f1e2328 Mon Sep 17 00:00:00 2001
From: Daniele E
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d9a618b3535c7ab0bed98c4e788ec47334877c83
commit d9a618b3535c7ab0bed98c4e788ec47334877c83
Merge: d409750 1890c66
Author: Daniele E. Domenichelli daniele.domeniche
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6f370917e704c8aa61be4a88d3cad0eb93ca47fe
commit 6f370917e704c8aa61be4a88d3cad0eb93ca47fe
Merge: dbf3f61 548ba5a
Author: Daniele E. Domenichelli daniele.domeniche
-
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=273265f59786680ce6075114709c127cc9025d61
commit 273265f59786680ce6075114709c127cc9025d61
Merge: 7f7983f 6673145
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Wed May 7 09:18:54 2014 -0400
Commit
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e9f70ab1dd5f7b6454a9c769a2f238581db47951
commit e9f70ab1dd5f7b6454a9c769a2f238581db47951
Merge: da090ee 93730bb
Author: Daniele E. Domenichelli daniele.domeniche
Hello all,
Please review the topic ExternalProject_labels.
---
ExternalProject: Set LABELS property to targets
his is useful for using CDash subprojects.
http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=8810ddb3b710abf222f23ae96ac025beae63d812
---
ExternalProject: Set FOLDER
-
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2991b499abe95138980effdef884452b6c702999
commit 2991b499abe95138980effdef884452b6c702999
Merge: a0a5c4f ef9366b
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Tue Apr 15 10:27:05 2014 -0400
Commit
-
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1057ecb6efe46cac903e36a1113657c8c0507e00
commit 1057ecb6efe46cac903e36a1113657c8c0507e00
Merge: dee43a8 13552d4
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Tue Apr 15 11:16:15 2014 -0400
Commit
-
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7d40eac6a04576da54ac1e33fddae83aaa06007d
commit 7d40eac6a04576da54ac1e33fddae83aaa06007d
Merge: caba6c6 2dad1c1
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Sun Apr 6 19:19:03 2014 -0400
Commit
Hello all,
Please review the topic ExternalProject_VCS-quiet.
http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=2dad1c143cfee60eadcf1bee5faa47efed89a31a
ExternalProject: Find VCS packages quietly
This keeps the VCS packages out from FeatureSummary output, unless the
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a7052bc37ab6215e8be30074424027d087c1b07c
commit a7052bc37ab6215e8be30074424027d087c1b07c
Merge: c66e4b9 841f432
Author: Daniele E. Domenichelli daniele.domeniche
On 27/03/14 16:34, Brad King wrote:
Yes, but let's do only one change to ExternalProject per day so
we can see how the tests do.
Thanks for merging the other patch.
I just rebased and merged this one to next now.
Daniele
--
Powered by www.kitware.com
Please keep messages on-topic and
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f83a50e31dd56adf22d749edc5580df060afdf90
commit f83a50e31dd56adf22d749edc5580df060afdf90
Merge: b69bd9e 1ddcc58
Author: Daniele E. Domenichelli daniele.domeniche
Hello all,
Sorry for bringing up an old thread, you can find the original thread
here:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8658
I pushed the topic again with no changes (just a rebase), I've been
using it for a while with no issues at all.
Is it ok to merge it to
Hello again,
Sorry for bringing up another old thread, you can find the original
thread here:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8837
I pushed the topic again with no changes (just a rebase), I've been
using it for a while with no issues at all.
Is it ok to merge
On 27/03/14 16:53, Brad King wrote:
Actually you don't need to parse the arg ahead of time.
The ALL option to add_custom_target just tells it to
*not* set the EXCLUDE_FROM_ALL target property. Instead
you can leave out ALL, parse the args as normal, and
then add
set_property(TARGET ...
On 27/03/14 18:50, Brad King wrote:
On 03/27/2014 12:24 PM, Daniele E. Domenichelli wrote:
+ if(;${ARGN}; MATCHES ;EXCLUDE_FROM_ALL;([^;]*);)
+set(exclude_from_all ${CMAKE_MATCH_1})
+ endif()
+ if(NOT exclude_from_all)
+set(all ALL)
+ endif()
Sorry, I made 2 force-pushes (after
On 27/03/14 19:45, Brad King wrote:
On 03/27/2014 02:35 PM, Brad King wrote:
Please take a look at the failure on the continuous test submissions.
fatal: Couldn't find remote ref origin/master
fatal: The remote end hung up unexpectedly
Is there a particular version requirement on Git?
I
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cbd2444b399f30af625b57ca3c1b1a26ac5ec020
commit cbd2444b399f30af625b57ca3c1b1a26ac5ec020
Merge: f376a82 64d78bd
Author: Daniele E. Domenichelli daniele.domeniche
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4c0b1e3de0974769e7a90ae2bb8f66e9802af8d1
commit 4c0b1e3de0974769e7a90ae2bb8f66e9802af8d1
Merge: 2d1fa0b 40bf640
Author: Daniele E. Domenichelli daniele.domeniche
2cc64ce
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Thu Mar 27 18:39:26 2014 -0400
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Thu Mar 27 18:39:26 2014 -0400
Merge topic 'ExternalProject_GitUpdate' into next
2cc64ce6 ExternalProject
On 16/03/14 23:49, Christoph Grüninger wrote:
I'd like to add additional paths for pkg_check_modules similar to
find_program:
[PATHS path1 [path2 ... ENV var]]
Daniele would you mind to add such a feature? Or are there any
objections if I do it myself?
No objections if you want to add it
-
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8fb0e3092c8d84748a3a5414aa0a9c3915ba828a
commit 8fb0e3092c8d84748a3a5414aa0a9c3915ba828a
Merge: 71133a8 7f85777
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Mon Mar 17 12:36:47 2014 -0400
Commit
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=50444d66497cbfed37b915fbd8547b177aea9928
commit 50444d66497cbfed37b915fbd8547b177aea9928
Merge: 2e3c719 cc5a0d8
Author: Daniele E. Domenichelli daniele.domeniche
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=949ca3769c349da689f5652af81b6bbd41209a1d
commit 949ca3769c349da689f5652af81b6bbd41209a1d
Merge: 4c7860e 7d6d45f
Author: Daniele E. Domenichelli daniele.domeniche
-
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=03ce61a5017fb475019b778146c9bc9d107114a7
commit 03ce61a5017fb475019b778146c9bc9d107114a7
Merge: 3aafa45 1af77f3
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Fri Mar 14 06:52:24 2014 -0400
Commit
7ccae4d
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Fri Mar 14 07:15:13 2014 -0400
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Fri Mar 14 07:15:13 2014 -0400
Merge topic 'FindPkgConfig_Extend-PKG_CONFIG_PATH' into next
7ccae4dd
On 11/03/14 14:51, Brad King wrote:
Please add test cases for the FindPkgConfig interface and argument
parsing errors. The test can just fake the location of pkg-config
with a dummy if necessary.
I added some unit test. I'm not done yet, but I would like to see if it
works on all the
On 11/03/14 14:51, Brad King wrote:
Also the hunks:
+if(UNIX)
+ string(REPLACE \\: ; _path ${_path})
+endif()
should not be necessary because TO_CMAKE_PATH already does that.
It looks like TO_NATIVE_PATH does not do the reveres though so that
explicit
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7b5da6892d5b716c5382295d416232af3c1ba2c3
commit 7b5da6892d5b716c5382295d416232af3c1ba2c3
Merge: 45b6ef2 1c4cfca
Author: Daniele E. Domenichelli daniele.domeniche
On 06/03/14 17:25, Brad King wrote:
Am I supposed to add documentation for the variable
PKG_CONFIG_USE_CMAKE_PREFIX_PATH, that is checked by this patch?
It looks like you've updated the docs further to use the variable
directive. Good. Do you mind flipping the order of the patches
to
if (debian) add lib/arch
elseif (64 bit or unknown) add lib64
add lib
That looks good except for FIND_LIBRARY_USE_LIB64_PATHS.
Fixed. Now the logic is
if (debian) add lib/arch
elseif (FIND_LIBRARY_USE_LIB64_PATHS) add lib64
add lib
The text defining the command needs to be
Dear CMake developers,
Follow up to this thread:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8369
Please review the topic FindPkgConfig_Extend-PKG_CONFIG_PATH.
FindPkgConfig: Extend PKG_CONFIG_PATH using CMake variables
Use CMAKE_PREFIX_PATH, CMAKE_FRAMEWORK_PATH, and
, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5926b000386466034dc84430d1801c7154a8d4a2
commit 5926b000386466034dc84430d1801c7154a8d4a2
Merge: 4931e3c 8372b45
Author: Daniele E. Domenichelli daniele.domeniche
On 03/03/14 17:21, Brad King wrote:
Please add a Tests/RunCMake/FeatureSummary test to cover at least the
new error messages.
Done, added unit tests for all the WHAT argument cases.
Cheers,
Daniele
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
Dear CMake developers,
Please review the topic FeatureSummary_combine_WHAT_values.
This patch allows to combine and reorder values for the WHAT option in
FeatureSummary.
For example it is now possible to do
feature_summary(WHAT ENABLED_FEATURES
DISABLED_FEATURES)
On 15/01/14 15:29, Brad King wrote:
On 01/14/2014 11:47 AM, Daniele E. Domenichelli wrote:
Updated the topic to behave in this way. Can you please review it again?
Please update the comment introducing __LAST_LIBDIR_DEFAULT to explain
that it is the default we compute from
On 15/01/14 16:27, Brad King wrote:
On 01/15/2014 10:11 AM, Daniele E. Domenichelli wrote:
+get_property(_libdir_set CACHE PROPERTY CMAKE_INSTALL_LIBDIR SET)
That should be
get_property(_libdir_set CACHE CMAKE_INSTALL_LIBDIR PROPERTY TYPE)
Is there any issue in using
get_property
On 15/01/14 20:37, Brad King wrote:
This topic looks good to me. Please merge to 'next' for testing.
Merged.
Thanks,
Daniele
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and
-
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bb7ed99d5d14027daf888647c0456dc9d7941a7c
commit bb7ed99d5d14027daf888647c0456dc9d7941a7c
Merge: 3ecc533 620939e
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Wed Jan 15 18:50:01 2014 -0500
Commit
On 13/01/14 16:51, Brad King wrote:
On 01/13/2014 10:23 AM, Daniele E. Domenichelli wrote:
Can I store CMAKE_INSTALL_PREFIX in an internal cached variable, check
if it was changed since last run (i.e. CMAKE_INSTALL_PREFIX_OLD !=
CMAKE_INSTALL_PREFIX), check if the value is the default one
Hello,
Please review the topic GNUInstallDirs_debian-multiarch-fix
GNUInstallDirs: Fix CMAKE_INSTALL_LIBDIR on Debian
When not installing in /usr (i.e. /usr/local) on Debian/Ubuntu, the
multiarch path is not in ldconfig path, and therefore libraries cannot
be found, unless the user manually
On 10/01/14 21:19, Alexander Neundorf wrote:
Should the full version 1.2.3 be put into PROJECT_VERSION or
PROJECT_VERSION_STRING ?
Both forms are used in different places in cmake.
I usually consider PROJECT_VERSION = Major.Minor.Patch and
PROJECT_VERSION_STRING as a customizable string that
On 13/01/14 15:34, Brad King wrote:
This hunk:
-if(NOT DEFINED CMAKE_INSTALL_LIBDIR)
removes the guard that avoids doing all the default-computing
logic when there is already a value. In this hunk:
+set(CMAKE_INSTALL_LIBDIR ${_LIBDIR_DEFAULT} CACHE PATH object code
libraries
On 13/01/14 15:57, Brad King wrote:
On 01/13/2014 09:47 AM, Daniele E. Domenichelli wrote:
The problem comes when you change the CMAKE_INSTALL_PREFIX:
When you run cmake (with no -DCMAKE_INSTALL_PREFIX=... argument),
CMAKE_INSTALL_PREFIX is set to /usr/local, and the CMAKE_INSTALL_LIBDIR
-
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2fc6ed03e3a5adb756388e93ffb8b0da50f75445
commit 2fc6ed03e3a5adb756388e93ffb8b0da50f75445
Merge: 5f76ea1 37136b3
Author: Daniele E. Domenichelli daniele.domeniche...@gmail.com
AuthorDate: Thu Jan 9 10:02:04 2014 -0500
Commit
1 - 100 of 206 matches
Mail list logo
