Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-27 Thread Brad King
Tristan Carel wrote: > now the RC2 That looks good. Thanks for making the changes. Please open a feature request here: http://www.cmake.org/Bug and attach the lateset revision of the file. Send me the bug number please. Then I'll do the final testing and integration into CMake upstream. Tha

Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-26 Thread Tristan Carel
On 10/26/06, Brad King <[EMAIL PROTECTED]> wrote: Tristan Carel wrote: That looks pretty nice. Here are a few comments: 1.) Please change EXEC_PROGRAM to EXECUTE_PROCESS. Done. You can use the new OUTPUT_STRIP_TRAILING_WHITESPACE option in CVS CMake's EXECUTE_PROCESS to avoid extra newlin

Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-26 Thread Brad King
Tristan Carel wrote: > RC1 in attachment. That looks pretty nice. Here are a few comments: 1.) Please change EXEC_PROGRAM to EXECUTE_PROCESS. You can use the new OUTPUT_STRIP_TRAILING_WHITESPACE option in CVS CMake's EXECUTE_PROCESS to avoid extra newlines. Since the module will not be distrib

Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-26 Thread Tristan Carel
On 10/26/06, Brad King <[EMAIL PROTECTED]> wrote: Tristan Carel wrote: > In Modules/readme.txt, in the list of variables to provide, I can read: [...] > FindSubversion.cmake -> capitalized > vs > IF(SUBVERSION_FOUND) -> uppercased [...] For a while I was arguming that the case-ness should

Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-26 Thread Brad King
Tristan Carel wrote: > In Modules/readme.txt, in the list of variables to provide, I can read: > --- > XXX_EXECUTABLE Where to find the XXX tool. > XXX_YYY_EXECUTABLE Where to find the YYY tool that comes with XXX. > --- > > Subversion is a set o

Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-26 Thread Tristan Carel
On 10/26/06, Brad King <[EMAIL PROTECTED]> wrote: Tristan Carel wrote: > To use it: > ### Extract information from the current subversion working copy > INCLUDE(UseSubversion.cmake) > IF(SUBVERSION_SVN_FOUND) > SUBVERSION_REPOSITORY(${PROJECT_SOURCE_DIR}) > ENDIF(SUBVERSION_SVN_FOUND) This look

Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-26 Thread Brad King
Tristan Carel wrote: > To use it: > ### Extract information from the current subversion working copy > INCLUDE(UseSubversion.cmake) > IF(SUBVERSION_SVN_FOUND) > SUBVERSION_REPOSITORY(${PROJECT_SOURCE_DIR}) > ENDIF(SUBVERSION_SVN_FOUND) This looks like a nice module. You should be able to convert

[CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-26 Thread Tristan Carel
Hi CMake lovers, svn:keywords file property is a useful subversion feature because you can benefit in your source files the precious information known by subversion about your project. These information are filled and maintained automagically by subversion. (details here http://svnbook.red-bean.