Re: [CMake] CMakeDetermineVSServicePack.cmake

2011-06-09 Thread Philip Lowman
Aaron, Thanks. Please see my comments in the ticket you reopened with the patch you sent in yesterday. BTW -- If you would like to volunteer to take ownership of this module I would be happy to hand it over to someone else. Since I no longer use Visual Studio I'm probably the wrong maintainer

[CMake] CMakeDetermineVSServicePack.cmake

2011-06-07 Thread aaron . meadows
I've reopened Issue 0011279. CMakeDetermineVSServicePack.cmake has been broken again, this time by VS2010 switching to MSBuild. This has caused the version string to change. I've created a patch and uploaded it to the Issue:

Re: [CMake] CMakeDetermineVSServicePack.cmake support for vs2010

2010-10-06 Thread aaron.meadows
To: Meadows, Aaron C. Cc: cmake@cmake.org Subject: Re: [CMake] CMakeDetermineVSServicePack.cmake support for vs2010 On Thu, Sep 30, 2010 at 11:04 AM, aaron.mead...@thomsonreuters.com wrote: Done. Issue number 11279. [http://public.kitware.com/Bug/view.php?id=11279] I

Re: [CMake] CMakeDetermineVSServicePack.cmake support for vs2010

2010-10-05 Thread aaron.meadows
: [CMake] CMakeDetermineVSServicePack.cmake support for vs2010 On Thu, Sep 30, 2010 at 11:04 AM, aaron.mead...@thomsonreuters.com wrote: Done. Issue number 11279. [http://public.kitware.com/Bug/view.php?id=11279] I also noted that the script could be improved

Re: [CMake] CMakeDetermineVSServicePack.cmake support for vs2010

2010-09-30 Thread Philip Lowman
Aaron, Thanks for posting. Could you open a new bug report and attach your patch to it? On Wed, Sep 29, 2010 at 9:33 PM, aaron.mead...@thomsonreuters.com wrote: *Hi all. I noticed that CMakeDetermineVSServicePack.cmake only supports vs2005, vs2005 sp1, vs2008, vs2008 sp1. I wanted to use

Re: [CMake] CMakeDetermineVSServicePack.cmake support for vs2010

2010-09-30 Thread aaron.meadows
it quite a bit faster. Aaron C. Meadows From: philiplow...@gmail.com [mailto:philiplow...@gmail.com] On Behalf Of Philip Lowman Sent: Thursday, September 30, 2010 7:25 AM To: Meadows, Aaron C. Cc: cmake@cmake.org Subject: Re: [CMake

Re: [CMake] CMakeDetermineVSServicePack.cmake support for vs2010

2010-09-30 Thread Philip Lowman
On Thu, Sep 30, 2010 at 11:04 AM, aaron.mead...@thomsonreuters.com wrote: *Done. Issue number 11279. [ http://public.kitware.com/Bug/view.php?id=11279]* * * *I also noted that the script could be improved by calling the compiler with the ‘/?’ switch and parsing it’s output instead of