Re: [CMake] Code and API review request for Qt5 CMake files

2012-03-13 Thread Michael Hertling
On 03/10/2012 02:25 PM, Alexander Neundorf wrote: On Friday 09 March 2012, Michael Hertling wrote: On 03/05/2012 02:04 AM, Stephen Kelly wrote: ... I don't actually see the problem with checking Qt5_XYZ_FOUND. Unset variables are well defined as false in the if() command. Maybe I

Re: [CMake] Code and API review request for Qt5 CMake files

2012-03-10 Thread Alexander Neundorf
On Friday 09 March 2012, Michael Hertling wrote: On 03/05/2012 02:04 AM, Stephen Kelly wrote: ... I don't actually see the problem with checking Qt5_XYZ_FOUND. Unset variables are well defined as false in the if() command. Maybe I misunderstand you? Maybe. ;-) What ensures the variables

Re: [CMake] Code and API review request for Qt5 CMake files

2012-03-09 Thread Michael Hertling
On 03/05/2012 02:04 AM, Stephen Kelly wrote: Michael Hertling wrote: * Currently there is no Qt5Config.cmake. Such a thing could probably exist and use the FIND_COMPONENTS to find what was requested. [...] Hi there, Thank you for your insights on this issue. Do you have any other

Re: [CMake] Code and API review request for Qt5 CMake files

2012-03-06 Thread Alexander Neundorf
On Monday 05 March 2012, Stephen Kelly wrote: Rolf Eike Beer wrote: Michael Hertling wrote: My main conclusion from the above-noted mess among CMake's current component-aware find modules is that we urgently need a convention how such modules and config files are intended to work.

Re: [CMake] Code and API review request for Qt5 CMake files

2012-03-04 Thread Stephen Kelly
Michael Hertling wrote: Suppose the Qt folks decide that Qt5's core module doesn't need to be explicitly requested because it is prerequisite for everything else. Just to disseminate information here, this is already the case. You can currently do this: find_package(Qt5Declarative)

Re: [CMake] Code and API review request for Qt5 CMake files

2012-03-04 Thread Stephen Kelly
Rolf Eike Beer wrote: Michael Hertling wrote: My main conclusion from the above-noted mess among CMake's current component-aware find modules is that we urgently need a convention how such modules and config files are intended to work. Hopefully, we can take a step forward; Qt5's advent is

Re: [CMake] Code and API review request for Qt5 CMake files

2012-03-04 Thread Stephen Kelly
Michael Hertling wrote: * Currently there is no Qt5Config.cmake. Such a thing could probably exist and use the FIND_COMPONENTS to find what was requested. [...] Hi there, Thank you for your insights on this issue. Do you have any other insights into other issues I raised in the original

Re: [CMake] Code and API review request for Qt5 CMake files

2012-03-01 Thread Alexander Neundorf
On Thursday 01 March 2012, Michael Hertling wrote: On 02/28/2012 10:03 PM, Alexander Neundorf wrote: ...will reply later in detail. Could you please go through the existing find-modules shipped with cmake which support COMPONENTS and make a summary of how they handle them ? At least

Re: [CMake] Code and API review request for Qt5 CMake files

2012-03-01 Thread Michael Hertling
On 03/01/2012 10:08 PM, Alexander Neundorf wrote: On Thursday 01 March 2012, Michael Hertling wrote: On 02/28/2012 10:03 PM, Alexander Neundorf wrote: ...will reply later in detail. Could you please go through the existing find-modules shipped with cmake which support COMPONENTS and make a

Re: [CMake] Code and API review request for Qt5 CMake files

2012-02-29 Thread Michael Hertling
On 02/28/2012 10:03 PM, Alexander Neundorf wrote: ...will reply later in detail. Could you please go through the existing find-modules shipped with cmake which support COMPONENTS and make a summary of how they handle them ? At least FindQt4.cmake be default searches all components.

Re: [CMake] Code and API review request for Qt5 CMake files

2012-02-29 Thread Rolf Eike Beer
Michael Hertling wrote: My main conclusion from the above-noted mess among CMake's current component-aware find modules is that we urgently need a convention how such modules and config files are intended to work. Hopefully, we can take a step forward; Qt5's advent is a good opportunity.

Re: [CMake] Code and API review request for Qt5 CMake files

2012-02-28 Thread Alexander Neundorf
...will reply later in detail. Could you please go through the existing find-modules shipped with cmake which support COMPONENTS and make a summary of how they handle them ? At least FindQt4.cmake be default searches all components. Thanks Alex -- Powered by www.kitware.com Visit other

Re: [CMake] Code and API review request for Qt5 CMake files

2012-02-27 Thread Michael Hertling
On 02/26/2012 11:24 AM, Alexander Neundorf wrote: On Sunday 26 February 2012, Michael Hertling wrote: On 02/25/2012 09:43 AM, Alexander Neundorf wrote: On Friday 24 February 2012, Michael Hertling wrote: On 02/24/2012 03:34 PM, Stephen Kelly wrote: ... [...] (that is, find_package(Qt5

Re: [CMake] Code and API review request for Qt5 CMake files

2012-02-26 Thread Alexander Neundorf
On Sunday 26 February 2012, Michael Hertling wrote: On 02/25/2012 09:43 AM, Alexander Neundorf wrote: On Friday 24 February 2012, Michael Hertling wrote: On 02/24/2012 03:34 PM, Stephen Kelly wrote: ... [...] (that is, find_package(Qt5 REQUIRED Gui Xml) might not find QtXml, but

Re: [CMake] Code and API review request for Qt5 CMake files

2012-02-25 Thread Alexander Neundorf
On Friday 24 February 2012, Michael Hertling wrote: On 02/24/2012 03:34 PM, Stephen Kelly wrote: ... [...] (that is, find_package(Qt5 REQUIRED Gui Xml) might not find QtXml, but Qt5_FOUND would still be true if the Qt5Config file is found, whether the component is or not), [...] No:

Re: [CMake] Code and API review request for Qt5 CMake files

2012-02-25 Thread Michael Hertling
On 02/25/2012 09:43 AM, Alexander Neundorf wrote: On Friday 24 February 2012, Michael Hertling wrote: On 02/24/2012 03:34 PM, Stephen Kelly wrote: ... [...] (that is, find_package(Qt5 REQUIRED Gui Xml) might not find QtXml, but Qt5_FOUND would still be true if the Qt5Config file is found,

Re: [CMake] Code and API review request for Qt5 CMake files

2012-02-24 Thread Stephen Kelly
Just forwarding to the cmake users list. Stephen Kelly wrote: Hi there, Qt5 generates its own CMake files, which you will be able to use to find Qt5 and build with it. That is, you will port from, eg find_package(Qt4 REQUIRED Core Gui Xml) to find_package(Qt5Widgets

Re: [CMake] Code and API review request for Qt5 CMake files

2012-02-24 Thread Michael Hertling
On 02/24/2012 03:34 PM, Stephen Kelly wrote: Just forwarding to the cmake users list. Stephen Kelly wrote: Hi there, Qt5 generates its own CMake files, which you will be able to use to find Qt5 and build with it. That is, you will port from, eg find_package(Qt4 REQUIRED Core