[CMake] How to add dependencies to ExternalProject_Add()

2011-03-28 Thread Rolf Eike Beer
I have an external project that should depend on a library I build in my usual project. I do an export(TARGETS) on that library and pass that file into the build of the external project and all goes fine. But when I go to our build machine which will do make -j 5 it breaks because the external

Re: [CMake] How to add dependencies to ExternalProject_Add()

2011-03-28 Thread Rolf Eike Beer
I came up with this simple diff which makes everything work smoothly for me: This also works for me and should properly detect if the dependency is itself an external target or not: diff --git a/Modules/ExternalProject.cmake b/Modules/ExternalProject.cmake index 3de6b7e..90b23ce 100644 ---

Re: [CMake] How to add dependencies to ExternalProject_Add()

2011-03-28 Thread David Cole
On Mon, Mar 28, 2011 at 10:48 AM, Rolf Eike Beer e...@sf-mail.de wrote: I came up with this simple diff which makes everything work smoothly for me: This also works for me and should properly detect if the dependency is itself an external target or not: diff --git

Re: [CMake] How to add dependencies to ExternalProject_Add()

2011-03-28 Thread Rolf Eike Beer
On Mon, Mar 28, 2011 at 10:48 AM, Rolf Eike Beer e...@sf-mail.de wrote: I came up with this simple diff which makes everything work smoothly for me: This also works for me and should properly detect if the dependency is itself an external target or not: diff --git

Re: [CMake] How to add dependencies to ExternalProject_Add()

2011-03-28 Thread Rolf Eike Beer
I wrote: David Cole wrote: I am not sure I like this patch, or not. I'm on the fence. I would recommend just using: ExternalProject_Add(xyz ...) add_dependencies(xyz mylib) to add non-ExternalProject dependencies. Just to make it clear that the dependencies are target-level