Re: [CMake] subversion

2016-06-27 Thread Andreas Naumann
which is quite ugly. *Gesendet:* Montag, 27. Juni 2016 um 03:11 Uhr *Von:* Nagger <nag...@gmx.de> *An:* cmake@cmake.org *Betreff:* Re: [CMake] subversion Am 24.06.2016 um 19:48 schrieb Andreas Naumann: > At the moment, I check, if my directory is a working copy and if it is > not, the versio

Re: [CMake] subversion

2016-06-27 Thread Marcel Loose
ersion.cmake.. which is quite ugly. > > *Gesendet:* Montag, 27. Juni 2016 um 03:11 Uhr > *Von:* Nagger <nag...@gmx.de> > *An:* cmake@cmake.org > *Betreff:* Re: [CMake] subversion > Am 24.06.2016 um 19:48 schrieb Andreas Naumann: > > > At the momen

Re: [CMake] subversion

2016-06-27 Thread Andreas Naumann
ke.org Betreff: Re: [CMake] subversion Am 24.06.2016 um 19:48 schrieb Andreas Naumann: > At the moment, I check, if my directory is a working copy and if it is > not, the version variable is not defined. In my oppinion, it would be > better, if the macro from the subversion module woul

Re: [CMake] subversion

2016-06-26 Thread Nagger
Am 24.06.2016 um 19:48 schrieb Andreas Naumann: At the moment, I check, if my directory is a working copy and if it is not, the version variable is not defined. In my oppinion, it would be better, if the macro from the subversion module would simply define a variable "is_working_directory"

Re: [CMake] subversion

2016-06-26 Thread Marcel Loose
Hi Andreas, I think the FindSubversion module predates CMake 2.8, which introduced "message(WARNING ...)". I think a warning would be better than an error in this case; and I think the same argument holds for Subversion_WC_LOG, which also generates an error if invoked from a non-working copy.

[CMake] subversion

2016-06-24 Thread Andreas Naumann
Dear cmake users, I have a question if, and how, you use the Subversion module of cmake. The module provides the macro Subversion_WC_INFO, which extracts information of a working copy. I use this information, to generate a sub minor revision number of my project. If I checkout my project using

Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-27 Thread Brad King
Tristan Carel wrote: now the RC2 That looks good. Thanks for making the changes. Please open a feature request here: http://www.cmake.org/Bug and attach the lateset revision of the file. Send me the bug number please. Then I'll do the final testing and integration into CMake upstream.

Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-26 Thread Brad King
Tristan Carel wrote: To use it: ### Extract information from the current subversion working copy INCLUDE(UseSubversion.cmake) IF(SUBVERSION_SVN_FOUND) SUBVERSION_REPOSITORY(${PROJECT_SOURCE_DIR}) ENDIF(SUBVERSION_SVN_FOUND) This looks like a nice module. You should be able to convert it

Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-26 Thread Tristan Carel
On 10/26/06, Brad King [EMAIL PROTECTED] wrote: Tristan Carel wrote: To use it: ### Extract information from the current subversion working copy INCLUDE(UseSubversion.cmake) IF(SUBVERSION_SVN_FOUND) SUBVERSION_REPOSITORY(${PROJECT_SOURCE_DIR}) ENDIF(SUBVERSION_SVN_FOUND) This looks like

Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-26 Thread Brad King
Tristan Carel wrote: In Modules/readme.txt, in the list of variables to provide, I can read: --- XXX_EXECUTABLE Where to find the XXX tool. XXX_YYY_EXECUTABLE Where to find the YYY tool that comes with XXX. --- Subversion is a set of

Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-26 Thread Tristan Carel
On 10/26/06, Brad King [EMAIL PROTECTED] wrote: Tristan Carel wrote: In Modules/readme.txt, in the list of variables to provide, I can read: [...] FindSubversion.cmake - capitalized vs IF(SUBVERSION_FOUND) - uppercased [...] For a while I was arguming that the case-ness should always

Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-26 Thread Brad King
Tristan Carel wrote: RC1 in attachment. That looks pretty nice. Here are a few comments: 1.) Please change EXEC_PROGRAM to EXECUTE_PROCESS. You can use the new OUTPUT_STRIP_TRAILING_WHITESPACE option in CVS CMake's EXECUTE_PROCESS to avoid extra newlines. Since the module will not be

Re: [CMake] [SUBVERSION] Retrieve details of your working copy

2006-10-26 Thread Tristan Carel
On 10/26/06, Brad King [EMAIL PROTECTED] wrote: Tristan Carel wrote: That looks pretty nice. Here are a few comments: 1.) Please change EXEC_PROGRAM to EXECUTE_PROCESS. Done. You can use the new OUTPUT_STRIP_TRAILING_WHITESPACE option in CVS CMake's EXECUTE_PROCESS to avoid extra