Re: [CMake] CMake 2.8.4-rc1 ready for testing!
Not sure if this is a known bug, but installing the symlinks on OSX fails if they already exist. (..and there is no retry button :( ) /Johan On Thu, Jan 13, 2011 at 3:15 PM, David Cole david.c...@kitware.com wrote: I am happy to announce that CMake 2.8.4 has entered the release candidate stage! You can find the source and binaries here: http://www.cmake.org/files/v2.8/?C=M;O=D Following is the list of changes in this release. Please try this version of CMake on your projects and report any issues to the list or the bug tracker. Happy building! -Dave Changes in CMake 2.8.4-rc1 (since 2.8.3) Alex Neundorf (32): Add support for nasm assembler, patch by Peter Collingbourne (see #10069) Improve misleading comments. Add missing copyright headers We already have 2010, fix copyright year. Make FindBISON work properly with non-C locales (#11326) Add support for yasm, a nasm compatible assembler Use CMAKE_ASM_NASM_FLAGS for nasm instead of FLAGS Remove trailing whitespace and minor formatting changes for the dot-code Move the code for collecting targets and libraries into separate functions Properly insert all targets, also those which don't link to anything. Generate separate dot files for each target, and a big one with everything. Move the code for generating dot-files into separate class cmGraphVizWriter Fix #11421: FindQt3.cmake doesn't honor the REQUIRED keyword Remove trailing whitespace Don't enforce VERBOSE makefiles for the CodeBlocks generator Remove the early alpha stage comments about Eclipse and C::B Don't disable colors in the CodeBlocks generator and minor cleanup. Some more fixes for nasm support, from Etienne (#10069) Enable/disable generating graphs depending on the target type Use std::cout instead of fprintf Collect targets and libs on demand instead of in the ctor Exclude targets from the graphviz file based on a regex Include CMakeDetermineCompilerId in CMakeDetermineASMCompiler.cmake (#11467) Fix typos in the doc Add cache var CMAKE_ECLIPSE_MAKE_ARGUMENTS when using the Eclipse generator Add ECLIPSE_CDT4_GENERATE_SOURCE_PROJECT as a ADVANCED cache variable (#9631) Fix crash in Eclipse generator with empty project (#11616) Fix indentation in cmPolicies::ApplyPolicyVersion() Remove trailing whitespace Prefer files from CMAKE_ROOT when including from CMAKE_ROOT Improve documentation and messages for the new CMP0017 Remove usage of CMAKE_CURRENT_LIST_DIR now that we have CMP0017 Alexey Ozeritsky (5): FindBLAS works in C/C++ projects without Fortran ACML find fixes (issue 0011219) find ACML fixes fix for Fortran-only projects FindLAPACK works with C/C++ only projects (issue 0009976) Andrius Štikonas (1): Modules: Fix spelling 'becase' - 'because'. Ben Boeckel (25): Fix parsing of cache variables without a type Use cmCacheManager to load entries from the cache Support manual cache entries Condense parsing of cache entries Use FPHSA in FindOpenGL Ignore strerror_r since CMake isn't threaded Use _POLL_EMUL_H_ instead of HAVE_POLL_FINE Rename WorkingDirectory test Add WORKING_DIRECTORY argument to add_test Add tests for WORKING_DIRECTORY arg to add_test Rename the project to match the test Fix header includes for C++ and Visual Studio Add ctype.h include for toupper() Flip slashes around on Windows Use markers to denote the path Simplify the _default_cwd derivation Only test the default cwd with Makefiles Group adding tests with its properties Fully specify the path to old-signature add_test Use iostream to make Borland happy Check for poll when looking for _POLL_EMUL_H_ Toss out strerror_r macros Fix missed _POLL_EMUL_H_ and HAVE_POLL combo Make TestsWorkingDirectory test a C file Pass the expected value as the first argument Bill Hoffman (17): Fixes for the OSF operating system build. Add a fix for the inline keyword on the osf os. Add a Contract test for VTK. The test downloads and builds VTK. Fix contract test so it is not hard coded to the vtk542 test. Fix incremental linking for VS2010 with nmake or make. Change cpack run and verify script to work with multi-config generators. Fix vs2010 project generation error when HEADER_FILE_ONLY is set. Add more documentation for LANGUAGE property. Add flags to resource builds on vs 2010 with a test. Disable incremental testing for this test, it crashes vs9 linker. Only run resource test for MSVC compilers. Add support for windows resources with mingw/msys.
Re: [CMake] CMake 2.8.4-rc1 ready for testing!
On Thu, Jan 13, 2011 at 11:33 PM, Pau Garcia i Quiles
pgqui...@elpauer.org wrote:
On Thu, Jan 13, 2011 at 3:15 PM, David Cole david.c...@kitware.com wrote:
I am happy to announce that CMake 2.8.4 has entered the release
candidate stage! You can find the source and binaries here:
http://www.cmake.org/files/v2.8/?C=M;O=D
Following is the list of changes in this release. Please try this version
of CMake on your projects and report any issues to the list or the
bug tracker.
Happy building!
-Dave
A couple of issues I'd noticed:
- On Windows, FindZLIB.cmake is unable to find zlib if you built zlib
using CMake. Apparently the zlib's CMake buildsystem uses library
names different from the ones produced by other build methods.
- FindPNG.cmake does not support libpng 1.5
The attached path fixes both issues
Looks like a reasonable patch. I'll apply it later today. Thanks!
One more thing I've noticed is ExternalProject_Add does not honor the
CMAKE_BUILD_TYPE. For instance, if I have this:
It honors it if you pass it down. Same as all other CMake flags at the
top level.
--8--
project( winst )
cmake_minimum_required(VERSION 2.8)
include (ExternalProject)
set(CMAKE_PREFIX_PATH ${PROJECT_SOURCE_DIR} )
#find_package( PNG REQUIRED )
ExternalProject_Add( zlib
DOWNLOAD_DIR ${PROJECT_SOURCE_DIR}/downloads
URL http://prdownloads.sourceforge.net/libpng/zlib125.zip
PATCH_COMMAND ${CMAKE_COMMAND} -E remove zconf.h
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX:PATH=${PROJECT_SOURCE_DIR}
-DCMAKE_PREFIX_PATH:PATH=${PROJECT_SOURCE_DIR}
)
--8--
And I call CMake like cmake -DCMAKE_BUILD_TYPE=Release, it will
build zlib in Debug. It's easily fixable by adding
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} to the CMAKE_ARGS but I'd say
it violates the principle of least surprise.
But... I'm a Visual Studio / Xcode user. If CMAKE_BUILD_TYPE is
defined, it would surprise *me*. So I don't think you can say it
violates the principle universally for all types of CMake users.
We do not assume any particular set of flags or defined variables to
pass down automatically for you. Since choosing some would surprise
some people, but not others... all variable passing via
ExternalProject_Add is left up to the user.
In fact, part of the point of ExternalProject is that you can build
the thing you're building however you want *without* necessarily
inheriting the values of all the CMake variables at the top level.
Thanks for the discussion point, (and the patch!)
David
--
Pau Garcia i Quiles
http://www.elpauer.org
(Due to my workload, I may need 10 days to answer)
___
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake
Re: [CMake] CMake 2.8.4-rc1 ready for testing!
Patch applied and pushed to 'next' today:
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=30e19b79ddb00932097ec6f5b54478a0b9b33b38
Thanks again,
David
On Thu, Jan 13, 2011 at 11:33 PM, Pau Garcia i Quiles
pgqui...@elpauer.org wrote:
On Thu, Jan 13, 2011 at 3:15 PM, David Cole david.c...@kitware.com wrote:
I am happy to announce that CMake 2.8.4 has entered the release
candidate stage! You can find the source and binaries here:
http://www.cmake.org/files/v2.8/?C=M;O=D
Following is the list of changes in this release. Please try this version
of CMake on your projects and report any issues to the list or the
bug tracker.
Happy building!
-Dave
A couple of issues I'd noticed:
- On Windows, FindZLIB.cmake is unable to find zlib if you built zlib
using CMake. Apparently the zlib's CMake buildsystem uses library
names different from the ones produced by other build methods.
- FindPNG.cmake does not support libpng 1.5
The attached path fixes both issues
One more thing I've noticed is ExternalProject_Add does not honor the
CMAKE_BUILD_TYPE. For instance, if I have this:
--8--
project( winst )
cmake_minimum_required(VERSION 2.8)
include (ExternalProject)
set(CMAKE_PREFIX_PATH ${PROJECT_SOURCE_DIR} )
#find_package( PNG REQUIRED )
ExternalProject_Add( zlib
DOWNLOAD_DIR ${PROJECT_SOURCE_DIR}/downloads
URL http://prdownloads.sourceforge.net/libpng/zlib125.zip
PATCH_COMMAND ${CMAKE_COMMAND} -E remove zconf.h
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX:PATH=${PROJECT_SOURCE_DIR}
-DCMAKE_PREFIX_PATH:PATH=${PROJECT_SOURCE_DIR}
)
--8--
And I call CMake like cmake -DCMAKE_BUILD_TYPE=Release, it will
build zlib in Debug. It's easily fixable by adding
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} to the CMAKE_ARGS but I'd say
it violates the principle of least surprise.
--
Pau Garcia i Quiles
http://www.elpauer.org
(Due to my workload, I may need 10 days to answer)
___
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake
[CMake] CMake 2.8.4-rc1 ready for testing!
I am happy to announce that CMake 2.8.4 has entered the release candidate stage! You can find the source and binaries here: http://www.cmake.org/files/v2.8/?C=M;O=D Following is the list of changes in this release. Please try this version of CMake on your projects and report any issues to the list or the bug tracker. Happy building! -Dave Changes in CMake 2.8.4-rc1 (since 2.8.3) Alex Neundorf (32): Add support for nasm assembler, patch by Peter Collingbourne (see #10069) Improve misleading comments. Add missing copyright headers We already have 2010, fix copyright year. Make FindBISON work properly with non-C locales (#11326) Add support for yasm, a nasm compatible assembler Use CMAKE_ASM_NASM_FLAGS for nasm instead of FLAGS Remove trailing whitespace and minor formatting changes for the dot-code Move the code for collecting targets and libraries into separate functions Properly insert all targets, also those which don't link to anything. Generate separate dot files for each target, and a big one with everything. Move the code for generating dot-files into separate class cmGraphVizWriter Fix #11421: FindQt3.cmake doesn't honor the REQUIRED keyword Remove trailing whitespace Don't enforce VERBOSE makefiles for the CodeBlocks generator Remove the early alpha stage comments about Eclipse and C::B Don't disable colors in the CodeBlocks generator and minor cleanup. Some more fixes for nasm support, from Etienne (#10069) Enable/disable generating graphs depending on the target type Use std::cout instead of fprintf Collect targets and libs on demand instead of in the ctor Exclude targets from the graphviz file based on a regex Include CMakeDetermineCompilerId in CMakeDetermineASMCompiler.cmake (#11467) Fix typos in the doc Add cache var CMAKE_ECLIPSE_MAKE_ARGUMENTS when using the Eclipse generator Add ECLIPSE_CDT4_GENERATE_SOURCE_PROJECT as a ADVANCED cache variable (#9631) Fix crash in Eclipse generator with empty project (#11616) Fix indentation in cmPolicies::ApplyPolicyVersion() Remove trailing whitespace Prefer files from CMAKE_ROOT when including from CMAKE_ROOT Improve documentation and messages for the new CMP0017 Remove usage of CMAKE_CURRENT_LIST_DIR now that we have CMP0017 Alexey Ozeritsky (5): FindBLAS works in C/C++ projects without Fortran ACML find fixes (issue 0011219) find ACML fixes fix for Fortran-only projects FindLAPACK works with C/C++ only projects (issue 0009976) Andrius Štikonas (1): Modules: Fix spelling 'becase' - 'because'. Ben Boeckel (25): Fix parsing of cache variables without a type Use cmCacheManager to load entries from the cache Support manual cache entries Condense parsing of cache entries Use FPHSA in FindOpenGL Ignore strerror_r since CMake isn't threaded Use _POLL_EMUL_H_ instead of HAVE_POLL_FINE Rename WorkingDirectory test Add WORKING_DIRECTORY argument to add_test Add tests for WORKING_DIRECTORY arg to add_test Rename the project to match the test Fix header includes for C++ and Visual Studio Add ctype.h include for toupper() Flip slashes around on Windows Use markers to denote the path Simplify the _default_cwd derivation Only test the default cwd with Makefiles Group adding tests with its properties Fully specify the path to old-signature add_test Use iostream to make Borland happy Check for poll when looking for _POLL_EMUL_H_ Toss out strerror_r macros Fix missed _POLL_EMUL_H_ and HAVE_POLL combo Make TestsWorkingDirectory test a C file Pass the expected value as the first argument Bill Hoffman (17): Fixes for the OSF operating system build. Add a fix for the inline keyword on the osf os. Add a Contract test for VTK. The test downloads and builds VTK. Fix contract test so it is not hard coded to the vtk542 test. Fix incremental linking for VS2010 with nmake or make. Change cpack run and verify script to work with multi-config generators. Fix vs2010 project generation error when HEADER_FILE_ONLY is set. Add more documentation for LANGUAGE property. Add flags to resource builds on vs 2010 with a test. Disable incremental testing for this test, it crashes vs9 linker. Only run resource test for MSVC compilers. Add support for windows resources with mingw/msys. Add support for windres to cygwin. Add testing for windows resources for mingw/msys/cygwin and remove for watcom. Enable resource building with the intel compiler on windows. Add support for source files in custom targets for VS 10 (Bug#11330). Change the nightly tests to build from the
Re: [CMake] CMake 2.8.4-rc1 ready for testing!
Small hiccup with the Win32 .exe installer: It suggests \CMake 2.8 as the default installation directory. Do not take its advice. That is a bad idea. :-) When I fixed http://public.kitware.com/Bug/view.php?id=9148 ... I forgot that adding CPack variables frequently requires CMake's own CPack variables to be updated because of the way we build releases (not bootstrapped, but on Windows only). Rather than picking up the new default value for the new variable, new variables are simply blank because we use the previous version of CMake for the configure step, which uses its own copy of CPack.cmake for the configure step. Needless to say, I spent the day fixing this, and just pushed this commit to 'next': http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=96cd16380af5f2633cf6283481eb414c626436d3 Expect the fix for that in -rc2. If you find any *other* problems with rc1, please do reply here or add a bug to the bug tracker. We are especially looking for regressions in behavior, as we would like to maintain backwards compatibility as much as possible. Let us know if you see anything weird... Cheers, David On Thu, Jan 13, 2011 at 9:15 AM, David Cole david.c...@kitware.com wrote: I am happy to announce that CMake 2.8.4 has entered the release candidate stage! You can find the source and binaries here: http://www.cmake.org/files/v2.8/?C=M;O=D Following is the list of changes in this release. Please try this version of CMake on your projects and report any issues to the list or the bug tracker. Happy building! -Dave Changes in CMake 2.8.4-rc1 (since 2.8.3) Alex Neundorf (32): Add support for nasm assembler, patch by Peter Collingbourne (see #10069) Improve misleading comments. Add missing copyright headers We already have 2010, fix copyright year. Make FindBISON work properly with non-C locales (#11326) Add support for yasm, a nasm compatible assembler Use CMAKE_ASM_NASM_FLAGS for nasm instead of FLAGS Remove trailing whitespace and minor formatting changes for the dot-code Move the code for collecting targets and libraries into separate functions Properly insert all targets, also those which don't link to anything. Generate separate dot files for each target, and a big one with everything. Move the code for generating dot-files into separate class cmGraphVizWriter Fix #11421: FindQt3.cmake doesn't honor the REQUIRED keyword Remove trailing whitespace Don't enforce VERBOSE makefiles for the CodeBlocks generator Remove the early alpha stage comments about Eclipse and C::B Don't disable colors in the CodeBlocks generator and minor cleanup. Some more fixes for nasm support, from Etienne (#10069) Enable/disable generating graphs depending on the target type Use std::cout instead of fprintf Collect targets and libs on demand instead of in the ctor Exclude targets from the graphviz file based on a regex Include CMakeDetermineCompilerId in CMakeDetermineASMCompiler.cmake (#11467) Fix typos in the doc Add cache var CMAKE_ECLIPSE_MAKE_ARGUMENTS when using the Eclipse generator Add ECLIPSE_CDT4_GENERATE_SOURCE_PROJECT as a ADVANCED cache variable (#9631) Fix crash in Eclipse generator with empty project (#11616) Fix indentation in cmPolicies::ApplyPolicyVersion() Remove trailing whitespace Prefer files from CMAKE_ROOT when including from CMAKE_ROOT Improve documentation and messages for the new CMP0017 Remove usage of CMAKE_CURRENT_LIST_DIR now that we have CMP0017 Alexey Ozeritsky (5): FindBLAS works in C/C++ projects without Fortran ACML find fixes (issue 0011219) find ACML fixes fix for Fortran-only projects FindLAPACK works with C/C++ only projects (issue 0009976) Andrius Štikonas (1): Modules: Fix spelling 'becase' - 'because'. Ben Boeckel (25): Fix parsing of cache variables without a type Use cmCacheManager to load entries from the cache Support manual cache entries Condense parsing of cache entries Use FPHSA in FindOpenGL Ignore strerror_r since CMake isn't threaded Use _POLL_EMUL_H_ instead of HAVE_POLL_FINE Rename WorkingDirectory test Add WORKING_DIRECTORY argument to add_test Add tests for WORKING_DIRECTORY arg to add_test Rename the project to match the test Fix header includes for C++ and Visual Studio Add ctype.h include for toupper() Flip slashes around on Windows Use markers to denote the path Simplify the _default_cwd derivation Only test the default cwd with Makefiles Group adding tests with its properties Fully specify the path to old-signature add_test Use iostream to make Borland happy Check for poll when looking
