Re: [cmake-developers] Fwd: [CMake] CTest GIT support does not properly update recursive submodules

2011-02-23 Thread Johan Björk
cool, thanks. Is there a way to get the version of the Nightly builds, or is it possible to get the patch version bumped to .5? I'd like to run this on a few of my buildservers, but I can't find a way to detect if I should disable my workaround. /Johan On Tue, Feb 22, 2011 at 10:15 PM, Brad

Re: [cmake-developers] Fwd: [CMake] CTest GIT support does not properly update recursive submodules

2011-02-23 Thread Brad King
On 02/23/2011 10:22 AM, Johan Björk wrote: Is there a way to get the version of the Nightly builds, or is it possible to get the patch version bumped to .5? I'd like to run this on a few of my buildservers, but I can't find a way to detect if I should disable my workaround. The version scheme

Re: [cmake-developers] Fwd: [CMake] CTest GIT support does not properly update recursive submodules

2011-02-23 Thread Johan Björk
Thanks, updated http://www.vtk.org/Wiki/CMake_Useful_Variables to list it. /Johan On Wed, Feb 23, 2011 at 5:17 PM, Brad King brad.k...@kitware.com wrote: On 02/23/2011 10:22 AM, Johan Björk wrote: Is there a way to get the version of the Nightly builds, or is it possible to get the patch

Re: [cmake-developers] Fwd: [CMake] CTest GIT support does not properly update recursive submodules

2011-02-23 Thread Brad King
On 02/23/2011 12:16 PM, Johan Björk wrote: Thanks, updated http://www.vtk.org/Wiki/CMake_Useful_Variables to list it. FYI, these are documented: http://www.cmake.org/cmake/help/cmake-2-8-docs.html#variable:CMAKE_VERSION

Re: [cmake-developers] Fwd: [CMake] CTest GIT support does not properly update recursive submodules

2011-02-22 Thread Brad King
On 02/20/2011 11:29 AM, Johan Björk wrote: missed the list. attached patch. Thanks. I made the following commit from your patch plus some major modifications and reorganization: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1173cc4a -Brad ___

[cmake-developers] Fwd: [CMake] CTest GIT support does not properly update recursive submodules

2011-02-20 Thread Johan Björk
missed the list. attached patch. -- Forwarded message -- From: Johan Björk p...@spotify.com Date: Sun, Feb 20, 2011 at 5:28 PM Subject: Re: [CMake] CTest GIT support does not properly update recursive submodules To: Brad King brad.k...@kitware.com Hi Brad, Attached a small

Re: [cmake-developers] [CMake] CTest GIT support does not properly update recursive submodules

2011-02-18 Thread Johan Björk
Hi Brad, On Mon, Feb 7, 2011 at 7:14 PM, Brad King brad.k...@kitware.com wrote: Hi Johan, Let's move this over to the developers' list. I'm cc-ing the users' list just for this transition message. Thanks. On 02/05/2011 06:50 PM, Johan Björk wrote: The fix is extremely simple, in

Re: [cmake-developers] [CMake] CTest GIT support does not properly update recursive submodules

2011-02-18 Thread Brad King
On 02/18/2011 10:00 AM, Johan Björk wrote: On Mon, Feb 7, 2011 at 7:14 PM, Brad King wrote: (1) Hard-code --recursive and add a check to error out if the Git version is not new enough. (2) seems both complicated and confusing for end users. I would vote for (1) as if someone updates

Re: [cmake-developers] [CMake] CTest GIT support does not properly update recursive submodules

2011-02-18 Thread David Cole
On Fri, Feb 18, 2011 at 11:18 AM, Brad King brad.k...@kitware.com wrote: On 02/18/2011 10:00 AM, Johan Björk wrote: On Mon, Feb 7, 2011 at 7:14 PM, Brad King wrote:     (1) Hard-code --recursive and add a check to error out if the Git     version is not new enough. (2) seems both complicated

Re: [CMake] CTest GIT support does not properly update recursive submodules

2011-02-18 Thread Johan Björk
Hi Brad, On Mon, Feb 7, 2011 at 7:14 PM, Brad King brad.k...@kitware.com wrote: Hi Johan, Let's move this over to the developers' list. I'm cc-ing the users' list just for this transition message. Thanks. On 02/05/2011 06:50 PM, Johan Björk wrote: The fix is extremely simple, in

Re: [CMake] CTest GIT support does not properly update recursive submodules

2011-02-07 Thread Brad King
Hi Johan, Let's move this over to the developers' list. I'm cc-ing the users' list just for this transition message. Thanks. On 02/05/2011 06:50 PM, Johan Björk wrote: The fix is extremely simple, in cmCTestGIT.cxx:266 char const* git_submodule[] = {git, submodule, update, 0}; modify to

[CMake] CTest GIT support does not properly update recursive submodules

2011-02-05 Thread Johan Björk
Hi everyone, It seems the submodule support in CTest does not iterate into submodules. I'm not sure if the reason is an overlook, or that some older versions of git maybe didn't support the --recursive command. Is the proper way to add a CTEST_GIT_SUBMODULE_UPDATE_COMMAND, or is the following fix