[cmake-developers] [PATCH] Fix typo in documentation

2012-02-24 Thread Yury G. Kudryashov
From: "Yury G. Kudryashov" --- Source/cmDocumentVariables.cxx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Source/cmDocumentVariables.cxx b/Source/cmDocumentVariables.cxx index 1cab2b5..366ebaa 100644 --- a/Source/cmDocumentVariables.cxx +++ b/Source/cmDocumentVariab

Re: [cmake-developers] Coding style questions

2012-02-24 Thread Brad King
On 2/24/2012 2:32 PM, Yury G. Kudryashov wrote: 1. Some classes/methods have doxygen comments, others haven't. Will you accept patches that add such comments? Sure, as long as they are accurate :) We started that way back in the beginning but haven't really maintained it. As more contributors

Re: [cmake-developers] [PATCH] Remove unused file cmake.1

2012-02-24 Thread Brad King
On 2/24/2012 2:29 PM, Yury G. Kudryashov wrote: From: "Yury G. Kudryashov" --- cmake.1 | 112 --- 1 files changed, 0 insertions(+), 112 deletions(-) delete mode 100644 cmake.1 Wow, I totally forgot about that file and it hasn't

[cmake-developers] Coding style questions

2012-02-24 Thread Yury G. Kudryashov
Hi! I have a few questions about cmake coding style: 1. Some classes/methods have doxygen comments, others haven't. Will you accept patches that add such comments? 2. The same about 'const' qualifiers on methods. 3. When do you use std::string vs char *? 3a. What is the difference between std

[cmake-developers] [PATCH] Remove unused file cmake.1

2012-02-24 Thread Yury G. Kudryashov
From: "Yury G. Kudryashov" --- cmake.1 | 112 --- 1 files changed, 0 insertions(+), 112 deletions(-) delete mode 100644 cmake.1 diff --git a/cmake.1 b/cmake.1 deleted file mode 100644 index c7695b4..000 --- a/cmake.1 +++ /dev/nul

Re: [cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Clinton Stimpson
On Feb 24, 2012, at 12:00 PM, Brad King wrote: > On 2/24/2012 1:56 PM, Clinton Stimpson wrote: >> What about a more generic approach like the following? >> >> add_library(foo IMPORTED ...) >> set_target_properties(foo PROPERTIES >> DEPENDENT_COMPILE_DEFINITIONS "FOO_DEFINE" >> DEPEND

Re: [cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Brad King
On 2/24/2012 1:56 PM, Clinton Stimpson wrote: What about a more generic approach like the following? add_library(foo IMPORTED ...) set_target_properties(foo PROPERTIES DEPENDENT_COMPILE_DEFINITIONS "FOO_DEFINE" DEPENDENT_INCLUDE_DIRECTORIES "/path/to/foo/include") add_executable(b

Re: [cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Clinton Stimpson
On Friday, February 24, 2012 03:31:35 am Stephen Kelly wrote: > Hi there, > > When building Qt5 projects with CMake, you will use something like this: > find_package(Qt5Widgets REQUIRED) > find_package(Qt5Xml REQUIRED) > > The result is that several variables are populated with information needed

Re: [cmake-developers] compiler version variables

2012-02-24 Thread Brad King
On 2/24/2012 1:15 PM, Rolf Eike Beer wrote: Brad King wrote: FYI, this variable is not set by all generators yet. It is computed as Ok, but they should work for GCC and Intel, no? And this stuff as part of CMake qualifies as internal use? So I have nothing to change? Sure it is internal use

Re: [cmake-developers] compiler version variables

2012-02-24 Thread Rolf Eike Beer
Brad King wrote: > On 2/24/2012 11:50 AM, Rolf Eike Beer wrote: > > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c28e2769482c12da53a3c01 > > ea45f9ae6cdc1de34 commit c28e2769482c12da53a3c01ea45f9ae6cdc1de34 > > Author: Rolf Eike Beer > > AuthorDate: Fri Feb 24 17:48:02 2012 +0100 > > Comm

[cmake-developers] compiler version variables

2012-02-24 Thread Brad King
On 2/24/2012 11:50 AM, Rolf Eike Beer wrote: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c28e2769482c12da53a3c01ea45f9ae6cdc1de34 commit c28e2769482c12da53a3c01ea45f9ae6cdc1de34 Author: Rolf Eike Beer AuthorDate: Fri Feb 24 17:48:02 2012 +0100 Commit: Rolf Eike Beer CommitDate: Fri

Re: [cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Brad King
On 2/24/2012 12:19 PM, Alexander Neundorf wrote: On Friday 24 February 2012, Brad King wrote: and INCLUDE_DIRECTORIES. This will require C++ implementation but will be much more powerful than the proposed macro. Just the simple target_link_libraries(A B) command would be enough to propag

Re: [cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Alexander Neundorf
On Friday 24 February 2012, Stephen Kelly wrote: > Hi there, > > When building Qt5 projects with CMake, you will use something like this: > find_package(Qt5Widgets REQUIRED) > find_package(Qt5Xml REQUIRED) > > The result is that several variables are populated with information needed > to build y

Re: [cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Alexander Neundorf
On Friday 24 February 2012, Brad King wrote: > On 2/24/2012 5:31 AM, Stephen Kelly wrote: > > When building with Qt5, we want to change the convention away from USE > > files, and towards a concept of using packages whose variables have > > conventional names, mostly those conventions in the Module

Re: [cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Brad King
On 2/24/2012 5:31 AM, Stephen Kelly wrote: When building with Qt5, we want to change the convention away from USE files, and towards a concept of using packages whose variables have conventional names, mostly those conventions in the Modules/readme.txt, so that after find_package(Foo), Foo_INCLUD

Re: [cmake-developers] [PATCH] CMakeFindPackageMode.cmake: fix 32/64bit detection if `file' is a symlink

2012-02-24 Thread Brad King
On 2/23/2012 4:39 PM, Yury G. Kudryashov wrote: From: "Yury G. Kudryashov" Applied, thanks: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=19ab5819 -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Pleas

[cmake-developers] Code and API review request for Qt5 CMake files

2012-02-24 Thread Stephen Kelly
Hi there, Qt5 generates its own CMake files, which you will be able to use to find Qt5 and build with it. That is, you will port from, eg find_package(Qt4 REQUIRED Core Gui Xml) to find_package(Qt5Widgets REQUIRED) find_package(Qt5Xml REQUIRED) find_package(Qt5Core) is also possible but is

[cmake-developers] Convention driven CMAKE_USE_PACKAGE macro

2012-02-24 Thread Stephen Kelly
Hi there, When building Qt5 projects with CMake, you will use something like this: find_package(Qt5Widgets REQUIRED) find_package(Qt5Xml REQUIRED) The result is that several variables are populated with information needed to build your project with Qt5, such as in this case * ${Qt5Widgets_INCL