On 2/27/2012 3:17 PM, Alexander Neundorf wrote:
Anything left I should do before merging into next ?
The documentation of find_package() may need some modifications, I thought you
may want to have a look at that ?
I reverted FindPackage_ImprovedErrorMessages from next and
replaced it with
I understand the get_filename_component call here, but it does not
really need to use CACHE does it?
On Fri, Feb 24, 2012 at 10:37 AM, Brad King brad.k...@kitware.com wrote:
On 2/23/2012 4:39 PM, Yury G. Kudryashov wrote:
From: Yury G. Kudryashovurkud.ur...@gmail.com
Applied, thanks:
The nightly binary for CMake is not building because of a test failure:
http://open.cdash.org/testDetails.php?test=136868750build=2046004
CMake Error at CMakeLists.txt:52 (message):
Subversion_VERSION_SVN has unexpected content
Call Stack (most recent call first):
CMakeLists.txt:74
David Cole wrote:
What's the motivation here?
The motivation was to remove a class that has no useful methods. The only
useful method was AppendProperty, and it can be easily implemented in
cmPropertyMap.
This will likely conflict (logically, at compile time) with the
recently
2012/2/28 Bill Hoffman bill.hoff...@kitware.com:
The nightly binary for CMake is not building because of a test failure:
http://open.cdash.org/testDetails.php?test=136868750build=2046004
CMake Error at CMakeLists.txt:52 (message):
Subversion_VERSION_SVN has unexpected content
Call Stack
On 2/28/2012 1:14 PM, Eric Noulard wrote:
2012/2/28 Bill Hoffmanbill.hoff...@kitware.com:
The nightly binary for CMake is not building because of a test failure:
http://open.cdash.org/testDetails.php?test=136868750build=2046004
CMake Error at CMakeLists.txt:52 (message):
On Tue, Feb 28, 2012 at 1:25 PM, Bill Hoffman bill.hoff...@kitware.com wrote:
On 2/28/2012 1:14 PM, Eric Noulard wrote:
2012/2/28 Bill Hoffmanbill.hoff...@kitware.com:
The nightly binary for CMake is not building because of a test failure:
On Monday 27 February 2012, Brad King wrote:
On 2/27/2012 3:37 PM, Michael Wild wrote:
On 02/27/2012 09:15 PM, Alexander Neundorf wrote:
When the FooConfig.cmake has been found, Foo_FOUND is set to TRUE:
// Set a variable marking whether the package was found.
std::string
On 2/28/2012 1:38 PM, David Cole wrote:
Wait for Eike to reply here. He's been requiring version variables to
be set if the package is found in this test. I'm sure he'll either
patch this up so it works or exclude svn from the version variable
test depending on how hard it is to detect this
On 2/28/2012 1:53 PM, Bill Hoffman wrote:
No matter what
find_package(foo)
Can not cause an error at CMake time.
That isn't the line causing the error. It's the AllFindModules test
that wants to know that the returned version information is as expected.
This is a real test failure because
On 2/28/2012 1:48 PM, Alexander Neundorf wrote:
Do you think that needs a policy ?
I'm not sure. It's pretty obscure.
The code currently does:
// Set a variable marking whether the package was found.
std::string foundVar = this-Name;
foundVar += _FOUND;
On 2/28/2012 1:57 PM, Brad King wrote:
On 2/28/2012 1:53 PM, Bill Hoffman wrote:
No matter what
find_package(foo)
Can not cause an error at CMake time.
That isn't the line causing the error. It's the AllFindModules test
that wants to know that the returned version information is as
On 2/28/2012 2:09 PM, Bill Hoffman wrote:
On 2/28/2012 1:57 PM, Brad King wrote:
On 2/28/2012 1:53 PM, Bill Hoffman wrote:
That isn't the line causing the error. It's the AllFindModules test
that wants to know that the returned version information is as expected.
This is a real test failure
On 2/28/2012 8:24 AM, Brad King wrote:
I replaced the FindPackage_ModeWarning topic on the stage with a
[snip]
However, I'm not yet prepared to merge this to next. I'm going
to make more significant edits to the proposed changes and post
them as a separate topic and then report back here.
I
Hi!
I've published two branches on gitorious.
First, I run spellcheck on some source files.
git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git ready/fix-typos
Next, I fixed some doxygen formatting.
git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git ready/apidocs-
fixes
The last
On 2/28/2012 2:46 PM, Yury G. Kudryashov wrote:
I've published two branches on gitorious.
Thanks for your work!
First, I run spellcheck on some source files.
git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git ready/fix-typos
Please combine those commits and write a single commit
On Tuesday 28 February 2012, Brad King wrote:
On 2/28/2012 8:24 AM, Brad King wrote:
I replaced the FindPackage_ModeWarning topic on the stage with a
[snip]
However, I'm not yet prepared to merge this to next. I'm going
to make more significant edits to the proposed changes and post
Am Dienstag, 28. Februar 2012, 14:20:27 schrieb Brad King:
On 2/28/2012 2:09 PM, Bill Hoffman wrote:
On 2/28/2012 1:57 PM, Brad King wrote:
On 2/28/2012 1:53 PM, Bill Hoffman wrote:
That isn't the line causing the error. It's the AllFindModules test
that wants to know that the returned
Brad King wrote:
On 2/28/2012 2:46 PM, Yury G. Kudryashov wrote:
git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git
ready/fix-typos
Please combine those commits and write a single commit message
that briefly explains the tools you ran to find the errors.
I've also renamed branch.
Brad King wrote:
On 2/25/2012 3:19 AM, Yury G. Kudryashov wrote:
Yury G. Kudryashov wrote:
From: Yury G. Kudryashov
urkud.ur...@gmail.com
Mailman says that the next patch is too big. The compressed version is
attached.
While building I get:
This branch compiles with -Werror here:
git
On 2/28/2012 4:02 PM, Yury G. Kudryashov wrote:
git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git run-vim-spellcheck
git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git doxygen-fixes
Thanks. I'll look at those topics when I get a chance.
We accept any form of patch that
On Tue, Feb 28, 2012 at 4:07 PM, Yury G. Kudryashov
urkud.ur...@gmail.com wrote:
This branch compiles with -Werror here:
git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git add-const-
qualifiers
I still get warnings like:
Source/cmCommand.h:99:16: warning: ‘virtual bool
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=13003
==
Reported By:Dave Whipp
Assigned To:
23 matches
Mail list logo
