Putting quotes in and then taking them out. Where do the quotes come
from? Is there another way to put paths with spaces into ninja?
Yes sounds strange, but atm I've no better idea, ninja adds the quotes
because it internally has a space separated list, see the link in my
comment in merge
One of my last changes was to replaces back slashes with slashes
exactly because of \../../ problems. Have you used cl and
recent next?
With cl and recent next:
* Our host tools (the host-tools folder) basically get rebuilt everytime
you run ninja, and -d explain suggests x86 is dirty and
On 11.06.2012 13:23, Amine Khaldi wrote:
Another thing I noticed while testing ReactOS is that we end up with
entries like e:\reactos\ntoskrnl\include/../mm/ARM3/miarm.h (for
example) in the .d files, and this triggers recompiles. If this /../
construct is eliminated (not that it's practically
On 12.06.2012 13:47, Amine Khaldi wrote:
One of my last changes was to replaces back slashes with slashes
exactly because of \../../ problems. Have you used cl and
recent next?
With cl and recent next:
* Our host tools (the host-tools folder) basically get rebuilt everytime
you run ninja, and
The gcc build issues are all fixed. Thanks !
The cl scenario for host-tools remains, I'm still getting entries like
C:/Program\ Files\ (x86)/Windows\
Kits/8.0/include/shared/ConcurrencySal.h and C:/Program\ Files\
(x86)/Windows\ Kits/8.0/include/shared/sal.h
Thank you for looking into the
On 12.06.2012 14:58, Amine Khaldi wrote:
The gcc build issues are all fixed. Thanks !
The cl scenario for host-tools remains, I'm still getting entries like
C:/Program\ Files\ (x86)/Windows\
Kits/8.0/include/shared/ConcurrencySal.h and C:/Program\ Files\
(x86)/Windows\
Have you also rebuild cmcldeps?
That was it. My VS generated solution didn't have cmcldeps listed among
the modules, so I only rebuilt cmake. I confirm it works.
Excellent work Peter, thanks.
Regards,
Amine.
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
On 6/12/2012 5:27 AM, Peter Kümmel wrote:
Yes sounds strange, but atm I've no better idea, ninja adds the quotes
because it internally has a space separated list, see the link in my
comment in merge request:
https://github.com/martine/ninja/pull/324
This is the reason for the patch:
On 12.06.2012 15:37, Bill Hoffman wrote:
On 6/12/2012 5:27 AM, Peter Kümmel wrote:
Yes sounds strange, but atm I've no better idea, ninja adds the quotes
because it internally has a space separated list, see the link in my
comment in merge request:
https://github.com/martine/ninja/pull/324
On 6/12/2012 11:21 AM, Peter Kümmel wrote:
When you debug it, you will see that it is not that simple.
When the path is read you don't know what is done with it later on.
Where is it read? Seems like at that point it does not matter where it
is used later one. Once you read it in, it
On 12.06.2012 17:43, Bill Hoffman wrote:
On 6/12/2012 11:21 AM, Peter Kümmel wrote:
When you debug it, you will see that it is not that simple.
When the path is read you don't know what is done with it later on.
Where is it read? Seems like at that point it does not matter where it
is used
On 6/12/2012 11:21 AM, Peter Kümmel wrote:
When you debug it, you will see that it is not that simple.
When the path is read you don't know what is done with it later on.
And feeding fopen with is wrong anyway.
BTW, you can create files with in the name on Windows, just not from
explorer:
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=13294
==
Reported By:Matthias Kretz
Assigned To:
On 12.06.2012 18:07, Bill Hoffman wrote:
On 6/12/2012 11:21 AM, Peter Kümmel wrote:
When you debug it, you will see that it is not that simple.
When the path is read you don't know what is done with it later on.
And feeding fopen with is wrong anyway.
BTW, you can create files with in the
On 6/12/2012 1:22 PM, Peter Kümmel wrote:
Maybe you should use \ \ as build folder ;)
I agree, it is crazy Well, lets hope you can get them to accept your
changes upstream. One thing that might help is if you created a case
that failed on linux with spaces in the path. They seem to care
One more thing... Why is the MFC test failing now?
-Bill
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this
On 12.06.2012 19:27, Bill Hoffman wrote:
On 6/12/2012 1:22 PM, Peter Kümmel wrote:
Maybe you should use \ \ as build folder ;)
I agree, it is crazy Well, lets hope you can get them to accept your
changes upstream.
I found a much simpler patch:
On 6/12/2012 1:44 PM, Peter Kümmel wrote:
I found a much simpler patch:
https://github.com/syntheticpp/ninja/commit/0ea34053a4692f190b8c13ce0ff032a57cece047
Could you please have a look at it before I create a merge request?
I would change RemoveQuotes to only remove them if they are at
On 12.06.2012 19:59, Bill Hoffman wrote:
On 6/12/2012 1:44 PM, Peter Kümmel wrote:
I found a much simpler patch:
https://github.com/syntheticpp/ninja/commit/0ea34053a4692f190b8c13ce0ff032a57cece047
Could you please have a look at it before I create a merge request?
I would change
On 6/12/2012 2:30 PM, Peter Kümmel wrote:
OK, but we need to handle strings like this:
... \outlib.dir\outlib.c.obj.d
Peter
OK, so where does the .d get added? That seems like the problem. It
should not be adding a .d to the end of a quoted string.
--
Bill Hoffman
Kitware, Inc.
28
On 12.06.2012 20:54, Bill Hoffman wrote:
On 6/12/2012 2:30 PM, Peter Kümmel wrote:
OK, but we need to handle strings like this:
... \outlib.dir\outlib.c.obj.d
Peter
OK, so where does the .d get added? That seems like the problem. It
should not be adding a .d to the end of a quoted
On 12.06.2012 21:10, Peter Kümmel wrote:
On 12.06.2012 20:54, Bill Hoffman wrote:
On 6/12/2012 2:30 PM, Peter Kümmel wrote:
OK, but we need to handle strings like this:
... \outlib.dir\outlib.c.obj.d
Peter
OK, so where does the .d get added? That seems like the problem. It
should not be
On 6/12/2012 3:10 PM, Peter Kümmel wrote:
-- depfile = $out.d = c:\my
build\Utilities\KWIML\test\CMakeFiles\cmIML_test.dir\test.c.obj.d
Maybe this should be mentioned on the ninja mailing list. If this were
CMake, I would say that the should be stripped when $out is being
expanded. It
On 12.06.2012 21:17, Bill Hoffman wrote:
On 6/12/2012 3:10 PM, Peter Kümmel wrote:
-- depfile = $out.d = c:\my
build\Utilities\KWIML\test\CMakeFiles\cmIML_test.dir\test.c.obj.d
Maybe this should be mentioned on the ninja mailing list. If this were
CMake, I would say that the should be
On 6/12/2012 3:15 PM, Peter Kümmel wrote:
First its evaluates the variable out
https://github.com/syntheticpp/ninja/blob/master/src/eval_env.cc#L36
- c:\my build\Utilities\KWIML\test\CMakeFiles\cmIML_test.dir\test.c.obj
So, if this removed the quotes would it work:
On 06/08/2012 12:59 PM, Stephen Kelly wrote:
Fixed now (I hope), thanks,
This change is now in master in preparation for 2.8.9.
Thanks for your work and persistence on this!
FYI, I rewrote the topic history prior to merging to clean up
all the cruft from dashboard fixes and the change in
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=13295
==
Reported By:Sune Vuorela
Assigned To:
On Mon, Jun 11, 2012 at 6:53 PM, Peter Kümmel syntheti...@gmx.net wrote:
On 11.06.2012 18:02, David Cole wrote:
In 'next' we are seeing dashboard test failures (and I am seeing it on my
local build too, of course) that are related
to recent edits in Source/cmNinjaTargetGenerator.**cxx.
On 12.06.2012 21:30, Bill Hoffman wrote:
On 6/12/2012 3:15 PM, Peter Kümmel wrote:
First its evaluates the variable out
https://github.com/syntheticpp/ninja/blob/master/src/eval_env.cc#L36
- c:\my build\Utilities\KWIML\test\CMakeFiles\cmIML_test.dir\test.c.obj
So, if this removed the
On 12.06.2012 19:28, Bill Hoffman wrote:
One more thing... Why is the MFC test failing now?
Was a bug. rc files were compiled with cl.
-Bill
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages
On 13.06.2012 01:04, David Cole wrote:
If we want to increase the line length limitation, then we should discuss it
and come to a reasonable consensus.
We have reasons for wanting to keep the line length short, and we realize it's
not always comfortable. But it really
helps out viewing diffs
31 matches
Mail list logo
