Re: [cmake-developers] Ninja: don't pollute the rules file with useless comments

2012-06-13 Thread Brad King
On 06/10/2012 02:23 PM, Peter Kuemmel wrote: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ba8d0db217399dede6d897c928b4dbf52e7e141b commit ba8d0db217399dede6d897c928b4dbf52e7e141b Author: Peter Kuemmel syntheti...@gmx.net AuthorDate: Sun Jun 10 20:20:29 2012 +0200 Commit: Peter

Re: [cmake-developers] -GNinja on Windows

2012-06-13 Thread Bill Hoffman
On 6/12/2012 7:08 PM, Peter Kümmel wrote: So we don't need any ninja patches, neither for msvc nor for mingw. All tests pass with ninja master. WOW! Congrats, this is awesome. The windows ninja dashboard is totally green today. Thanks for all the hard work, this is really great stuff.

Re: [cmake-developers] -GNinja on Windows

2012-06-13 Thread Bill Hoffman
On 6/13/2012 9:31 AM, Amine Khaldi wrote: Please don't consider Windows as done until proper dependency tracking is in place (it's lacking so far for rc files). OK, so we need a test for rc file depend tracking. I did not realize that was still missing. We have it for c/c++ now. I am

Re: [cmake-developers] -GNinja on Windows

2012-06-13 Thread Peter Kümmel
On 13.06.2012 15:16, Bill Hoffman wrote: On 6/12/2012 7:08 PM, Peter Kümmel wrote: So we don't need any ninja patches, neither for msvc nor for mingw. All tests pass with ninja master. WOW! Congrats, this is awesome. The windows ninja dashboard is totally green today. Thanks for all the

Re: [cmake-developers] Visual Studio Add Custom Target marked Build

2012-06-13 Thread David Cole
You can get install_foo to build always if you include ALL as an arg to add_custom_target. You cannot use INSTALL in an add_dependencies call, though. Rather, you could list the executables that you need built *before* an install could be successful -- that should be equivalent, but requires you

Re: [cmake-developers] -GNinja on Windows

2012-06-13 Thread Peter Collingbourne
On Wed, Jun 13, 2012 at 05:34:14PM +0200, Peter Kümmel wrote: On 13.06.2012 15:31, Amine Khaldi wrote: Please don't consider Windows as done until proper dependency tracking is in place (it's lacking so far for rc files). Please test stage. I've added rc file dependency tracking. It's a

Re: [cmake-developers] Visual Studio Add Custom Target marked Build

2012-06-13 Thread J Decker
On Wed, Jun 13, 2012 at 9:09 AM, David Cole david.c...@kitware.com wrote: You can get install_foo to build always if you include ALL as an arg to add_custom_target. You cannot use INSTALL in an add_dependencies call, though. Rather, you could list the executables that you need built *before*

Re: [cmake-developers] -GNinja on Windows

2012-06-13 Thread Peter Kümmel
On 13.06.2012 18:09, Peter Collingbourne wrote: On Wed, Jun 13, 2012 at 05:34:14PM +0200, Peter Kümmel wrote: On 13.06.2012 15:31, Amine Khaldi wrote: Please don't consider Windows as done until proper dependency tracking is in place (it's lacking so far for rc files). Please test stage.

Re: [cmake-developers] Adding logic to CMake for -fPIE and -fPIC

2012-06-13 Thread Stephen Kelly
Brad King wrote: On 06/08/2012 12:59 PM, Stephen Kelly wrote: Fixed now (I hope), thanks, This change is now in master in preparation for 2.8.9. Thanks for your work and persistence on this! FYI, I rewrote the topic history prior to merging to clean up all the cruft from dashboard fixes

Re: [cmake-developers] -GNinja on Windows

2012-06-13 Thread Bill Hoffman
On 6/13/2012 12:41 PM, Peter Kümmel wrote: Yes, this looks like a more advanced solution. We only need to extract #line 1234 c:\... from the generated file. Peter -- Just do this: cl /P /showIncludes Then it won't error out, and will show the includes in the same format. -Bill --

Re: [cmake-developers] -GNinja on Windows

2012-06-13 Thread Peter Kümmel
On 13.06.2012 18:53, Bill Hoffman wrote: On 6/13/2012 12:41 PM, Peter Kümmel wrote: Yes, this looks like a more advanced solution. We only need to extract #line 1234 c:\... from the generated file. Peter -- Just do this: cl /P /showIncludes Then it won't error out, and will show the

Re: [cmake-developers] Visual Studio Add Custom Target marked Build

2012-06-13 Thread J Decker
Oh, I can have it build INSTALL.vcxproj instead of my_project.sln with target INSTALL. On Wed, Jun 13, 2012 at 9:17 AM, J Decker d3c...@gmail.com wrote: On Wed, Jun 13, 2012 at 9:09 AM, David Cole david.c...@kitware.com wrote: You can get install_foo to build always if you include ALL as an arg

Re: [cmake-developers] -GNinja on Windows

2012-06-13 Thread David Cole
On Wed, Jun 13, 2012 at 1:20 PM, Peter Kümmel syntheti...@gmx.net wrote: On 13.06.2012 18:53, Bill Hoffman wrote: On 6/13/2012 12:41 PM, Peter Kümmel wrote: Yes, this looks like a more advanced solution. We only need to extract #line 1234 c:\... from the generated file. Peter -- Just

[cmake-developers] [CMake 0013302]: Improve mechanism allowing to pass command line parameter to ctest script

2012-06-13 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=13302 == Reported By:Jean-Christophe Fillion-Robin