The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=13379
==
Reported By:Yngve Inntjore Levinsen
Assigned
Hi,
I finally found the time to fix the Ninja generator on OS X. Mainly I
have fixed ExportImport and Qt4Deploy. I based my work on jkp's work
(https://github.com/jkp/CMake/commits/jkp/ninja-generator). Although
there are other patches in this branch, I just included commits fixing
tests. We
I forgot to say that most of the code is duplicated from the Makefile
generator. I have left some todo but this code will need to be
factored sooner or later.
On Fri, Jul 6, 2012 at 12:54 PM, Nicolas Desprès
nicolas.desp...@gmail.com wrote:
Hi,
I finally found the time to fix the Ninja
We should re-factor it sooner (not later).
This is great, thank you very much!
But we should definitely re-factor it before merging it to 'master'
Thx,
David
On Fri, Jul 6, 2012 at 7:05 AM, Nicolas Desprès
nicolas.desp...@gmail.com wrote:
I forgot to say that most of the code is duplicated
On 06.07.2012 12:54, Nicolas Desprès wrote:
Hi,
I finally found the time to fix the Ninja generator on OS X. Mainly I
have fixed ExportImport and Qt4Deploy. I based my work on jkp's work
(https://github.com/jkp/CMake/commits/jkp/ninja-generator). Although
there are other patches in this branch,
I agree. Any idea how you would like to re-factor it? I am thinking
about using multiple inheritance by introducing a cmOSXBundleGenerator
class with CreateFramework and CreateAppBundle. WDYT?
Cheers,
Nico
On Fri, Jul 6, 2012 at 1:13 PM, David Cole david.c...@kitware.com wrote:
We should
On Fri, Jul 6, 2012 at 1:29 PM, Peter Kümmel syntheti...@gmx.net wrote:
On 06.07.2012 12:54, Nicolas Desprès wrote:
Hi,
I finally found the time to fix the Ninja generator on OS X. Mainly I
have fixed ExportImport and Qt4Deploy. I based my work on jkp's work
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=13380
==
Reported By:Jay Sistar
Assigned To:
On 7/6/2012 7:33 AM, Nicolas Desprès wrote:
I agree. Any idea how you would like to re-factor it? I am thinking
about using multiple inheritance by introducing a cmOSXBundleGenerator
class with CreateFramework and CreateAppBundle. WDYT?
Cheers,
Nico
Thanks, this is great.
I am not a big fan
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=13381
==
Reported By:Nicholas Katzakis
Assigned To:
On Fri, Jul 6, 2012 at 3:52 PM, Bill Hoffman bill.hoff...@kitware.com wrote:
On 7/6/2012 7:33 AM, Nicolas Desprès wrote:
I agree. Any idea how you would like to re-factor it? I am thinking
about using multiple inheritance by introducing a cmOSXBundleGenerator
class with CreateFramework and
On 7/6/2012 12:45 PM, Nicolas Desprès wrote:
Both work. Generally I use helper class with language not supporting
multiple inheritance but if you prefer not to use it that's not a
problem. I'll do the patch. Thanks for answering.
Great, thanks for doing the work. Lets go with the helper class,
12 matches
Mail list logo
