[cmake-developers] FindPkgConfig, find_program and stuff

2012-08-19 Thread Rolf Eike Beer
I scanned through the patches Gentoo applies to CMake to find out which ones should be dropped in 2.8.9. I found this one: diff --git a/Modules/FindPkgConfig.cmake b/Modules/FindPkgConfig.cmake index c47f583..5783d37 100644 --- a/Modules/FindPkgConfig.cmake +++ b/Modules/FindPkgConfig.cmake @@

[cmake-developers] foreach(IN LISTS) or not

2012-08-19 Thread Rolf Eike Beer
I'm wondering if it makes sense to do a mass replace of foreach(listvar ${somevar}) to foreach(listvar IN LISTS somevar) From what I see this should be more efficient as the variable is not first expanded and then parsed again, it could save from potential trouble if e.g. somevar includes

Re: [cmake-developers] FindPkgConfig, find_program and stuff

2012-08-19 Thread Alexander Neundorf
On Sunday 19 August 2012, Rolf Eike Beer wrote: I scanned through the patches Gentoo applies to CMake to find out which ones should be dropped in 2.8.9. I found this one: diff --git a/Modules/FindPkgConfig.cmake b/Modules/FindPkgConfig.cmake index c47f583..5783d37 100644 ---

Re: [cmake-developers] FindPkgConfig, find_program and stuff

2012-08-19 Thread Rolf Eike Beer
Am Sonntag, 19. August 2012, 20:26:35 schrieb Alexander Neundorf: On Sunday 19 August 2012, Rolf Eike Beer wrote: I scanned through the patches Gentoo applies to CMake to find out which ones should be dropped in 2.8.9. I found this one: diff --git a/Modules/FindPkgConfig.cmake

Re: [cmake-developers] Unique compile definitions

2012-08-19 Thread Stephen Kelly
Brad King wrote: On 8/16/2012 11:42 AM, Stephen Kelly wrote: I thought that I could make -DNAME=value appear twice with this code: add_definitions(-DNAME=Value -DNAME=Value) CMake syntax treats quotes in the middle of an unquoted argument literally. The double quotes are part of the

Re: [cmake-developers] Unique compile definitions

2012-08-19 Thread David Cole
On Sun, Aug 19, 2012 at 4:17 PM, Stephen Kelly steve...@gmail.com wrote: Brad King wrote: On 8/16/2012 11:42 AM, Stephen Kelly wrote: I thought that I could make -DNAME=value appear twice with this code: add_definitions(-DNAME=Value -DNAME=Value) CMake syntax treats quotes in the

Re: [cmake-developers] Module.GenerateExportHeader crash

2012-08-19 Thread Stephen Kelly
Brad King wrote: On 08/14/2012 07:04 AM, Stephen Kelly wrote: Why do you think that's not the correct fix? Is there really no C compiler available? Do you have a backtrace? If you comment out the run_tests(C) in the GenerateExportHeader unit test, does the problem go away? As a side

Re: [cmake-developers] Unique compile definitions

2012-08-19 Thread Stephen Kelly
David Cole wrote: I could run an Experimental based on this branch with Visual Studio and point you to the CDash results if you'd like. Maybe not till tomorrow, though. That works for me, thanks :) -- Powered by www.kitware.com Visit other Kitware open-source projects at