Re: [cmake-developers] FindPkgConfig_Extend-PKG_CONFIG_PATH

2014-03-17 Thread Brad King
On 03/16/2014 06:49 PM, Christoph Grüninger wrote: Maybe you missed it, your patch fixes backlogged #12926. Great! Thanks for pointing that out. We'll update the issue. I'd like to add additional paths for pkg_check_modules similar to find_program: [PATHS path1 [path2 ... ENV var]]

Re: [cmake-developers] Android platform file

2014-03-17 Thread Brad King
On 03/04/2014 01:23 PM, Stephen Kelly wrote: Linux-{GNU,Clang}.cmake and dependents only exist for historical reasons apparently. More precisely: These files are the modern way of specifying information specific to this combination of target platform and toolchain. However, no such

Re: [cmake-developers] [PATCH] add one blank line to output Wmake makefile for better readability

2014-03-17 Thread Brad King
On 03/16/2014 07:40 AM, Jiri Malak wrote: I enclosed patch for cosmetic change of output Wmake makefiles. Applied, thanks: Watcom: Add one blank line to Makefile for better readability http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=fbc883c9 -Brad -- Powered by www.kitware.com Please

Re: [cmake-developers] [PATCH] Enable Wmake generator on Linux host

2014-03-17 Thread Brad King
On 03/16/2014 07:43 AM, Jiri Malak wrote: I enclosed patch, which enable generation of wmake makefiles on Linux host. The CMake condition if(WIN32 OR UNIX AND NOT APPLE) and the preprocessor condition #if defined(_WIN32) || defined(__linux__) are not fully equivalent. Instead you could

Re: [cmake-developers] [PATCH] Correct platform related variables for Open Watcom compilers

2014-03-17 Thread Brad King
On 03/14/2014 02:27 PM, Jiri Malak wrote: I enclosed both patches. Thanks. Here are some more comments. The version extraction logic is currently: + /* __WATCOMC__ = VVRR + 1100 Open Watcom */ +# define COMPILER_VERSION_MAJOR DEC((__WATCOMC__ - 1100 ) / 100) +# define

Re: [cmake-developers] [PATCH] Correct platform related variables for Open Watcom compilers

2014-03-17 Thread Brad King
On 03/14/2014 02:27 PM, Jiri Malak wrote: I enclosed both patches. Thanks. Here are some more comments. The version extraction logic is currently: + /* __WATCOMC__ = VVRR + 1100 Open Watcom */ +# define COMPILER_VERSION_MAJOR DEC((__WATCOMC__ - 1100 ) / 100) +# define

Re: [cmake-developers] Android platform file

2014-03-17 Thread Stephen Kelly
Brad King wrote: However, I do not think the line set(Android 1) should appear. Projects can test CMAKE_SYSTEM_NAME if needed. Thats fine with me. Removed. Thanks, Steve. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at:

Re: [cmake-developers] FindPkgConfig_Extend-PKG_CONFIG_PATH

2014-03-17 Thread Daniele E. Domenichelli
On 16/03/14 23:49, Christoph Grüninger wrote: I'd like to add additional paths for pkg_check_modules similar to find_program: [PATHS path1 [path2 ... ENV var]] Daniele would you mind to add such a feature? Or are there any objections if I do it myself? No objections if you want to add it

Re: [cmake-developers] [PATCH] Enable Wmake generator on Linux host

2014-03-17 Thread Jiri Malak
Brad, I attached corrected patch. Regards Jiri On 03/16/2014 07:43 AM, Jiri Malak wrote: I enclosed patch, which enable generation of wmake makefiles on Linux host. The CMake condition if(WIN32 OR UNIX AND NOT APPLE) and the preprocessor condition #if defined(_WIN32) ||

Re: [cmake-developers] [PATCH] Correct platform related variables for Open Watcom compilers

2014-03-17 Thread Jiri Malak
Bred, I enclosed corrected patches. Open Watcom didn't use last digit up to now. For Watcom I looked into history and it was used as patch version. I correct patch to use last digit as patch version. I suppress patch number for base version (0 patch) to follow generaly used Watcom/Open Watcom

Re: [cmake-developers] [PATCH] Enable Wmake generator on Linux host

2014-03-17 Thread Brad King
On 03/17/2014 02:34 PM, Jiri Malak wrote: I attached corrected patch. Applied with minor tweaks, thanks: Watcom: Enable 'WMake Makefiles' generator on Linux http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=64c2342a -Brad -- Powered by www.kitware.com Please keep messages on-topic and

Re: [cmake-developers] [PATCH] Correct platform related variables for Open Watcom compilers

2014-03-17 Thread Brad King
On 03/17/2014 02:49 PM, Jiri Malak wrote: I enclosed corrected patches. Open Watcom didn't use last digit up to now. For Watcom I looked into history and it was used as patch version. I correct patch to use last digit as patch version. I suppress patch number for base version (0 patch) to

[cmake-developers] [CMake 0014811]: Too many include paths are set to AM_MOC_INCLUDES in AutomocInfo.cmake then the build fails.

2014-03-17 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=14811 == Reported By:Yew Kurabayashi  Assigned To: