Re: [cmake-developers] FindQt4.cmake Qt5 qmake

2014-06-27 Thread Nils Gladitz
On 25.06.2014 16:07, Nils Gladitz wrote: Eike pointed out misguided FindQt4.cmake diagnostics in my dashboard submissions: http://open.cdash.org/viewConfigure.php?buildid=3382423 I merged FindQt4-ignore-qt5 for testing which I hope is an appropriate fix. I would appreciate it if those who

Re: [cmake-developers] FindJPEG alternative name

2014-06-27 Thread Brad King
On 06/26/2014 03:19 PM, Sebastian Elsner wrote: newer version of jpeglib build the .lib file on windows with a different name by default. Its now called libjpeg.lib instead of jpeg.lib. Please see the patch appended. Applied, thanks: FindJPEG: Add alternative name 'libjpeg'

Re: [cmake-developers] [PATCH] FindOpenMP: ICC 15 deprecates -openmp, use -qopenmp

2014-06-27 Thread Brad King
On 06/26/2014 09:29 AM, Adam Strzelecki wrote: Intel Composer XE 2015 Beta 2 deprecates all options starting with -o for sake of compatibility with other compilers expecting anything goes after -o... is output file name. Applied, thanks: FindOpenMP: ICC 15 deprecates -openmp, use -qopenmp

[cmake-developers] Remove check for source files in add_library()

2014-06-27 Thread Ådne Hovda
Hi It would be handy when creating macros that wraps add_library where the number of source files is unknown to be able to write: add_library( mylib ) target_sources( mylib PRIVATE mylib.c mylib.h ) but this fails with the warning You have called ADD_LIBRARY for library testlib without any

Re: [cmake-developers] FindQt4.cmake Qt5 qmake

2014-06-27 Thread Brad King
On 06/27/2014 05:07 AM, Nils Gladitz wrote: It has been pointed out that the change might still make sense since the current behavior just removes the diagnostics in the Qt4_FIND_QUIETLY case. Yes, I think the change still makes sense. You can rebase on 'master' and drop the

Re: [cmake-developers] [PATCH] [Module] FindPNG: Add Env Hint via PNG_ROOT

2014-06-27 Thread Brad King
On 06/27/2014 11:04 AM, Huebl, Axel wrote: This patch provides users the optional hint via the environment variable PNG_ROOT. This comes very useful when libpng is not installed in a default location and/or if several versions are installed in parallel. Typically it is not necessary to have a

Re: [cmake-developers] [PATCH] [Module] FindPNG: Add Env Hint via PNG_ROOT

2014-06-27 Thread Huebl, Axel
CMAKE_PREFIX_PATH is indeed an option, too. The main intension of the patch is to align the package with the standard functionality of other modules (Boost, MPI, HDF5 and similar). Axel On 27.06.2014 18:17, Brad King wrote: On 06/27/2014 11:04 AM, Huebl, Axel wrote: This patch provides users

Re: [cmake-developers] [PATCH] [Module] FindPNG: Add Env Hint via PNG_ROOT

2014-06-27 Thread Brad King
On 06/27/2014 12:37 PM, Huebl, Axel wrote: CMAKE_PREFIX_PATH is indeed an option, too. The main intension of the patch is to align the package with the standard functionality of other modules (Boost, MPI, HDF5 and similar). Very few modules provide _ROOT variables, and those that do have

Re: [cmake-developers] [PATCH] [Module] FindPNG: Add Env Hint via PNG_ROOT

2014-06-27 Thread Huebl, Axel
Oh you are right, even only 80 out of 297 modules respond to grep _ROOT I guess I was just spoiled by them. Thanks for the feedback and congrats on the 3.0 release! Axel On 27.06.2014 19:10, Brad King wrote: On 06/27/2014 12:37 PM, Huebl, Axel wrote: CMAKE_PREFIX_PATH is indeed an option,

[cmake-developers] [PATCH 3/3] Ninja: Skip generating empty phony rules

2014-06-27 Thread Adam Strzelecki
Ninja generator ensures that all custom commands being target dependencies are run before other sources compilation. However in case there are no such dependencies it does currently generate empty phony rules which clutter build graph. This change make Ninja generator produce this rules only when

[cmake-developers] [PATCH 2/3] Ninja: Don't limit custom cmd side-effects to build folder (#14972)

2014-06-27 Thread Adam Strzelecki
Actually custom command can write wherever it wants to, such as temporary folder or source folder, possibly violating rules that only build folder should be affected. Therefore we should consider custom command dependency at any path as possible side effect adding phony rule. ---

[cmake-developers] [PATCH 1/3] Ninja: Consider only custom commands deps as side-effects (#14972)

2014-06-27 Thread Adam Strzelecki
Previously all explicit dependencies inside build folder were considered as possible build command side-effects and phony rules were produced for them in case they don't exist yet starting build. This however incorrect since regular compile inputs need to exist otherwise cmake will fail. Moreover

[cmake-developers] Broken progress output with make -jXX (aka parallel make)

2014-06-27 Thread Adam Strzelecki
Excuse me if it was discussed already, reported, etc. Even it doesn't affect me anyway since I use Ninja, but some of my colleagues still use Make and do parallel builds and fancy output is produced: (now some HTML format ;P) [ 5%] [ 15%] [ 21%] [ 26%] [ 26%] Building CXX object