Re: [cmake-developers] [PATCH] ExternalProject_Add: Allow generator expressions in CMAKE_CACHE_ARGS

2015-04-20 Thread Andrey Pokrovskiy
Please disregard my previous email, didn't notice Brad's reply. On Mon, Apr 20, 2015 at 6:25 PM, Andrey Pokrovskiy wonder.m...@gmail.com wrote: Will it go to mainline? Is there any formal code review process? On Fri, Apr 17, 2015 at 10:58 AM, David Cole dlrd...@aol.com wrote: Great -- thanks

Re: [cmake-developers] [PATCH] ExternalProject_Add: Allow generator expressions in CMAKE_CACHE_ARGS

2015-04-20 Thread Andrey Pokrovskiy
Will it go to mainline? Is there any formal code review process? On Fri, Apr 17, 2015 at 10:58 AM, David Cole dlrd...@aol.com wrote: Great -- thanks for checking. This proposed change looks reasonable to me... On Fri, Apr 17, 2015 at 12:27 PM, Andrey Pokrovskiy wonder.m...@gmail.com wrote:

[cmake-developers] [CMake 0015524]: CTestTestSerialOrder test fails if CTEST_PARALLEL_LEVEL 1

2015-04-20 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15524 == Reported By:Stephen Kelly Assigned To:

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

2015-04-20 Thread Domen Vrankar
Is there any other thing you would like to do before I continue working on this? Do you foresee any other change like this? No, go ahead. Regards, Domen -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware

[cmake-developers] [CMake 0015523]: ninja AUTORCC with AUTOGEN_TARGET_DEPENDS generated resources

2015-04-20 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=15523 == Reported By:Norbert Pfeiler Assigned To:

Re: [cmake-developers] [PATCH] ExternalProject_Add: Allow generator expressions in CMAKE_CACHE_ARGS

2015-04-20 Thread Brad King
On 04/17/2015 01:58 PM, David Cole via cmake-developers wrote: Great -- thanks for checking. This proposed change looks reasonable to me... Thanks for checking it, David. Andrey, thanks for working on this! On 04/17/2015 12:55 AM, Andrey Pokrovskiy wrote: generator expressions are supported

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

2015-04-20 Thread Domen Vrankar
Hi, If I am not mistaken, this does not work in the current state of the cmCpackDebGenerator.cxx (I tried of course). I wanted to know by which *magic* this could work, and also why you are suggesting me this, which lead me to this: - CPackRPM: all the RPM creation is driven by the

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

2015-04-20 Thread Raffi Enficiaud
Le 18/04/15 09:34, Domen Vrankar a écrit : I added the following functionalities: - set the permissions of the md5sum to RW-R--R--, because lintian complains - added an option to set the shlibdeps per component - added an option to set the dependencies per component - added an option to set the

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

2015-04-20 Thread Domen Vrankar
I'll write a patch for that today and push it to next. I'll also add link here so that you'll be able to use it before it gets to master. Here's the patch: http://www.cmake.org/gitweb?p=cmake.git;a=commitdiff;h=268e008 Now it should be easy to add support for per component variables. There is

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

2015-04-20 Thread Raffi Enficiaud
Le 20/04/15 19:19, Domen Vrankar a écrit : Hi, [...] - CPackRPM: all the RPM creation is driven by the CPackRPM.cmake itself - CPackDEB: part of package configuration is sent from the .cmake back to the cmCPackDebGenerator.cxx, and some internal functions in C++ are creating the package

Re: [cmake-developers] [CMake 0011944]: CPackDeb: Support dependencies between components/Debian packages

2015-04-20 Thread Domen Vrankar
On the other hand variables that are set in CPackDEB.cmake for one component are later visible in the other - they don't get reread from CMakeLists.txt for every pass. So setting variables inside CPackDEB.cmake is a bit dangerous. Ok. I do not understand that much the value of this feature,