Re: [cmake-developers] Fortran module dependencies and preprocessing in CMake 3.3.0-rc3

2015-07-06 Thread Brad King
On 07/02/2015 06:25 PM, Radovan Bast wrote: I can consistently reproduce it locally on 3 different machines (Ubuntu 14.04 and Arch derivative; gfortran 4.8.4 and 5.1.0). I have Git bisected the history and this is the commit that broke this example on my machines:

Re: [cmake-developers] Fortran module dependencies and preprocessing in CMake 3.3.0-rc3

2015-07-06 Thread Radovan Bast
dear Brad, SOMEDEF is defined at compile time. Attached is a tarball that contains the CMakeLists.txt which defines SOMEDEF, a main.F90 and a mymodule.F90 which contains the module which is not built prior to building main.F90. In principle the problem can be reproduced like this: ``` tar xvzf

Re: [cmake-developers] PATCH: add subcommand string(APPEND)

2015-07-06 Thread Daniel Pfeifer
On Mon, Jul 6, 2015 at 8:41 PM, Brad King brad.k...@kitware.com wrote: On 07/04/2015 06:27 PM, Daniel Pfeifer wrote: Attached is a patch that adds a subcommand string(APPEND). This allows to write string(APPEND string_variable some string) instead of set(string_variable

Re: [cmake-developers] PATCH: add subcommand string(APPEND)

2015-07-06 Thread James Bigler
list(APPEND) requires at least one element argument, right? Can you require the same thing for string(APPEND)? That would make it symmetric and remove your edge case. On Mon, Jul 6, 2015 at 2:47 PM, Daniel Pfeifer dan...@pfeifer-mail.de wrote: On Mon, Jul 6, 2015 at 8:41 PM, Brad King

Re: [cmake-developers] Fortran module dependencies and preprocessing in CMake 3.3.0-rc3

2015-07-06 Thread Radovan Bast
dear Brad, thanks a lot! This is very much appreciated. Best wishes, radovan On Mon, Jul 6, 2015 at 4:41 PM Brad King brad.k...@kitware.com wrote: On 07/06/2015 09:13 AM, Radovan Bast wrote: SOMEDEF is defined at compile time. Attached is a tarball that contains the CMakeLists.txt which

Re: [cmake-developers] [PATCH] Option CMAKE_INSTALL_COMPONENTS and IFW installer

2015-07-06 Thread Brad King
On 07/03/2015 09:09 AM, Konstantin Podsvirov wrote: About 6 months ago I started a topic cmake-install-components. Today I am ready to share the results. Great, thanks! The changes look good except for comments below. So as not to disturb those who do not need it I have added the option

Re: [cmake-developers] PATCH: add subcommand string(APPEND)

2015-07-06 Thread Daniel Pfeifer
On Mon, Jul 6, 2015 at 10:55 PM, James Bigler jamesbig...@gmail.com wrote: list(APPEND) requires at least one element argument, right? No, see https://github.com/Kitware/CMake/blob/master/Source/cmListCommand.cxx#L236 -- Powered by www.kitware.com Please keep messages on-topic and check the

Re: [cmake-developers] PATCH: add subcommand string(APPEND)

2015-07-06 Thread Brad King
On 07/04/2015 06:27 PM, Daniel Pfeifer wrote: Attached is a patch that adds a subcommand string(APPEND). This allows to write string(APPEND string_variable some string) instead of set(string_variable ${string_variable}some string) Thanks. Please extend the first patch to also add

Re: [cmake-developers] CTest: hide progress ticks in verbose output

2015-07-06 Thread Brad King
On 07/03/2015 05:02 PM, Daniel Pfeifer wrote: The attached patch hides the progress ticks when the output is shown (-VV). Good idea. Applied: CTest: hide progress ticks in verbose output http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=140b1864 Thanks, -Brad -- Powered by

Re: [cmake-developers] Feature Request: Modify CXX_STANDARD behavior for Xcode Generator: Starting Tips?

2015-07-06 Thread Brad King
On 07/02/2015 10:22 PM, Jason Felds wrote: it places the -std=gnu++11 (or equivalent) calls in the OTHER_CPLUSPLUSFLAGS attribute instead of the CLANG_CXX_LANGUAGE_STANDARD attribute. Yes. This is just because the generator hasn't been taught to do so. If this is added it also needs to be made

Re: [cmake-developers] [PATCH] ExternalProject: Added new USES_TERMINAL options

2015-07-06 Thread Brad King
On 07/06/2015 01:52 AM, James Johnston wrote: I worked on a patch to allow you to pass USES_TERMINAL through ExternalProject to the underlying add_custom_command(). Very nice. I applied the commit: ExternalProject: Added new USES_TERMINAL options

Re: [cmake-developers] Xcode generator does not recognize -Ofast

2015-07-06 Thread Brad King
On 07/03/2015 10:48 PM, umir...@gmail.com wrote: However, the Xcode Generator does not handle the -Ofast flag properly, and then it is necessary to the set Optimization Level manually when -Ofast flag is utilized in the project. This is because the Xcode Generator uses just one letter

Re: [cmake-developers] [PATCH] cmArchiveWrite: don't store sparse files when using standard tar formats

2015-07-06 Thread Brad King
On 07/06/2015 10:54 AM, Roman Donchenko wrote: Sparse files in tars are a GNU extension that libarchive will use if it detects holes in the input file, even when using the standard pax/paxr formats. Not all tar implementations can handle sparse files; in particular, the internal implementation

Re: [cmake-developers] Add command line options for deprecation message control

2015-07-06 Thread Brad King
On 07/02/2015 04:45 PM, Michael Scott wrote: On 06/30/2015 05:42 PM, Stephen Kelly wrote: What is the difference between the intended uses of those existing options and the intended uses of the new options, given that -Wno-dev is mostly useful for third parties to silence policy warnings?

[cmake-developers] [PATCH] ExternalProject: Added new USES_TERMINAL options

2015-07-06 Thread James Johnston
Hi, I worked on a patch to allow you to pass USES_TERMINAL through ExternalProject to the underlying add_custom_command(). Here is the commit message: ExternalProject: Added new USES_TERMINAL options Added new USES_TERMINAL option to the ExternalProject_Add_Step function. This option passes

Re: [cmake-developers] Fortran module dependencies and preprocessing in CMake 3.3.0-rc3

2015-07-06 Thread Brad King
On 07/06/2015 09:13 AM, Radovan Bast wrote: SOMEDEF is defined at compile time. Attached is a tarball that contains the CMakeLists.txt which defines SOMEDEF, a main.F90 and a mymodule.F90 which contains the module which is not built prior to building main.F90. Thanks. I've drafted a fix and a

[cmake-developers] [PATCH] cmArchiveWrite: don't store sparse files when using standard tar formats

2015-07-06 Thread Roman Donchenko
Sparse files in tars are a GNU extension that libarchive will use if it detects holes in the input file, even when using the standard pax/paxr formats. Not all tar implementations can handle sparse files; in particular, the internal implementation dpkg uses to extract packages can't. To maximize