Re: [cmake-developers] Add command line options for deprecation message control

2015-09-21 Thread Brad King
On 09/19/2015 06:32 PM, Michael Scott wrote: > whether the -W options are intended to only be applicable > for the message command (and so the current behaviour is correct), > or whether they should affect all author and deprecated messages > output by other parts of CMake? The -Wdev/-Wno-dev

Re: [cmake-developers] CPack/NSIS is broken after extended length paths fix

2015-09-21 Thread Clinton Stimpson
On Monday, September 21, 2015 12:28:37 PM Dmitry Kochkin wrote: > Hi Clint, > > >>Actually it's even worse because in current master HEAD I can see that > >>INST_DIR is empty in generated project: !define INST_DIR "" > >>(not sure if that's caused by your change) > > > >Interesting... Do you

[cmake-developers] [CMake 0015753]: CMake cannot detect changes in nested header files when using '-iquote'

2015-09-21 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=15753 == Reported By:danilcha Assigned To:

Re: [cmake-developers] generator expression for path slash conversion

2015-09-21 Thread Kislinskiy, Stefan
Ah, thank you very much! I was confused as the distinction between WIN32 and UNIX worked nevertheless. -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Montag, 21. September 2015 16:17 To: Kislinskiy, Stefan Cc: CHEVRIER, Marc; cmake-developers@cmake.org; James

Re: [cmake-developers] Generator expressions for install destination

2015-09-21 Thread Brad King
On 09/18/2015 03:49 PM, Robert Goulet wrote: > Here's a version that is more conservative. It doesn't change > the install(EXPORT) behavior. > install(TARGET) already supported genex Right. I'd forgotten about these changes: install: Allow generator expressions in TARGETS DESTINATION (#14317)

[cmake-developers] [CMake 0015755]: add_dependencies() undoes include_directories()

2015-09-21 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=15755 == Reported By:Dimitri Merejkowsky Assigned To:

Re: [cmake-developers] [PATCH] [CMake 0015674]: Windows: Correctly determine Windows version

2015-09-21 Thread Brad King
On 09/18/2015 02:24 PM, Brad King wrote: > After working out the support for manifests across all generators > as discussed elsewhere in this thread, I've added your manifest > file to CMake's own build: > > Windows: Fix CMAKE_HOST_SYSTEM_VERSION on Windows >= 8 (#15674) >

Re: [cmake-developers] generator expression for path slash conversion

2015-09-21 Thread Kislinskiy, Stefan
I wrote the documentation and extended the GeneratorExpression tests for the SHELL_PATH genex. It works fine for WIN32 and UNIX. However, I'm having some trouble to test for MSYS. The check looks like: if(MSYS) check(test_shell_path "/c/shell/path") elseif(WIN32) check(test_shell_path

Re: [cmake-developers] generator expression for path slash conversion

2015-09-21 Thread Brad King
On 09/21/2015 10:05 AM, Kislinskiy, Stefan wrote: > if(MSYS) > check(test_shell_path "/c/shell/path") > elseif(WIN32) > check(test_shell_path "c:shellpath") > elseif(UNIX) > check(test_shell_path "c:/shell/path") > endif() > > No matter what I'm doing, it always ends up in the WIN32

Re: [cmake-developers] [PATCH] [CMake 0015674]: Windows: Correctly determine Windows version

2015-09-21 Thread Brad King
On 09/18/2015 02:58 PM, James Johnston wrote: > While on the subject, there are some other additions to the manifest you > might want to consider. I think these are worth considering but we're too close to the 3.4 freeze to make these changes now. Please look at adding these during post-3.4

[cmake-developers] [CMake 0015754]: Visual Studio incremental build not working properly when target names start with a capital letter

2015-09-21 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=15754 == Reported By:Johannes Asal Assigned To:

[cmake-developers] [CMake 0015756]: FindLua.cmake doesn't work when both Lua5.2 and Lua5.3 are installed.

2015-09-21 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15756 == Reported By:Alan Witkowski Assigned To:

Re: [cmake-developers] Add command line options for deprecation message control

2015-09-21 Thread Michael Scott
The -Wdev/-Wno-dev options have always been for all messages output by any part of CMake. This needs to be preserved/corrected. Okay, I've fixed the change to cmake::PrintMessagePreamble, so that it'll stop warning or error dev or deprecated messages getting printed out when the relevant CMake

Re: [cmake-developers] CPack/NSIS is broken after extended length paths fix

2015-09-21 Thread Dmitry Kochkin
Hi Clint, >>Actually it's even worse because in current master HEAD I can see that >>INST_DIR is empty in generated project: >>  !define INST_DIR "" >>(not sure if that's caused by your change) >Interesting... Do you know why this happens?  How is this problem related to >extended paths (with