Re: [cmake-developers] added get_git_revision and get_git_branch commands as follow-up to cm...@cmake.org

On 09/25/2015 11:32 AM, Daniel Wirtz wrote: > here's my proposal for the git convenience functions, see > http://public.kitware.com/pipermail/cmake/2015-September/061516.html Thanks for working on this. > additionally, can someone hint me as to how to build the html-help > locally? i want to

Re: [cmake-developers] added get_git_revision and get_git_branch commands as follow-up to cm...@cmake.org

On Fri, Sep 25, 2015 at 17:32:24 +0200, Daniel Wirtz wrote: > Hello all, > here's my proposal for the git convenience functions, see > http://public.kitware.com/pipermail/cmake/2015-September/061516.html > > i've also created a pull request > https://github.com/Kitware/CMake/pull/185 (before i

Re: [cmake-developers] CXX_STANDARD and linking (was: C++11 support broken for SolarisStudio 12.4)

Steve, On 09/25/2015 03:58 AM, CHEVRIER, Marc wrote: > * If I add option -std=c++11 in the file .../Test.dir/link.txt, > link is successful Compiling with a -std= flag should link with such a flag too. Flags like this are why CMake has always passed CMAKE_CXX_FLAGS to the C++ compiler when

Re: [cmake-developers] Add command line options for deprecation message control

I'm going to proceed with my reversion of the entire feature for 3.4. We can pick this up during post-3.4 development when you have time. Then we can review the all related semantics together. Okay, that's fair enough, sorry it hasn't been possible to get it into the 3.4 release in time.

Re: [cmake-developers] Add command line options for deprecation message control

On 09/25/2015 04:12 PM, Brad King wrote: > I'm going to proceed with my reversion of the entire feature for 3.4. > We can pick this up during post-3.4 development when you have time. > Then we can review the all related semantics together. Reverted here: Revert topic 'cmake-W-options'

[cmake-developers] [CMake 0015758]: FindGit does not work when git is installed through SourceTree

The following issue has been SUBMITTED. == https://public.kitware.com/Bug/view.php?id=15758 == Reported By:Kevin Wojniak Assigned To:

Re: [cmake-developers] [Patch] Adding Windows 10 support

On 09/25/2015 01:00 PM, Gilles Khouzam wrote: > This was done deliberately to only force a value for > CMAKE_WINDOWS_TARGET_PLATFORM_VERSION With the approach in my patch that variable is never set by the generator. It chooses a WindowsTargetPlatformVersion value and reports it in

Re: [cmake-developers] Add command line options for deprecation message control

On 09/25/2015 03:44 PM, Michael Scott wrote: > it's release period at my office too so a busy time there as well. Okay, I really don't want to try to rush in a fix for this before the 3.4 deadline, especially when we're both busy with other things. The entire feature was developed under the

Re: [cmake-developers] Add command line options for deprecation message control

Sorry I'm being a bit slow with this topic, it's release period at my office too :D so a busy time there as well. The cmake::Configure check for that runs before the scripts run so it is not possible to get script-provided values there. Do you have a check in a new context that occurs later?

Re: [cmake-developers] [Patch] Adding Windows 10 support

Thanks for the refactor Brad, The patches make sense. >After your change to add a third component to CMAKE_HOST_SYSTEM_VERSION the >value of CMAKE_SYSTEM_VERSION on a Windows 10 host may have a third component. >Therefore we should check that the version starts with "10.0" rather than is

Re: [cmake-developers] [Patch] Adding Windows 10 support

You're right, by targeting another version (8.1 or 6.3), the tag would not be written. Leveraging CMAKE_SYSTEM_VERSION is an interesting idea. Let me mull it over a little bit more and see how I would apply to newer SDKs as they come out, as I would like to minimize the required changes to

[cmake-developers] [CMake][BUG] C++11 support broken for SolarisStudio 12.4

Hi, Currently, it is not possible to use C++11 mode on Solaris with SolarisStudio 12.4 (test done on Solaris 11.2 sparc). If I try a simple executable (see attached file), compilation is OK (option –std=c++11 is correctly passed to compiler) but link failed because, with SolarisStudio

[cmake-developers] [CMake][BUG] Unable to build CMake with SolarisStudio 12.4

Hi, Attached is a patch fixing compilation error which prevent building CMake with SolarisStudio 12.4. Marc 0001-SolarisStudio-12.4-cmake-compilation-fix.patch Description: 0001-SolarisStudio-12.4-cmake-compilation-fix.patch -- Powered by www.kitware.com Please keep messages on-topic and

Re: [cmake-developers] [CPack][BUG] Fail to package with CPACK_INSTALLED_DIRECTORIES

2015-09-24 9:06 GMT+02:00 Domen Vrankar : > 2015-09-23 17:00 GMT+02:00 CHEVRIER, Marc : >> Any comments about this problem? There was a bug in file creation time handling. Fix is in cmake git repository on next branch:

Re: [cmake-developers] Timestamp of VS-generator rule files

On 09/25/2015 07:45 AM, mike.pa...@bmw.de wrote: > I wrote a small function OutdateFileTime(const std::string& filename) > which does what it sounds like. It is called by the VS generator right > after rule file creation with Touch. I wasn't sure whether this function, > which uses Win32 API

Re: [cmake-developers] Add command line options for deprecation message control

On 09/24/2015 05:45 PM, Michael Scott wrote: > I've created a fix for the issue of -Wno-dev and -Wno-deprecated options > not being honoured, and extended the tests to cover this additional > scenario. Thanks for working on it. > However I'm having an issue with determining if variables are

Re: [cmake-developers] Timestamp of VS-generator rule files

I have a local version working, but want to double-check how to best go about this. As a reminder, I am trying to fix the .rule file handling of CMake's VisualStudio generator, which violates CMakes semantics "custom_commands without dependencies are built only if the outputs don't exist yet".

Re: [cmake-developers] [CPack][BUG] Fail to package with CPACK_INSTALLED_DIRECTORIES

Hi Domen, Good news! With your patch, packaging on Windows is now working as expected. Thank you. Marc On 25/09/15 10:34, "Domen Vrankar" wrote: >2015-09-24 9:06 GMT+02:00 Domen Vrankar : >> 2015-09-23 17:00 GMT+02:00 CHEVRIER, Marc

Re: [cmake-developers] [CMake][BUG] Unable to build CMake with SolarisStudio 12.4

On 09/25/2015 04:02 AM, CHEVRIER, Marc wrote: > Attached is a patch fixing compilation error which prevent > building CMake with SolarisStudio 12.4. Thanks, applied: jsoncpp: Add missing cast to convert from char to UInt http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a7fe4413 -Brad --

[cmake-developers] [CMake][BUG] Ensure C based tests do not used C++ syntax

Hi, I encountered some problems validating a CMake build on AIX using IBM xlc/xlC compilers. The problem comes from the fact that, by default, C compiler does not recognized C++-Style comments. So, attached is a patch ensuring that sources compiling with a C compiler have C-Style comments

Re: [cmake-developers] generator expression for path slash conversion

On 09/24/2015 11:08 AM, Kislinskiy, Stefan wrote: > Regarding the nice bracket tweak: Maybe the minimum required > version in Tests/GeneratorExpression/CMakeLists.txt should be > updated to 3.0.0 then? The test also covers policy CMP0044 behavior and so cannot require a version new enough to set

Re: [cmake-developers] generator expression for path slash conversion

On 09/24/2015 11:08 AM, Kislinskiy, Stefan wrote: > Regarding the ExternalProjectShellPathGenex test [snip] > there is a standard Windows command out there that cannot > handle slashed even if they are quoted (any idea?) Rather than trying to find a command for this you could just have the test

Re: [cmake-developers] [CMake][BUG] Ensure C based tests do not used C++ syntax

On 09/25/2015 09:20 AM, CHEVRIER, Marc wrote: > patch ensuring that sources compiling with a C compiler have C-Style comments Thanks, applied: Tests: Use C-Style comments in C sources and headers http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4eb77a1c -Brad -- Powered by

[cmake-developers] [CMake][BUG] ProcessorCount is broken on current SunOS systems

Hi, Attached is a patch to ensure that ProcessorCount returns correct information on recent SunOS systems (tested on Sunos 5.11 (i.e. Solaris 11.2)). Marc 0001-Update-ProcessorCount-module-for-recent-SunOS.patch Description: 0001-Update-ProcessorCount-module-for-recent-SunOS.patch --

Re: [cmake-developers] [CMake][BUG] ProcessorCount is broken on current SunOS systems

On 09/25/2015 10:15 AM, CHEVRIER, Marc wrote: > Attached is a patch to ensure that ProcessorCount returns correct > information on recent SunOS systems Thanks, applied: ProcessorCount: Implement with psrinfo tool on recent SunOS versions