Re: [cmake-developers] Using CMake generated ninja file as a subninja file

2016-05-13 Thread Nicolas Desprès
On Fri, May 13, 2016 at 9:38 PM, Brad King wrote: > On 05/13/2016 03:25 PM, Brad King wrote: > > so for now please make your logic recognize this case and work around it. > > Please split this into two commits to move hunks like this: > > > + this->TargetAll = this->NinjaOutputPath("all"); > > +

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

2016-05-13 Thread Brad King
On 05/13/2016 03:25 PM, Brad King wrote: > so for now please make your logic recognize this case and work around it. Please split this into two commits to move hunks like this: > + this->TargetAll = this->NinjaOutputPath("all"); > + this->CMakeCacheFile = this->NinjaOutputPath("CMakeCache.txt")

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

2016-05-13 Thread Brad King
On 05/13/2016 12:13 PM, Nicolas Desprès wrote: > with a value that looks like this: > "-Wl,-bundle_loader,/Users/polrop/Documents/cmake/_build > ninja/Tests/ExportImport/Export/testExe2" > > lie on the caller site because the "if (li->IsPath)" in OutputLinkLibraries() > should not be true for su

[cmake-developers] [PATCH] FindBoost: Boost 1.61

2016-05-13 Thread Roger Leigh
Boost 1.61 was released today. My boost-1.61 branch, merged into next, adds the updated dependency information for this release. The version information was already added, so is unchanged. Regards, Roger -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at:

Re: [cmake-developers] [Patch] FindPkgConfig: optionally create imported target for the found libraries

2016-05-13 Thread Rolf Eike Beer
Am Freitag, 13. Mai 2016, 13:38:52 schrieb Brad King: > On 05/13/2016 12:21 PM, Rolf Eike Beer wrote: > >> Can you just use > >> > >> set_property(TARGET PkgConfig::${_prefix} PROPERTY ...) > >> > >> in each `if()` block? > > > > I had this before, but I thought I avoid multiple target lookups

Re: [cmake-developers] [PATCH] FindBoost does not detect absence of header file

2016-05-13 Thread Roger Leigh
On 13/05/2016 14:36, Brad King wrote: On 05/12/2016 03:49 PM, Roger Leigh wrote: I have made the suggested changes above where this was possible, and merged the boost-component-headers branch into next for testing. Thanks. It looks pretty good, but there is one problem: +find_path(Boost

Re: [cmake-developers] [Patch] FindPkgConfig: optionally create imported target for the found libraries

2016-05-13 Thread Brad King
On 05/13/2016 12:21 PM, Rolf Eike Beer wrote: >> Can you just use >> >> set_property(TARGET PkgConfig::${_prefix} PROPERTY ...) >> >> in each `if()` block? > > I had this before, but I thought I avoid multiple target lookups. You should > only ever see that message if none of the branches is tak

Re: [cmake-developers] [Patch] FindPkgConfig: optionally create imported target for the found libraries

2016-05-13 Thread Rolf Eike Beer
Am Freitag, 13. Mai 2016, 11:16:28 schrieb Brad King: > On 05/13/2016 11:02 AM, Rolf Eike Beer wrote: > > Should all be done now. > > Thanks. > > The test fails for me with > > CMake Error at /.../Modules/FindPkgConfig.cmake:239 > (set_target_properties): set_target_properties called with in

Re: [cmake-developers] Using CMake generated ninja file as a subninja file

2016-05-13 Thread Nicolas Desprès
On Thu, May 12, 2016 at 10:07 PM, Brad King wrote: > On 05/12/2016 02:16 PM, Nicolas Desprès wrote: > > All done. Thank you for taking a look. > > https://github.com/nicolasdespres/CMake/commits/ninja-output-path-prefix > > The RunCMake.NinjaOutputPathPrefix test fails for me when I have > the CM

Re: [cmake-developers] [Patch] FindPkgConfig: optionally create imported target for the found libraries

2016-05-13 Thread Brad King
On 05/13/2016 11:02 AM, Rolf Eike Beer wrote: > Should all be done now. Thanks. The test fails for me with CMake Error at /.../Modules/FindPkgConfig.cmake:239 (set_target_properties): set_target_properties called with incorrect number of arguments. At least part of the problem is here

Re: [cmake-developers] [Patch] FindPkgConfig: optionally create imported target for the found libraries

2016-05-13 Thread Rolf Eike Beer
Am Donnerstag, 12. Mai 2016, 13:17:42 schrieb Brad King: > On 05/12/2016 12:48 PM, Rolf Eike Beer wrote: > > Good point. I have changed this accordingly and pushed it to next. There > > are no tests yet, so maybe not immediately merge it to next but wait for > > the weekend or so. > > Okay, thanks

Re: [cmake-developers] [PATCH] FindBoost does not detect absence of header file

2016-05-13 Thread Brad King
On 05/12/2016 03:49 PM, Roger Leigh wrote: > I have made the suggested changes above where this was possible, and > merged the boost-component-headers branch into next for testing. Thanks. It looks pretty good, but there is one problem: > +find_path(Boost_${UPPERCOMPONENT}_HEADER > + N

[cmake-developers] [CMake 0016103]: AUTORCC will not regenerate qrc when a resource changes

2016-05-13 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == https://cmake.org/Bug/view.php?id=16103 == Reported By:OregonGhost Assigned To: ===