Re: [cmake-developers] FindFreetype patch for Windows debug lib naming

2016-06-09 Thread Stuart Mentzer
On 6/9/2016 9:33 AM, Rolf Eike Beer wrote: Am 2016-06-09 15:00, schrieb Brad King: On 06/08/2016 12:33 AM, Stuart Mentzer wrote: Here is a little patch that lets FindFreetype find the debug library on Windows, where it is named with a d suffix. Thanks. I split the patch into two and

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-09 Thread Daniel Pfeifer
On Thu, Jun 9, 2016 at 2:17 PM, Brad King wrote: > On 06/09/2016 05:06 AM, Tobias Hunger wrote: >> CMake Error at src/1/app/CMakeLists.txt:70 (add_custom_target): >> Cannot find source file: >> >> unknownFile.qml >> >> Tried extensions .c .C .c++ .cc .cpp .cxx .m .M

Re: [cmake-developers] CMake daemon-mode

2016-06-09 Thread Brad King
On 06/09/2016 04:24 PM, Tobias Hunger wrote: >> Please rebase on that (at least once it is in master). > > How long does it usually take to get something into master? Typically a (business) day or two, but sometimes longer depending on trouble with testing in 'next' on our dashboards. -Brad --

Re: [cmake-developers] daemon-mode: Project structure

2016-06-09 Thread Alexander Neundorf
On Thursday 09 June 2016 12:59:40 Tobias Hunger wrote: > Hi Milian, ... > > > "targets": > > > [ > > > { > > > "fullName":"test", > > > "name":"test", > > > "type":"GLOBAL_TARGET" > > > }, > > > > > > A

Re: [cmake-developers] CMake daemon-mode

2016-06-09 Thread Tobias Hunger
Hi Brad, Am 09.06.2016 19:57 schrieb "Brad King" : > > On 06/09/2016 09:27 AM, Brad King wrote: > >> https://github.com/hunger/CMake/commit/bc060a44b6b2c2281ffe99815163ba02ec835dd6 > > Good. I need to review that one more deeply but should be able to integrate it. > > I

Re: [cmake-developers] daemon-mode: Project structure

2016-06-09 Thread Tobias Hunger
Hello everybody, Ok, so far I changed this:  * sourceGroups got renamed to fileGroups  * System include paths get reported  * GLOBAL_TARGETs are no longer listed.   So this is what it looks right now:   [== CMake MetaMagic ==[ {   # Reply header:   "cookie":"",   "type":"reply",  

Re: [cmake-developers] RFC: LLVM community CMake documentation

2016-06-09 Thread Ben Boeckel
On Thu, Apr 28, 2016 at 14:16:40 -0700, Chris Bieneman wrote: > The only comment I think I didn’t directly update the document for was > Dan’s comment about GLOBAL properties. I kinda have mixed feelings > about GLOBAL properties. I know why we use them, but I’m not sure I > want to encourage

Re: [cmake-developers] cmLocalGenerator::GetTargetFlags

2016-06-09 Thread Brad King
On 06/09/2016 11:28 AM, Ben Boeckel wrote: > On Wed, Jun 08, 2016 at 10:12:13 -0400, Brad King wrote: >> Side note: This is another thing that should be cleaned up in the Ninja >> generator. It should hold target-wide flags in the per-target rules.ninja >> entries instead of duplicating them for

Re: [cmake-developers] cmLocalGenerator::GetTargetFlags

2016-06-09 Thread Ben Boeckel
On Wed, Jun 08, 2016 at 10:12:13 -0400, Brad King wrote: > Side note: This is another thing that should be cleaned up in the Ninja > generator. It should hold target-wide flags in the per-target rules.ninja > entries instead of duplicating them for every object file in build.ninja. > That would

Re: [cmake-developers] daemon-mode: Project structure

2016-06-09 Thread Tobias Hunger
On Do, 2016-06-09 at 16:07 +0200, Milian Wolff wrote: > On Donnerstag, 9. Juni 2016 13:27:26 CEST Tobias Hunger wrote: > > On Do, 2016-06-09 at 08:43 -0400, Brad King wrote: > > > >   "includePath": > > > >   [ > > > >

Re: [cmake-developers] daemon-mode: Project structure

2016-06-09 Thread Tobias Hunger
On Do, 2016-06-09 at 09:47 -0400, Brad King wrote: > On 06/09/2016 09:27 AM, Tobias Hunger wrote: > > I am using the output of cmState::GetTargetTypeName. > > Okay.  We could consider excluding GLOBAL_TARGET targets from the > output.  They never have source files and are nebulously defined. OK,

Re: [cmake-developers] daemon-mode: Project structure

2016-06-09 Thread Brad King
On 06/09/2016 09:27 AM, Tobias Hunger wrote: > I am using the output of cmState::GetTargetTypeName. Okay. We could consider excluding GLOBAL_TARGET targets from the output. They never have source files and are nebulously defined. > How can I get the directory a library/executable will be put

Re: [cmake-developers] FindFreetype patch for Windows debug lib naming

2016-06-09 Thread Rolf Eike Beer
Am 2016-06-09 15:00, schrieb Brad King: On 06/08/2016 12:33 AM, Stuart Mentzer wrote: Here is a little patch that lets FindFreetype find the debug library on Windows, where it is named with a d suffix. Thanks. I split the patch into two and applied: FindFreetype: Factor out common find

Re: [cmake-developers] daemon-mode: Project structure

2016-06-09 Thread Tobias Hunger
On Do, 2016-06-09 at 08:43 -0400, Brad King wrote: > On 06/09/2016 05:47 AM, Tobias Hunger wrote: > > I made some progress with extracting project structure from cmake via the > > daemon-mode. I am rather happy with the information and would love to get > > some > > feedback from other interested

Re: [cmake-developers] CMake daemon-mode

2016-06-09 Thread Brad King
On 06/08/2016 10:11 AM, Brad King wrote: > I had to revert it from 'next' because it caused several LinkFlags > test failures. [snip] On 06/08/2016 12:02 PM, Tobias Hunger wrote: > https://github.com/hunger/CMake/commit/66acf05bc1737211f88b6ad13781c791f1a7bce4 > > has an update. None of the tests

Re: [cmake-developers] FindFreetype patch for Windows debug lib naming

2016-06-09 Thread Brad King
On 06/08/2016 12:33 AM, Stuart Mentzer wrote: > Here is a little patch that lets FindFreetype find the debug > library on Windows, where it is named with a d suffix. Thanks. I split the patch into two and applied: FindFreetype: Factor out common find command arguments

Re: [cmake-developers] daemon-mode: Project structure

2016-06-09 Thread Tobias Hunger
Hi Milian, great that you have found the time to look over this! It is greatly appreciated! On Do, 2016-06-09 at 12:32 +0200, Milian Wolff wrote: > > [== CMake MetaMagic ==[ > > { > >   # Reply header: > >   "cookie":"", > >   "type":"reply" > >   "inReplyTo":"project", > >    > >   # Data: > >  

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-09 Thread Brad King
On 06/09/2016 05:06 AM, Tobias Hunger wrote: > CMake Error at src/1/app/CMakeLists.txt:70 (add_custom_target): > Cannot find source file: > > unknownFile.qml > > Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp > > > CMake Error at src/1/CMakeLists.txt:8

Re: [cmake-developers] daemon-mode: Project structure

2016-06-09 Thread Milian Wolff
On Donnerstag, 9. Juni 2016 09:47:44 CEST Tobias Hunger wrote: > Hello everybody, Hey Tobias, > I made some progress with extracting project structure from cmake via the > daemon-mode. I am rather happy with the information and would love to get > some feedback from other interested parties.

[cmake-developers] daemon-mode: Project structure

2016-06-09 Thread Tobias Hunger
Hello everybody, I made some progress with extracting project structure from cmake via the daemon-mode. I am rather happy with the information and would love to get some feedback from other interested parties. Here is the format that is currently reported (with comments;-): [== CMake MetaMagic

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-09 Thread Tobias Hunger
On Do, 2016-06-09 at 10:18 +0200, Stephen Kelly wrote: > > What I would like to have, is separate subclasses for gcc-style and > > msvc-style messages. In gcc-style, messages look like this: > > > > :row:column: error: > > > > In msvc-style, messages look like this: > > > > (row,column):

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-09 Thread Stephen Kelly
On 06/09/2016 09:49 AM, Daniel Pfeifer wrote: > On Thu, Jan 28, 2016 at 10:42 PM, Stephen Kelly wrote: >> Hi, >> >> I have pushed a extract-cmMessenger branch to my clone: >> >> https://github.com/steveire/CMake/commits/extract-cmMessenger > I have rebased it to master and

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-09 Thread Daniel Pfeifer
On Thu, Jan 28, 2016 at 10:42 PM, Stephen Kelly wrote: > > Hi, > > I have pushed a extract-cmMessenger branch to my clone: > > https://github.com/steveire/CMake/commits/extract-cmMessenger I have rebased it to master and cherry-picked some minor changes. Once those minor