[cmake-developers] [PATCH v5] SystemTools: Teach GetEnv to use correct encoding on Windows

From: Dāvis Mosāns On Windows getenv (and putenv) uses ANSI codepage so it needs to be encoded to internally used encoding (eg. UTF-8). Here we use _wgetenv (and _wputenv) instead and encode that. Change-Id: I8cb91f2386eb0efe3ef0a3132d1603217d710b60 --- SystemTools.cxx|

Re: [cmake-developers] [PATCH] Improve FindGIF version detection (fix for issue #16196)

On 14/07/16 01:52, Brad King wrote: On 07/12/2016 11:16 PM, Ben Campbell wrote: A fix for https://gitlab.kitware.com/cmake/cmake/issues/16196 Thanks! Here are some comments. [snip] Cool - very helpful! I've revised my patch to: - only scan the headerfile once - update the docs in the

Re: [cmake-developers] [PATCH v4] Add MinGW support for FStream

On 07/12/2016 10:05 PM, Dāvis Mosāns wrote: > std::basic_filebuf::open(const wchar_t *) isn't part of C++ standard > and it's only present for MSVC but it isn't present in libstdc++ (MinGW) > so we implement this functionality using GNU libstdc++ stdio_filebuf > extension and _wfopen function.

Re: [cmake-developers] [CMake 0015749]: Make the URL option of ExternalProject_Add to accept lists

On 07/13/2016 05:35 AM, Schmertmann, Lars wrote: > Thanks for the hint. I've merged to `next` for testing: ExternalProject: Add support for multiple alternative URLs https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2eec433f >>> I think for a mix of pathes/URLs we need to move a lot of code

Re: [cmake-developers] [PATCH] Improve FindGIF version detection (fix for issue #16196)

On 07/12/2016 11:16 PM, Ben Campbell wrote: > A fix for https://gitlab.kitware.com/cmake/cmake/issues/16196 Thanks! Here are some comments. > the pairs of file()/string() > commands seem a bit convoluted for extracting strings out of the header > file - is there a more idiomatic approach?

Re: [cmake-developers] [CMake 0015749]: Make the URL option of ExternalProject_Add to accept lists

Thanks for the hint. I removed the ^ to replace all occurrences and not only the first one. ExternalProject.cmake, Line 1670: string(REGEX REPLACE "^file://" "" url "${url}") Lars S. Am 13.07.2016 um 11:14 schrieb David Cole: > Looks like you could also use a list of paths if you express

Re: [cmake-developers] [CMake 0015749]: Make the URL option of ExternalProject_Add to accept lists

Looks like you could also use a list of paths if you express them in "file://..." form. Local files can also be expressed as URLs. David C. On Wed, Jul 13, 2016 at 4:18 AM, Schmertmann, Lars wrote: > Hello there, > > I try to continue the work from André. >

Re: [cmake-developers] cmake -E capabilities

Ping? On Mo, 2016-07-11 at 14:13 +, Tobias Hunger wrote: > https://github.com/hunger/CMake/commits/cmake-capabilities > > is in a state now that could use another review. -- Tobias Hunger, Senior Software Engineer | The Qt Company The Qt Company GmbH, Rudower Chaussee 13, D-12489 Berlin

[cmake-developers] [CMake 0015749]: Make the URL option of ExternalProject_Add to accept lists

Hello there, I try to continue the work from André. With the attached patch it is possible to use a list of URLs but it is still limited to a single path. I think for a mix of pathes/URLs we need to move a lot of code from ExternalProject.cmake into ExternalProject-download.cmake. Maybe it is