Re: [cmake-developers] Proposed new CMake module FindITT.cmake

2018-05-29 Thread Sergei Nikulov
ср, 30 мая 2018 г. в 8:38, Gurulev, Dmitry : > Hi Brad, > I'm not a maintainer of SEAPI, so I may only propose a package config for it. And second thing - ITT library itself (not a part of SEAPI) is also used and distributed (ex. w/ Intel's VTune app.) You can propose PR with CMake Package

Re: [cmake-developers] Proposed new CMake module FindITT.cmake

2018-05-29 Thread Gurulev, Dmitry
Hi Brad, I'm not a maintainer of SEAPI, so I may only propose a package config for it. And second thing - ITT library itself (not a part of SEAPI) is also used and distributed (ex. w/ Intel's VTune app.) -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Tuesday,

Re: [cmake-developers] Unit testing CMake modules

2018-05-29 Thread Sam Spilsbury
A little while ago I wrote a framework to do just that: https://github.com/polysquare/cmake-unit I haven't maintained it in a few years, but it works exactly the way you would expect it to (the syntax is a bit different though). On Wed, May 30, 2018 at 12:36 AM, Wouter Klouwen wrote: > Hi

Re: [cmake-developers] Unit testing CMake modules

2018-05-29 Thread Stuermer, Michael SP/HZA-ZSEP
Hello Wouter, testing CMake code is indeed very important. This is why kitware does it as well. Did you check the CMake code testing infrastructure in "Tests/RunCMake" in the sources? It is a very flexible concept which makes adding tests easy enough for everyone contribute (IMO). At the

Re: [cmake-developers] How to handle dependencies of protobuf files ?

2018-05-29 Thread Alexander Neundorf
Hi, On 2018 M05 29, Tue 09:52:16 CEST Brad King wrote: > On 05/15/2018 03:45 PM, Alexander Neundorf wrote: > > I think to do it properly, there would have to be a dependency scanning > > for > > proto files like there is for C/C++ headers. > > In order to handle implicit dependencies like that

[cmake-developers] Unit testing CMake modules

2018-05-29 Thread Wouter Klouwen
Hi all, We have a rather large amount of CMake code (4k+ lines) in various modules/functions. They contain the common logic for many of our projects. This makes it quite an important base for everything our team does. Rather shamefully at present these modules are rather poorly tested. I'd like

Re: [cmake-developers] Proposed new CMake module FindITT.cmake

2018-05-29 Thread Brad King
On 05/29/2018 10:30 AM, Gurulev, Dmitry wrote: > Although IntelSEAPI (which contains ITT sources) is a CMake based > library, ITT itself might be used as standalone binary library, so > finding module still makes sense If the upstream is CMake-friendly it should provide a CMake Package

[cmake-developers] Proposed new CMake module FindITT.cmake

2018-05-29 Thread Gurulev, Dmitry
Hi All, I'd like to maintain new finding module for ITT (Instrumentation and Tracing Technology) library. You may find more details about ITT at https://github.com/intel/IntelSEAPI/wiki or at https://software.intel.com/en-us/node/544195. Please let me know if I need to provide more details.

Re: [cmake-developers] How to handle dependencies of protobuf files ?

2018-05-29 Thread Brad King
On 05/15/2018 03:45 PM, Alexander Neundorf wrote: > I think to do it properly, there would have to be a dependency scanning for > proto files like there is for C/C++ headers. In order to handle implicit dependencies like that implied by import "MyBase.proto"; then they would somehow need

Re: [cmake-developers] Error handling in dashboard scripts

2018-05-29 Thread Brad King
On 05/25/2018 04:27 PM, Kyle Edwards wrote: > ctest_start() > ctest_configure() > ctest_build() > ctest_test() > ctest_submit() > > What happens if ctest_configure() fails (for example, because CMake > failed to find a needed library)? Does the entire script stop right > there? Or does it