Re: [cmake-developers] CMake removes /DEF: option in CMAKE_SHARED_LINKER_FLAGS

2019-11-08 Thread Brad King via cmake-developers
On 11/8/19 5:17 AM, Alexander wrote: > /DEF:"E:/workspace/cmake_test_option/tesseract/bin/libtesseract.dir/Release/exports.def" > is added by CMake automatically and I cannot control it (CMake first creates > a file > objects.txt and then exports.def from it). That behavior is not default, but

Re: [cmake-developers] CMake removes /DEF: option in CMAKE_SHARED_LINKER_FLAGS

2019-11-05 Thread Brad King via cmake-developers
On 11/5/19 7:30 AM, Alexander wrote: > string(APPEND CMAKE_SHARED_LINKER_FLAGS " -DEF:\"foo_1.def\" > -DEF111:\"foo_1.def\"") This was the first you've mentioned using more than one copy of the flag. I tested with this: ``` string(APPEND CMAKE_SHARED_LINKER_FLAGS "

Re: [cmake-developers] These two generator expressions should be equivalent, but one working while the other not working. Bug?

2019-10-24 Thread Brad King via cmake-developers
On 10/24/19 12:18 AM, Alan W. Irwin wrote: > $ > >Expression did not evaluate to a known generator expression The `*_COMPILER_ID` generator expressions are a hard-coded set corresponding to the languages supported by upstream CMake: * C_COMPILER_ID * CXX_COMPILER_ID * CUDA_COMPILER_ID

Re: [cmake-developers] CTest load balancing

2019-10-16 Thread Brad King via cmake-developers
On 10/16/19 10:05 AM, Wouter Klouwen wrote: > Is the intent for CTest to specifically manage CPU load or system load > overall? I don't think a careful distinction was made at the time. If Linux needs some updates to be consistent with other platforms then that would be fine with me. -Brad --

Re: [cmake-developers] CMake removes /DEF: option in CMAKE_SHARED_LINKER_FLAGS

2019-10-09 Thread Brad King via cmake-developers
On 10/9/19 6:04 PM, Alexander wrote: > it deliberately ignores /DEF: which makes impossible to add /DEF: this easy > (and for me preferable) way. The code ``` string(APPEND CMAKE_SHARED_LINKER_FLAGS " -DEF:\"${CMAKE_CURRENT_SOURCE_DIR}/foo.def\"") ``` works fine for me. So does this: ```

Re: [cmake-developers] CMake removes /DEF: option in CMAKE_SHARED_LINKER_FLAGS

2019-10-08 Thread Brad King via cmake-developers
On 10/8/19 8:10 AM, Alexander wrote: > I found that CMake ignores /DEF: option in CMAKE_SHARED_LINKER_FLAGS. > I would like to know if this is an expected behaviour or a bug. A module definition file can be passed as a normal source file and CMake will automatically add `/DEF:...` to the link

Re: [cmake-developers] Revitalize --find-package mode?

2019-10-02 Thread Brad King via cmake-developers
On 10/2/19 9:24 AM, Nagy-Egri Máté Ferenc via cmake-developers wrote: > to obtain dependency information is no longer maintained in CMake, > or at least discouraged for new projects. For reference, the `cmake --find-package` mode documentation you mentioned is here: *

Re: [cmake-developers] Possible feature request concerning conditional linking support by generator expressions

2019-09-26 Thread Brad King via cmake-developers
On 9/24/19 5:02 PM, Alan W. Irwin wrote: > I. Possible feature request > > After reading through the generator-expression documentation at > > it appears for my use case (see below) I need generator expressions of >

Re: [cmake-developers] EXCLUDE_FROM_ALL behavior change

2019-09-24 Thread Brad King via cmake-developers
On 9/24/19 8:12 AM, Charles Huet wrote: > in CMake 3.14 the EXCLUDE_FROM_ALL option of add_subdirectory had a behavior > change. > We are negatively impacted by this change, as we are in the same exact > scenario as > this user: https://cmake.org/pipermail/cmake/2019-September/069978.html

Re: [cmake-developers] Proposal: Using smart pointers to own dynamically allocated memory

2019-09-13 Thread Brad King via cmake-developers
On 9/13/19 1:30 PM, Tushar Maheshwari wrote: > Thanks for the quick response. > I have my commits separated by file groups. I'll open small MRs > collecting the related groups. Thanks. Please just keep a couple MRs open at a time so we don't overwhelm the CI builders. After some are merged you

Re: [cmake-developers] Proposal: Using smart pointers to own dynamically allocated memory

2019-09-13 Thread Brad King via cmake-developers
On 9/13/19 12:58 PM, Kyle Edwards via cmake-developers wrote: > On Fri, 2019-09-13 at 22:08 +0530, Tushar Maheshwari wrote: >> I have pushed some sample commits to >> https://gitlab.kitware.com/tusharpm/cmake/commits/smart_mem. >> >> If this is something I can pursue, I would appreciate a review

Re: [cmake-developers] escape double quote in generated file

2019-08-30 Thread Brad King via cmake-developers
On 8/30/19 10:36 AM, Eugene Karpov wrote: > use it later for precompiled header generation. FYI, CMake 3.16 will have first-class support for PCH: https://gitlab.kitware.com/cmake/cmake/merge_requests/3553 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the

Re: [cmake-developers] No more emails from gitlab.kitware.com

2019-04-15 Thread Brad King via cmake-developers
On 4/15/19 3:56 AM, Sebastian Holtermann wrote: > after changing my account (@sebholt) password in gitlab.kitware.com, I > don't get any emails from it anymore. Login and everything web based > works, but no emails. Did something change there? Verify that your email address is still as

Re: [cmake-developers] Pushing to gitlab.kitware.org from behind a ssl proxy

2019-03-29 Thread Brad King via cmake-developers
On 3/29/19 8:51 AM, Stuermer, Michael SP/HZA-ZSEP wrote: > - pushing to kitware without 2FA fails > - pushing to kitware with 2FA fails Try using gitlab's own deployment on "gitlab.com". If that works then we can investigate differences. -Brad -- Powered by www.kitware.com Please keep

Re: [cmake-developers] Source code ///! comments

2019-03-26 Thread Brad King via cmake-developers
On 3/26/19 8:28 AM, Sebastian Holtermann wrote: > Looking through the source code I found various comments > starting with "///!" > If Doxygen is targeted, the comment should start with either "///" or > "//!". It's likely a typo. For reference, I personally prefer `/** */`. -Brad -- Powered

Re: [cmake-developers] Trojan in latest release

2019-03-22 Thread Brad King via cmake-developers
On 3/22/19 9:56 AM, Brad King wrote: > > https://github.com/Kitware/CMake/releases/download/v3.14.0/cmake-3.14.0-win64-x64.zip > > and uploaded just `bin/cmake.exe` to virustotal.com: it does claim > that `Trojan:Win32/Skeeyah.I` appears: > > This is almost certainly a false positive. I've

Re: [cmake-developers] Trojan in latest release

2019-03-22 Thread Brad King via cmake-developers
On 3/21/19 12:21 PM, Cristian Adam wrote: > Also worth mentioning that Virustotal has nothing on both 32 and 64 bit files: I extracted https://github.com/Kitware/CMake/releases/download/v3.14.0/cmake-3.14.0-win64-x64.zip and uploaded just `bin/cmake.exe` to virustotal.com: it does claim that

Re: [cmake-developers] cmake server to cmake file api swicth

2019-03-21 Thread Brad King via cmake-developers
On 3/21/19 2:19 PM, Eric Noulard wrote: > Can any CMake developer that has been participating in this new > file api shed some light on the rational of this foreseen switch? > I'm just curious about it. What was wrong/problematic with server mode? > Does the new file api solves some IDE

Re: [cmake-developers] Trojan in latest release

2019-03-21 Thread Brad King via cmake-developers
On 3/21/19 2:01 PM, kevin wrote: > I have not actually seen the file, because windows defender is > preventing the download from completing. I just tried using MS Edge on an up-to-date Win 10 Pro with Windows Defender enabled. It is able to download and scan the file, and finds nothing. -Brad

Re: [cmake-developers] Trojan in latest release

2019-03-21 Thread Brad King via cmake-developers
On 3/21/19 12:31 PM, kevin wrote: > Linked from https://camel.org/download I'll assume you meant `cmake.org` there. > Platform->windows win64-x64 installer: ... That would be https://github.com/Kitware/CMake/releases/download/v3.14.0/cmake-3.14.0-win64-x64.msi I downloaded it and got a

Re: [cmake-developers] signing Windows binaries

2019-03-21 Thread Brad King via cmake-developers
On 3/21/19 12:21 PM, Cristian Adam wrote: > I think it would be great if Kitware would buy an authenticode > certificate to sign the Windows builds. Is there a bug report on this? I don't recall if there is an open issue but we are aware that the Windows binaries could be signed and are not. We

Re: [cmake-developers] Trojan in latest release

2019-03-21 Thread Brad King via cmake-developers
On 3/21/19 12:05 PM, kevin wrote: > I just tried to install the latest release and noticed it contained Skeeyah.l What is the URL of the binary you downloaded? What is the sha256 sum of the installer file on your local disk? -Brad -- Powered by www.kitware.com Please keep messages on-topic

Re: [cmake-developers] [CDT] Improving CDT4 generator

2019-03-21 Thread Brad King via cmake-developers
On 3/20/19 5:20 PM, Alexander Neundorf wrote: > On 2019 M03 20, Wed 13:53:49 CET Brad King wrote: >> CMake's new file-api: >> >> https://cmake.org/cmake/help/v3.14/manual/cmake-file-api.7.html >> >> That is now the intended way for third-party IDEs to display CMake projects. > > so this is now

Re: [cmake-developers] execute_process: how to detect TIMEOUT

2019-03-20 Thread Brad King via cmake-developers
On 3/20/19 11:53 AM, Joachim Wuttke wrote: > The command execute_process has an option TIMEOUT. > This option would be even more useful if one > would notice when a timeout happened. > Is there a way to tell from any of the outcome > variables whether the process ran into timeout? The

Re: [cmake-developers] [CDT] Improving CDT4 generator

2019-03-20 Thread Brad King via cmake-developers
On 3/19/19 4:57 PM, David wrote: > since Eclipse 9.2 (or 9.1 do not remember), the CMake CDT4 Generator > does not work as expected for C++ Project. > > What is the best way to propose an update ? Please see contribution instructions here:

Re: [cmake-developers] different behavior of cmake_minimum_required(3.0) and 3.1

2019-03-19 Thread Brad King via cmake-developers
On 3/19/19 11:57 AM, Rolf Eike Beer wrote: > It has nothing to do with either the policies or the order of > cmake_minimum_required() and project(). Okay. My order comment was a side note and should be corrected either way. > If I require version 3.0 it works, with 3.1 it fails. See this code

Re: [cmake-developers] Pushing to gitlab.kitware.org from behind a ssl proxy

2019-03-19 Thread Brad King via cmake-developers
On 3/19/19 2:21 AM, Stuermer, Michael SP/HZA-ZSEP wrote: > remote: HTTP Basic: Access denied > fatal: Authentication failed for > 'https://gitlab.kitware.com//cmake.git/' Try creating a personal access token to use during auth instead: *

Re: [cmake-developers] different behavior of cmake_minimum_required(3.0) and 3.1

2019-03-18 Thread Brad King via cmake-developers
On 3/15/19 6:10 PM, Rolf Eike Beer wrote: > I suspected it was a policy thing, so I tried this: > > foreach(_p RANGE 21 54) >cmake_policy(SET CMP00${_p} OLD) > endforeach() Only policies 51-54 were added between 3.0 and 3.1. I suggest testing with cmake_minimum_required(VERSION

Re: [cmake-developers] Exporting an imported target not supported?

2019-03-12 Thread Brad King via cmake-developers
On 3/12/19 9:55 AM, Lassi Niemistö wrote: > is there a technical reason why it would not be a good idea to > allow exporting the imported targets with all their properties? We have not thought deeply through the semantics of that in general. One of the main challenges is relocation handling.

Re: [cmake-developers] Exporting an imported target not supported?

2019-03-12 Thread Brad King via cmake-developers
On 3/12/19 6:57 AM, Lassi Niemistö wrote: > What to do in order to get rid of the extlib_interface workaround? > I have not yet seen any means of "exporting" the properties of an > imported target to tree2. The file `cmake_test_system_lassi/tree1/Tree1Config.cmake` should have code to re-create

Re: [cmake-developers] Exporting an imported target not supported?

2019-03-11 Thread Brad King via cmake-developers
On 3/11/19 8:50 AM, Lassi Niemistö wrote: > I cannot see any automatic rpath-link generation if I try the above. Should I? Please post a minimal example tarball showing your case in practice. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at:

Re: [cmake-developers] Exporting an imported target not supported?

2019-03-08 Thread Brad King via cmake-developers
On 3/8/19 1:11 AM, Lassi Niemistö wrote: > Am I just missing something and should be able to install the export > of “extlib” without installing the target itself? Any reasoning why > imported targets should not be possible to export? Any other solution > ideas for passing the custom link dir of

Re: [cmake-developers] Properly Documenting a CMake Module

2019-02-13 Thread Brad King via cmake-developers
On 2/12/19 6:37 PM, Timothy Wrona wrote: > a way to document custom CMake modules so that they work with the > "cmake --help-module " command There is no way to do this. The only reason --help-module exists at all is because prior to 3.0 the documentation was generated by the CMake binary itself,

Re: [cmake-developers] [PATCH] Help: Fix elseif/endif contradictions

2019-02-11 Thread Brad King via cmake-developers
On 2/11/19 2:06 PM, Juuso Linda Lapinlampi via cmake-developers wrote: > -Per legacy, the :command:`else` and :command:`elseif` commands admit > +Per legacy, the :command:`else` and :command:`endif` commands admit Thanks, applied here: https://gitlab.kitware.com/cmake/cmake/merge_requests/2950

Re: [cmake-developers] Shared library under Windows and CMake: DLL not found before installation

2019-02-06 Thread Brad King via cmake-developers
On 2/6/19 2:40 PM, Joachim Wuttke wrote: > And combine it with > > ``` > link_directories(BEFORE ${PROJECT_BINARY_DIR}/bin) > ``` > > so that tests find the libraries? No. CMAKE_RUNTIME_OUTPUT_DIRECTORY only affects the locations of the .dll files, not .a/.so/.lib. Also CMake already knows

Re: [cmake-developers] Shared library under Windows and CMake: DLL not found before installation

2019-02-06 Thread Brad King via cmake-developers
On 2/6/19 1:46 PM, Joachim Wuttke wrote: > What is the minimally invasive adjustment > to make the above build steps work under Windows? Windows has no RPATH to help executables locate their shared libraries. The simplest solution is to put the .exe and .dll files in the same directory (which

Re: [cmake-developers] CMake "find_package" command on a package that is not installed is unexpectedly successful

2019-02-05 Thread Brad King via cmake-developers
On 2/5/19 2:37 PM, Timothy Wrona wrote: > Can anyone explain to me how "find_package" is able to find the Eigen > libraries > even though they are just pasted into some arbitrary location that I never > told > the example project about? Eigen uses the CMake package registry feature:

Re: [cmake-developers] CMAKE_HOME_DIRECTORY vs CMAKE_SOURCE_DIR

2019-01-29 Thread Brad King via cmake-developers
On 1/29/19 5:37 AM, Joachim Wuttke wrote: > how do these two relate to each other? Their value is the same, but CMAKE_SOURCE_DIR is a normal CMake variable intended for use by projects. CMAKE_HOME_DIRECTORY is an internal cache entry used to locate the source directory when loading a

Re: [cmake-developers] $LIST_LENGTH{} syntax

2019-01-22 Thread Brad King via cmake-developers
On 1/22/19 1:31 PM, tors...@robitzki.de wrote: > Currently, the Code that evaluates the ${}-Syntax only evaluates the key > > const char* cmCommandArgumentParserHelper::ExpandSpecialVariable( That's the pre-CMP0053 impl. See cmMakefile::ExpandVariablesInStringNew for the modern impl. Only with

Re: [cmake-developers] $LIST_LENGTH{} syntax

2019-01-22 Thread Brad King via cmake-developers
On 1/22/19 10:55 AM, Marc CHEVRIER wrote: > What about introducing a syntax similar to the version comparison: > > * LENGTH_EQUAL > * LENGTH_GREATER > * LENGTH_LOWER > * etc… > > To use it: > if (my_list LENGTH_EQUAL 1) >   # do my stuff > endif() That's where this thread started.

Re: [cmake-developers] real functions (was: $LIST_LENGTH{} syntax)

2019-01-22 Thread Brad King via cmake-developers
On 1/22/19 10:28 AM, tors...@robitzki.de wrote: > With `$CACHE{VAR}` and `$ENV{VAR}` we already have the syntax for calling a > „function“. No, there is no obvious way to pass arguments, handle nested quoting, etc. The language was not designed for that. That is a big can of worms I'd rather

Re: [cmake-developers] $LIST_LENGTH{} syntax (was: Support for list length expression in if()-command?)

2019-01-22 Thread Brad King via cmake-developers
On 1/22/19 7:40 AM, Daniel Franke wrote: > Whats about a Syntax like > > ${list::LENGTH} That would require dispatch after matching `${VAR}` syntax, and that lookup is one of the hottest paths according to profiling. We already have $ENV{} and $CACHE{} syntax. -Brad -- Powered by

Re: [cmake-developers] $LIST_LENGTH{} syntax (was: Support for list length expression in if()-command?)

2019-01-22 Thread Brad King via cmake-developers
On 1/22/19 7:09 AM, tors...@robitzki.de wrote: >> Am 22.01.2019 um 12:42 schrieb Brad King: >> Rather than a special `if` syntax, perhaps we could introduce an >> explicit `$LIST_LENGTH{mylist}` syntax. One would need to experiment >> to see if modifying the variable expansion parser (under

Re: [cmake-developers] Support for list length expression in if()-command?

2019-01-22 Thread Brad King via cmake-developers
On 1/22/19 3:08 AM, tors...@robitzki.de wrote: > three use cases: > > - Checking for empty lists (I’ve showed him that this can be done > by a string compare). > - Checking for lists having more than 1 entry > - Checking for equal size of two lists. For example, if you want > to pass pairs or

Re: [cmake-developers] Support for list length expression in if()-command?

2019-01-14 Thread Brad King via cmake-developers
On 1/14/19 4:21 AM, Torsten Robitzki wrote: > if (LENGTH list GREATER 1) An investigation will be needed to determine whether a policy is needed to add this to the if() command to avoid possible behavior changes for existing callers. For reference, you asked this previously:

Re: [cmake-developers] BISON_TARGET doesn't use CMAKE_CURRENT_BINARY_DIR as WORKING_DIRECTORY

2019-01-08 Thread Brad King via cmake-developers
On 1/8/19 6:44 AM, Brad King wrote: > On 12/25/18 1:17 AM, Mingjie Xing wrote: >> The BISON_TARGET will run bison command in CMAKE_CURRENT_SOURCE_DIR. >> >> So I just wonder whither it is better for BISON_TARGET to use >> CMAKE_CURRENT_BINARY_DIR as WORKING_DIRECTORY. > > Unfortunately this went

Re: [cmake-developers] BISON_TARGET doesn't use CMAKE_CURRENT_BINARY_DIR as WORKING_DIRECTORY

2019-01-08 Thread Brad King via cmake-developers
On 12/25/18 1:17 AM, Mingjie Xing wrote: > The BISON_TARGET will run bison command in CMAKE_CURRENT_SOURCE_DIR. > > So I just wonder whither it is better for BISON_TARGET to use > CMAKE_CURRENT_BINARY_DIR as WORKING_DIRECTORY. Unfortunately this went unnoticed for years after the module was

Re: [cmake-developers] Test for list size

2018-12-12 Thread Brad King via cmake-developers
On 12/12/18 7:01 AM, Torsten Robitzki wrote: > we have often the need to test for a minimum list size > > list(LENGTH list list_size) > if (list_size GREATER 1) > > This happens so much I've almost never needed to test the length of a list. What are you trying to do? -Brad -- Powered by

Re: [cmake-developers] Slowdown of nightly builds

2018-12-12 Thread Brad King via cmake-developers
On 12/12/18 7:15 AM, Rolf Eike Beer wrote: > I noticed that for a few weeks the builds on my machines now take much longer > to complete, without any particular change in my setup. > The change in the dashboard can be seen on the dashboard between > 2018-11-09 and 2018-11-10. Thanks! I had

Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

2018-12-10 Thread Brad King via cmake-developers
On 12/9/18 8:09 AM, Marc CHEVRIER wrote: > The real question is how to manage cleanly target specific flags > overriding global or directory defaults? All the optimization and warning flags currently handled by `CMAKE__FLAGS[_]` need to have abstractions introduced (e.g. target properties or

Re: [cmake-developers] A dashboard that reveals a ctest issue on Windows when there are no tests

2018-12-06 Thread Brad King via cmake-developers
On 12/5/18 5:01 PM, Alan W. Irwin wrote: > But I still don't understand exactly how ctest is run from cmake. Assuming > the > "test" target (which I have never tried) runs the "all" target and then ctest, > I guess > > cmake --build . --config Debug --target test > > would run ctest indirectly

Re: [cmake-developers] A dashboard that reveals a ctest issue on Windows when there are no tests

2018-12-05 Thread Brad King via cmake-developers
On 12/4/18 4:08 PM, Alan W. Irwin wrote: > Build Warnings (1) > > *** WARNING non-zero return value in ctest from: > C:\cmake-3.13.1-win64-x64\bin\cmake.exe That's in the "Build" section and indicates that the build command exited with non-zero status. If you want to try to reproduce that by