Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

ult because it hurts CMake as a whole. Cheers,Máté -Original Message- From: Mateusz Loskot To: marc.chevrier Cc: cmake-developers ; cmake Sent: Sun, Dec 9, 2018 2:55 pm Subject: Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug On Sun, 9 Dec 2018 at 14:09

Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

On 12/9/18 8:09 AM, Marc CHEVRIER wrote: > The real question is how to manage cleanly target specific flags > overriding global or directory defaults? All the optimization and warning flags currently handled by `CMAKE__FLAGS[_]` need to have abstractions introduced (e.g. target properties or

Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

Cmake is already full of do much hardcoded logic / flags and does new releases so frequently (maybe there's some correlation between these two) that adding this would hardly impact upon its quality or maintainability. So to that end, hardcoding the default per msvc version so that it's not added

Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

On Sun, 9 Dec 2018 at 14:09, Marc CHEVRIER wrote: > > I think the discussion is shifting from the initial problem which was > unwanted warning « Command line warning D9025: overriding '/W3' with '/W4' ». I disagree with your opinion. Fixing just the warning would be a symptomatic treatment. >

Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

On Sun, 9 Dec 2018 at 12:14, Craig Scott wrote: > > From what I understand from a very limited quick search just now, > it seems that /W3 is the default warning level for Visual Studio Yes, it is the default level indeed. > but CMake explicitly adds it as a default compiler flag in >

Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

>From what I understand from a very limited quick search just now, it seems that /W3 is the default warning level for Visual Studio (according to the Microsoft docs ), but CMake explicitly adds it