On Fri, Apr 01, 2016 at 10:58:50 +0100, Samir Benmendil wrote:
> +# set git_options
> +if(NOT tls_verify)
> +  set(git_options -c http.sslVerify=false)
> +endif()

Looks good overall, but could this be turned into a pattern like:

    set(git_options)
    if (NOT tls_verify)
      list(APPEND git_options
        -c http.sslVerify=false)
    endif ()

to help out future options which might make sense?

Thanks,

--Ben
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to