Re: [cmake-developers] [PATCH] Fixed Borland linker issue when used with Ninja generator

2015-06-18 Thread Brad King
On 06/18/2015 01:41 PM, James Johnston wrote: 3. Patch Windows-Embarcadero.cmake, as I propose here. I think that makes sense. +set(CMAKE_JOB_POOL_LINK BCC32LinkPool) Hmm. What if the user sets this too? Perhaps we should allow users/projects to take control of this setting by making the

Re: [cmake-developers] [PATCH] Fixed Borland linker issue when used with Ninja generator

2015-06-18 Thread James Johnston
See updated attached patch. I've retested it to ensure the VTK 5.4.2 build I've been working with still builds correctly - and it still does. Thank you for considering it. -James -Original Message- From: Brad King [mailto:brad.k...@kitware.com] +set(CMAKE_JOB_POOL_LINK

[cmake-developers] [PATCH] Fixed Borland linker issue when used with Ninja generator

2015-06-18 Thread James Johnston
Hi, The attached patch is in regards to issue #15620 in mantis bug tracker (Ninja generator triggers race condition in Borland bcc32 linker causing intermittent build failure). Thanks to Brad King's suggestion, I think using job pools is a lot easier than trying my proposed workaround (which I

Re: [cmake-developers] [PATCH] Fixed Borland linker issue when used with Ninja generator

2015-06-18 Thread Brad King
On 06/18/2015 03:05 PM, James Johnston wrote: See updated attached patch. Thanks, applied: Embarcadero: Run at most one linker invocation at a time http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=078b60f0 I moved most of the explanation from comments to the commit message and left a