Re: [cmake-developers] [PATCH] Imported targets for FindGTest

2015-12-11 Thread Brad King
On 12/10/2015 07:22 PM, rle...@codelibre.net wrote: >> - Add unit test to test imported targets and existing variables > > I should mention that to run the unit test, you must define the GTEST_ROOT > environment variable to point to the gtest build, due to gtest being > annoyingly crippled to be

Re: [cmake-developers] [PATCH] Imported targets for FindGTest

2015-12-10 Thread rleigh
> - Add unit test to test imported targets and existing variables I should mention that to run the unit test, you must define the GTEST_ROOT environment variable to point to the gtest build, due to gtest being annoyingly crippled to be uninstallable for dubious reasons. You can pass

Re: [cmake-developers] [PATCH] Imported targets for FindGTest

2015-12-10 Thread rleigh
> - Adds GTest::GTest and GTest::Main imported targets (including > Thread::Thread dependency for GTest::GTest and GTest::GTest for > GTest::Main; the latter might not be appropriate and could be removed if > needed--but I'm unaware of any situation where you would want to use > GTest::Main

[cmake-developers] [PATCH] Imported targets for FindGTest

2015-12-10 Thread rleigh
Pushed to https://cmake.org/gitweb?p=stage/cmake.git;a=shortlog;h=refs/heads/gtest- imported-targets and merged into next for review and testing. - Adds GTest::GTest and GTest::Main imported targets (including Thread::Thread dependency for GTest::GTest and GTest::GTest for GTest::Main; the