Re: [cmake-developers] [PATCH] Let CMake know that clang uses the GCC toolchain.

Makes sense. Thank you. On Thu, Aug 4, 2016 at 6:53 AM, Brad King wrote: > On 08/03/2016 03:22 PM, Chaoren Lin wrote: > >> It will take some investigation to decide how/whether to set SIMULATE_ID > >> to GNU. > > > > This seems like the right thing to do, and is more

Re: [cmake-developers] [PATCH] Let CMake know that clang uses the GCC toolchain.

On 08/03/2016 03:22 PM, Chaoren Lin wrote: >> It will take some investigation to decide how/whether to set SIMULATE_ID >> to GNU. > > This seems like the right thing to do, and is more future proof than the > alternative. This patch may do it. ```patch diff --git

Re: [cmake-developers] [PATCH] Let CMake know that clang uses the GCC toolchain.

> It will take some investigation to decide how/whether to set SIMULATE_ID > to GNU. This seems like the right thing to do, and is more future proof than the alternative. On Wed, Aug 3, 2016 at 5:56 AM, Brad King wrote: > On 08/02/2016 06:59 PM, Chaoren Lin wrote: > >>

Re: [cmake-developers] [PATCH] Let CMake know that clang uses the GCC toolchain.

On 08/02/2016 06:59 PM, Chaoren Lin wrote: >> In the gcc-like variant the CMAKE_{C,CXX}_SIMULATE_ID >> should be detected as GNU and cause the existing code to work. > > Huh, it doesn't look like that variable is set automatically when using > clang with the gcc toolchain. Is that supposed to

Re: [cmake-developers] [PATCH] Let CMake know that clang uses the GCC toolchain.

> In the gcc-like variant the CMAKE_{C,CXX}_SIMULATE_ID > should be detected as GNU and cause the existing code to work. Huh, it doesn't look like that variable is set automatically when using clang with the gcc toolchain. Is that supposed to happen? It should be set manually (say, in a toolchain

Re: [cmake-developers] [PATCH] Let CMake know that clang uses the GCC toolchain.

On 07/29/2016 05:44 PM, Chaoren Lin via cmake-developers wrote: > Clang on Windows uses the GCC toolchain, so we need to avoid using > backslashes for paths in response files. [snip] >strcmp(mf->GetSafeDefinition("CMAKE_C_COMPILER_ID"), "GNU") == 0 || >

[cmake-developers] [PATCH] Let CMake know that clang uses the GCC toolchain.

Clang on Windows uses the GCC toolchain, so we need to avoid using backslashes for paths in response files. --- Source/cmGlobalNinjaGenerator.cxx | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Source/cmGlobalNinjaGenerator.cxx b/Source/cmGlobalNinjaGenerator.cxx index