Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-19 Thread Rolf Eike Beer
Am Dienstag, 19. August 2014, 23:29:13 schrieb Roger Leigh: > On Sun, Aug 17, 2014 at 03:43:46PM +0100, Roger Leigh wrote: > > On Sun, Aug 17, 2014 at 03:46:14PM +0200, Rolf Eike Beer wrote: > > > > Sorry for the naïve question, but the find_package docs also mentions > > > > setting package_VERSIO

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-19 Thread Roger Leigh
On Sun, Aug 17, 2014 at 03:43:46PM +0100, Roger Leigh wrote: > On Sun, Aug 17, 2014 at 03:46:14PM +0200, Rolf Eike Beer wrote: > > > Sorry for the naïve question, but the find_package docs also mentions > > > setting package_VERSION_COUNT but I don't see any examples of this in > > > cmake git. Is

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-17 Thread Roger Leigh
On Sun, Aug 17, 2014 at 03:46:14PM +0200, Rolf Eike Beer wrote: > > Sorry for the naïve question, but the find_package docs also mentions > > setting package_VERSION_COUNT but I don't see any examples of this in > > cmake git. Is setting the MAJOR/MINOR/PATCH versions here correct or > > redundant

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-17 Thread Rolf Eike Beer
> Sorry for the naïve question, but the find_package docs also mentions > setting package_VERSION_COUNT but I don't see any examples of this in > cmake git. Is setting the MAJOR/MINOR/PATCH versions here correct or > redundant or plain wrong? Or all handled internally by > FIND_PACKAGE_HANDLE_STA

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-17 Thread Roger Leigh
On Sun, Aug 17, 2014 at 02:28:59PM +0100, Roger Leigh wrote: > On Sun, Aug 17, 2014 at 02:57:36PM +0200, Rolf Eike Beer wrote: > > Roger Leigh wrote: > > > Dear Chuck, > > > > > > Thanks for looking at this. Please find attached a new copy of the > > > patch which should address all your points.

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-17 Thread Roger Leigh
On Sun, Aug 17, 2014 at 02:57:36PM +0200, Rolf Eike Beer wrote: > Roger Leigh wrote: > > Dear Chuck, > > > > Thanks for looking at this. Please find attached a new copy of the > > patch which should address all your points. If you would like any > > further changes making, please just let me kno

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-17 Thread Rolf Eike Beer
Roger Leigh wrote: > Dear Chuck, > > Thanks for looking at this. Please find attached a new copy of the > patch which should address all your points. If you would like any > further changes making, please just let me know. I don't think you need the functions for anything, especially not _Xerc

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-17 Thread Roger Leigh
Dear Chuck, Thanks for looking at this. Please find attached a new copy of the patch which should address all your points. If you would like any further changes making, please just let me know. Regards, Roger On Sat, Aug 16, 2014 at 11:11:42AM -0400, Chuck Atkins wrote: > Hey Roger, thanks for

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-16 Thread Chuck Atkins
Hey Roger, thanks for the contribution! A couple of points on find_module convention, most of which you can find in http://cmake.org/cmake/help/v3.0/manual/cmake-developer.7.html#modules. Not all find modules currently shipped have been updated for these best practices but new modules should try t

[cmake-developers] [PATCH] New module FindXerces

2014-08-16 Thread Roger Leigh
Hi, Attached is a patch to add support for Apache Xerces-C++. This project is quite an old one, and doesn't have any support for cmake at present. This will allow cmake projects to use current and older Xerces releases. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp: