Re: [cmake-developers] [PATCH] add debug glew to FindGLEW

2016-06-21 Thread Brad King
On 06/21/2016 05:33 AM, Farbos a wrote: > I am not sure to understand why you removed GLEW_LIBRARY: > > -mark_as_advanced(GLEW_INCLUDE_DIR GLEW_LIBRARY) > +mark_as_advanced(GLEW_INCLUDE_DIR) We no longer define the GLEW_LIBRARY cache entry ourselves, only read it for legacy reasons, so we are

Re: [cmake-developers] [PATCH] add debug glew to FindGLEW

2016-06-21 Thread Farbos a
I am not sure to understand why you removed GLEW_LIBRARY: -mark_as_advanced(GLEW_INCLUDE_DIR GLEW_LIBRARY) +mark_as_advanced(GLEW_INCLUDE_DIR) 2016-06-20 21:09 GMT+02:00 Brad King : > On 06/20/2016 10:52 AM, Farbos a wrote: >> Here is the patch fixed. > > Thanks, applied:

Re: [cmake-developers] [PATCH] add debug glew to FindGLEW

2016-06-20 Thread Farbos a
Brad, Here is the patch fixed. Thanks, 2016-06-20 16:17 GMT+02:00 Brad King : > On 06/20/2016 07:55 AM, Farbos a wrote: >> I added the Glew debug library to the FindGLEW.cmake, here is the patch. > > Good start. Here are some comments: > > * For compatibility with

Re: [cmake-developers] [PATCH] add debug glew to FindGLEW

2016-06-20 Thread Brad King
On 06/20/2016 07:55 AM, Farbos a wrote: > I added the Glew debug library to the FindGLEW.cmake, here is the patch. Good start. Here are some comments: * For compatibility with scripts that set GLEW_LIBRARY we need to honor the old name if it is set. See FindZLIB for an example. (Near the

[cmake-developers] [PATCH] add debug glew to FindGLEW

2016-06-20 Thread Farbos a
Hi, I added the Glew debug library to the FindGLEW.cmake, here is the patch. Tell me if everything looks good and if I can do a pull request. Thanks, -- Arnaud FARBOS 0001-add-debug-glew-to-FindGLEW.patch Description: Binary data -- Powered by www.kitware.com Please keep messages on-topic