Re: [cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-23 Thread Matthew Woehlke
On 2014-04-18 09:07, Brad King wrote: On 04/18/2014 08:58 AM, Rolf Eike Beer wrote: To forbid whitespace and control characters in variable names can IMHO only be good. Some people use arbitrary variable names as a way to do key/value tables. In such cases it is intentional to use arbitrary

Re: [cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-18 Thread Brad King
On 04/18/2014 03:07 AM, Rolf Eike Beer wrote: what about nuking at least all control characters and whitespace from variable names in 3.1? I don't think that anyone has used them on purpose, and accidentially using them will only cause trouble. If we're going to change this I don't want it

Re: [cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-18 Thread Rolf Eike Beer
Brad King wrote: On 04/18/2014 03:07 AM, Rolf Eike Beer wrote: what about nuking at least all control characters and whitespace from variable names in 3.1? I don't think that anyone has used them on purpose, and accidentially using them will only cause trouble. If we're going to

Re: [cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-18 Thread Ben Boeckel
On Fri, Apr 18, 2014 at 10:06:36 -0400, Matthew Woehlke wrote: Where a variable is created (e.g. the SET command), presumably. Internally-created variables would then be missed. string(TOUPPER mystr varname with spaces) I don't think the performance hit should be so bad if only writes are

Re: [cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-17 Thread Ben Boeckel
On Thu, Apr 17, 2014 at 17:17:21 -0400, Matthew Woehlke wrote: set( Linux Windows) # succeeds Even better: set( Linux Windows) Alas, the only character that may not appear in a variable name is '\0'. (And even that is more due to use of raw char* with no length than intent, I bet.)

Re: [cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-14 Thread David Cole
Hmm.. It is a little bit confusing for newcommers that you can not do simple comparision for text word if some variable with this name exists. Oh, it's confusing and confounding to old-timers, too... :-) -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ

Re: [cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-13 Thread Rolf Eike Beer
Am Sonntag, 13. April 2014, 07:05:27 schrieb Jiri Malak: Hi, I enclosed patch for removing placeholder x from STREQUAL operands. It does comparision transparent. I very much would like to see that, but there is a problem: CMake may interpret the operands of STREQUAL both as text and as

Re: [cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-13 Thread Jiri Malak
I enclosed patch for removing placeholder x from STREQUAL operands. It does comparision transparent. I very much would like to see that, but there is a problem: CMake may interpret the operands of STREQUAL both as text and as variable name. So this does what you expect for the moment: if

Re: [cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-13 Thread Rolf Eike Beer
Am Sonntag, 13. April 2014, 09:59:03 schrieb Jiri Malak: I enclosed patch for removing placeholder x from STREQUAL operands. It does comparision transparent. I very much would like to see that, but there is a problem: CMake may interpret the operands of STREQUAL both as text and as

Re: [cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-13 Thread Jiri Malak
Am Sonntag, 13. April 2014, 09:59:03 schrieb Jiri Malak: I enclosed patch for removing placeholder x from STREQUAL operands. It does comparision transparent. I very much would like to see that, but there is a problem: CMake may interpret the operands of STREQUAL both as text and as

[cmake-developers] [PATCH] remove x placeholder from STREQUAL operands

2014-04-12 Thread Jiri Malak
Hi, I enclosed patch for removing placeholder x from STREQUAL operands. It does comparision transparent. Regards JiriFrom e2a1f5490002c3479a1e637ae584d7c23a08561d Mon Sep 17 00:00:00 2001 From: Jiri Malak malak.j...@gmail.com Date: Sun, 13 Apr 2014 06:55:17 +0200 Subject: [PATCH] remove x