Re: [cmake-developers] [PATCH v3] FindHDF5.cmake HDF5_VERSION Support

2015-05-19 Thread Rolf Eike Beer
Huebl, Axel wrote: > I personally also tend to the cropped "HDF5_VERSION" for consistency and > ease-of-use in environments using stable versions of HDF5 (most > distributions). > > That doesn't mean we could not provide and *additional* > "HDF5_VERSION_STRING". > For sake of consistency, I am no

Re: [cmake-developers] [PATCH v3] FindHDF5.cmake HDF5_VERSION Support

2015-05-17 Thread Huebl, Axel
On 13.05.2015 16:04, Brad King wrote: > On 05/13/2015 08:20 AM, Brad King wrote: >> We could also consider moving the ".*" inside the match group >> and then reporting the result in HDF5_VERSION_STRING instead >> of HDF5_VERSION. > > OTOH, HDF5 upstream distributes a CMake package configuration >

Re: [cmake-developers] [PATCH v3] FindHDF5.cmake HDF5_VERSION Support

2015-05-13 Thread Brad King
On 05/13/2015 08:20 AM, Brad King wrote: > We could also consider moving the ".*" inside the match group > and then reporting the result in HDF5_VERSION_STRING instead > of HDF5_VERSION. OTOH, HDF5 upstream distributes a CMake package configuration file allowing one to set HDF5_DIR. In this case

Re: [cmake-developers] [PATCH v3] FindHDF5.cmake HDF5_VERSION Support

2015-05-13 Thread Brad King
On 05/13/2015 02:58 AM, Huebl, Axel wrote: > Thanks for merging and adding the test, that is great. Thanks for working on the patch. On 05/11/2015 07:32 AM, Huebl, Axel wrote: > I would simply use > > if( "${HDF5_VERSION_DEFINE}" MATCHES > "H5_VERSION[ \t]+\"([0-9]+\\.[0-9]+\\.[

Re: [cmake-developers] [PATCH v3] FindHDF5.cmake HDF5_VERSION Support

2015-05-12 Thread Huebl, Axel
On 12.05.2015 16:06, Brad King wrote: > On 05/12/2015 09:58 AM, Brad King wrote: >> Thanks. Applied with minor tweaks to the commit message plus >> a test suite update: >> >> FindHDF5: Add version support >> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c1150734 > > I revised the copyright

Re: [cmake-developers] [PATCH v3] FindHDF5.cmake HDF5_VERSION Support

2015-05-12 Thread Brad King
On 05/12/2015 09:58 AM, Brad King wrote: > Thanks. Applied with minor tweaks to the commit message plus > a test suite update: > > FindHDF5: Add version support > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c1150734 I revised the copyright block to fix the ModuleNotices test: FindHDF5

Re: [cmake-developers] [PATCH v3] FindHDF5.cmake HDF5_VERSION Support

2015-05-12 Thread Brad King
On 05/11/2015 09:22 AM, Huebl, Axel wrote: > This commit adds VERSION support for HDF5 from > the same sources as it adds the HDF5_IS_PARALLEL > flag. Thanks. Applied with minor tweaks to the commit message plus a test suite update: FindHDF5: Add version support http://cmake.org/gitweb?p=cmake

Re: [cmake-developers] [PATCH v3] FindHDF5.cmake HDF5_VERSION Support

2015-05-11 Thread Huebl, Axel
This commit adds VERSION support for HDF5 from the same sources as it adds the HDF5_IS_PARALLEL flag. Previously posted on https://github.com/Kitware/CMake/pull/153 and improved with feedback from - Brad King - Rolf Eike Beer --- Modules/FindHDF5.cmake | 19 --- 1 file chang