Re: [cmake-developers] 3.9.0-rc3: CMAKE_ANDROID_NDK_DEPRECATED_HEADERS doesn't work outside of toolchain

2017-07-11 Thread Robert Dailey
Just wanted to share my solution to this, based on your suggestions about code sharing. I still do some introspection but some of this is based on our usage of environment variables and such. However the logic to find NDK version is useful in general. Instead of pasting the CMake code here, I

Re: [cmake-developers] 3.9.0-rc3: CMAKE_ANDROID_NDK_DEPRECATED_HEADERS doesn't work outside of toolchain

2017-06-27 Thread Brad King
On 06/27/2017 11:36 AM, Robert Dailey wrote: > Ok maybe I'm misunderstanding the design intent for toolchain files. Originally they were intended to contain information local to the machine, like `set(CMAKE_ANDROID_NDK /path/on/my/machine/to/ndk)`. In controlled environments that share many

Re: [cmake-developers] 3.9.0-rc3: CMAKE_ANDROID_NDK_DEPRECATED_HEADERS doesn't work outside of toolchain

2017-06-27 Thread Robert Dailey
On Tue, Jun 27, 2017 at 10:22 AM, Brad King wrote: > On 06/27/2017 11:14 AM, Robert Dailey wrote: >> Also at $DAYJOB, we all work on the same code base. Our product is >> tested and verified to work on a distinct set of configurations. Why >> would I ask each user to create

Re: [cmake-developers] 3.9.0-rc3: CMAKE_ANDROID_NDK_DEPRECATED_HEADERS doesn't work outside of toolchain

2017-06-27 Thread Brad King
On 06/27/2017 11:14 AM, Robert Dailey wrote: > Also at $DAYJOB, we all work on the same code base. Our product is > tested and verified to work on a distinct set of configurations. Why > would I ask each user to create their own toolchain file? If you have a toolchain file that works in some

Re: [cmake-developers] 3.9.0-rc3: CMAKE_ANDROID_NDK_DEPRECATED_HEADERS doesn't work outside of toolchain

2017-06-27 Thread Robert Dailey
On Mon, Jun 26, 2017 at 3:32 PM, Brad King wrote: > On 06/26/2017 11:58 AM, Robert Dailey wrote: >> Why does this only work in the toolchain file? > > 1. It needs to be set early. > > 2. It needs to propagate into try_compile projects. > > The toolchain file is sufficient

Re: [cmake-developers] 3.9.0-rc3: CMAKE_ANDROID_NDK_DEPRECATED_HEADERS doesn't work outside of toolchain

2017-06-26 Thread Brad King
On 06/26/2017 11:58 AM, Robert Dailey wrote: > Why does this only work in the toolchain file? 1. It needs to be set early. 2. It needs to propagate into try_compile projects. The toolchain file is sufficient for both. A cache entry is okay for (1) but for (2) one would additionally need to set

[cmake-developers] 3.9.0-rc3: CMAKE_ANDROID_NDK_DEPRECATED_HEADERS doesn't work outside of toolchain

2017-06-26 Thread Robert Dailey
Hi, I tried setting CMAKE_ANDROID_NDK_DEPRECATED_HEADERS in a common CMake script of mine (set during configuration but before any targets are created). I also tried making it a cache variable, but in each case it isn't working. I set like this: set( CMAKE_ANDROID_NDK_DEPRECATED_HEADERS 1 ) And