Re: [cmake-developers] CMakeForceCompiler

2015-10-19 Thread Brad King
On 10/19/2015 10:46 AM, Brad King wrote: > CMakeForceCompiler: Deprecate this module and its macros > https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5908dcb6 After fixing a typo in the commit message: CMakeForceCompiler: Deprecate this module and its macros

Re: [cmake-developers] CMakeForceCompiler

2015-10-19 Thread Brad King
On 09/22/2015 04:39 PM, Brad King wrote: > I think it should be deprecated if possible. First we must > provide alternatives for all its use cases though. I'm not familiar with any cases that cannot be supported in other ways so I decided to deprecate the module now: CMakeForceCompiler:

Re: [cmake-developers] CMakeForceCompiler

2015-10-19 Thread Brad King
On 10/19/2015 10:46 AM, Brad King wrote: > This will at least call attention to the problems with this > module and hopefully bring to light any remaining use cases > that require it. For reference, an additional problem is discussed here: https://cmake.org/Bug/view.php?id=15797#c39641 The

Re: [cmake-developers] CMakeForceCompiler

2015-10-19 Thread Stephen Kelly
Brad King wrote: > On 10/19/2015 10:46 AM, Brad King wrote: >> CMakeForceCompiler: Deprecate this module and its macros >> https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5908dcb6 > > After fixing a typo in the commit message: > > CMakeForceCompiler: Deprecate this module and its macros

Re: [cmake-developers] CMakeForceCompiler

2015-10-19 Thread Brad King
On 10/19/2015 03:02 PM, Stephen Kelly wrote: > You're using message(DEPRECATION) - no one will see the warning message you > added. At least now we can point at the documentation when someone asks about it. > I think message(DEPRECATION) is broken by design and should not be used > until it

Re: [cmake-developers] CMakeForceCompiler (was: Regression caused by compute-default-dialect topic)

2015-09-22 Thread Brad King
On 09/22/2015 04:29 PM, Stephen Kelly wrote: > I've pushed fix-forced-toolchain-dialect to fix this. It uses an existing > mechanism already in use to determine whether the compiler was forced. Looks good, thanks. > Is there any legitimate need to force the compiler? The CMakeForceCompiler