Re: [cmake-developers] Compact dependency graph

2015-06-16 Thread Nils Gladitz
On 06/15/2015 09:46 PM, Richard Ulrich wrote: So here is the patch with tests and passing the git hooks. Thank you for the update and sorry again for the inconvenience. - Your commit's subject line looks a bit too long; I'd move the issue number into the bulk of the message (It should nicely

Re: [cmake-developers] Compact dependency graph

2015-06-15 Thread Richard Ulrich
So here is the patch with tests and passing the git hooks. Rgds Richard Am Dienstag, den 02.06.2015, 16:46 -0400 schrieb Brad King: On 06/02/2015 04:09 PM, Richard Ulrich wrote: thanks for looking into it. The revised version is on github and in the attachement. Thanks. Please rebase -i

Re: [cmake-developers] Compact dependency graph

2015-06-03 Thread Richard Ulrich
Hi Brad, attached is a patch with everything in one commit rebased to the most current master commit. Rgds Richard Am Dienstag, den 02.06.2015, 16:46 -0400 schrieb Brad King: On 06/02/2015 04:09 PM, Richard Ulrich wrote: Thanks. Please re-send your response directly to the list so it can

Re: [cmake-developers] Compact dependency graph

2015-06-02 Thread Brad King
On 06/01/2015 06:20 PM, Richard Ulrich wrote: Using a callback I now feed the error information back. Here's the latest change: https://github.com/ulrichard/CMake/commit/adf1cf5184d5a13702a03a090c501f1a6d0e39f4 The following line is still commented out: this-Makefile-StoreMatches(re);

Re: [cmake-developers] Compact dependency graph

2015-06-01 Thread Richard Ulrich
Using a callback I now feed the error information back. Here's the latest change: https://github.com/ulrichard/CMake/commit/adf1cf5184d5a13702a03a090c501f1a6d0e39f4 The following line is still commented out: this-Makefile-StoreMatches(re); Is it important enough to add another callback? What

Re: [cmake-developers] Compact dependency graph

2015-05-29 Thread Brad King
On 05/27/2015 05:49 PM, Richard Ulrich wrote: So with this patch, I can define regex replace rules to group the external libraries together. Nice. Thanks for working on this. since cmake has to compile with older compilers Yes. I extracted the RegexReplace functionality from the string

[cmake-developers] Compact dependency graph

2015-05-27 Thread Richard Ulrich
Hi, this is my first post to this list. When generating a dependency graph of a large project with many external libraries, there are so many external libs that one doesn't see the important dependencies any more. On top of that they have also the full absolute path in the graph. So with this