Re: [cmake-developers] Git for windows patch

2016-01-15 Thread Brad King
On 01/15/2016 10:25 AM, Brad King wrote: > You'll have to investigate locally to determine why this method is > not working. It looks like a 64-bit CMake binary would not properly include the "Program Files (x86)" directory as a search location due to outdated assumptions. Please try this fix:

Re: [cmake-developers] Git for windows patch

2016-01-15 Thread Paul Smith
On Fri, 2016-01-15 at 11:37 -0500, Jean-Christophe Fillion-Robin wrote: > > The existence of \bin is there only for backward > -compatibility > > I guess we could also add "Git/usr/bin" to the suffixes so that it > prefer newer version first ? > > PATH_SUFFIXES Git/usr/bin Git/cmd Git/bin I'm n

Re: [cmake-developers] Git for windows patch

2016-01-15 Thread Jean-Christophe Fillion-Robin
Hi, > The existence of \bin is there only for backward -compatibility I guess we could also add "Git/usr/bin" to the suffixes so that it prefer newer version first ? PATH_SUFFIXES Git/usr/bin Git/cmd Git/bin Hth Jc On Fri, Jan 15, 2016 at 11:24 AM, Paul Smith wrote: > On Fri, 2016-01-15 at 1

Re: [cmake-developers] Git for windows patch

2016-01-15 Thread Paul Smith
On Fri, 2016-01-15 at 10:05 -0500, Shawn Waldon wrote: > Looking at the git installation, there is another executable > "C:\Program Files (x86)\Git\cmd\git.exe", but I have never pointed > CMake at that one. What is the difference between the two? I can > change the patch to use the other one, bu

Re: [cmake-developers] Git for windows patch

2016-01-15 Thread Brad King
On 01/14/2016 06:48 PM, Shawn Waldon wrote: > patch that tells CMake to look in the default install location for > Git for Windows [2] when asked for git. This is expected to work already as follows. This code: https://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/Platform/WindowsPaths.cmake;h

Re: [cmake-developers] Git for windows patch

2016-01-15 Thread Shawn Waldon
Hi Kanstantin, Thanks for the feedback. The location of git that I have always used is "C:\Program Files [(x86)]\bin\git.exe". Looking at the git installation, there is another executable "C:\Program Files (x86)\Git\cmd\git.exe", but I have never pointed CMake at that one. What is the differenc

Re: [cmake-developers] Git for windows patch

2016-01-14 Thread Konstantin Podsvirov
Hi, Shawn! I am using CMake and Git on the Windows. As an IDE I use Qt Creator. My experience is that on Windows you need to use: "C:\Program Files [(x86)]\Git\cmd\git.exe" If you use your proposed way, I'm having problems work with Git in my project. It seems to me that this decision is neces

[cmake-developers] Git for windows patch

2016-01-14 Thread Shawn Waldon
Hi, Recently I had to build a project on windows whose build required git. And even though I had installed git from here [1] in the default location, I had to tell CMake where to find it every time I did a build in a clean build tree. So here is a patch that tells CMake to look in the default in