Re: [cmake-developers] Integration of clang-tidy

2016-05-03 Thread Daniel Pfeifer
FYI: I have set up a dashboard build that shows the integration in action: https://open.cdash.org/buildSummary.php?buildid=4349265 Most of the issues have fix-it hints which can be applied automatically by clang-tidy. On Thu, Apr 28, 2016 at 3:44 PM, Brad King wrote: > On

Re: [cmake-developers] Integration of clang-tidy

2016-04-28 Thread Brad King
On 04/27/2016 06:48 PM, Daniel Pfeifer wrote: > It is unrelated. Clang-Tidy picks the interesting pieces from the > compiler command line and ignores the rest. Whether cc is given or not > makes no difference. > But maybe we should leave the decision what to pick to Clang-Tidy? It > may be clearer

Re: [cmake-developers] Integration of clang-tidy

2016-04-27 Thread Daniel Pfeifer
On Wed, Apr 27, 2016 at 3:10 PM, Brad King wrote: > On 04/26/2016 05:32 PM, Daniel Pfeifer wrote: >> This is a follow up patch: > > Thanks. > >> -tidy_cmd.insert(tidy_cmd.end(), orig_cmd.begin()+1, orig_cmd.end()); >> +tidy_cmd.insert(tidy_cmd.end(),

Re: [cmake-developers] Integration of clang-tidy

2016-04-27 Thread Daniel Pfeifer
On Wed, Apr 27, 2016 at 10:47 PM, Gregor Jasny wrote: > Hallo Daniel, > > On 09/04/16 00:31, Daniel Pfeifer wrote: >> I implemented the integration of `clang-tidy` along the lines of the >> `include-what-you-use` integration. >> There is a new `_CLANG_TIDY` target property

Re: [cmake-developers] Integration of clang-tidy

2016-04-27 Thread Gregor Jasny via cmake-developers
Hallo Daniel, On 09/04/16 00:31, Daniel Pfeifer wrote: > I implemented the integration of `clang-tidy` along the lines of the > `include-what-you-use` integration. > There is a new `_CLANG_TIDY` target property that is initialized > with the value of the `CMAKE__CLANG_TIDY` variable. > It

Re: [cmake-developers] Integration of clang-tidy

2016-04-27 Thread Brad King
On 04/26/2016 05:32 PM, Daniel Pfeifer wrote: > This is a follow up patch: Thanks. > -tidy_cmd.insert(tidy_cmd.end(), orig_cmd.begin()+1, orig_cmd.end()); > +tidy_cmd.insert(tidy_cmd.end(), orig_cmd.begin(), orig_cmd.end()); What is the purpose of this hunk? Does clang-tidy

Re: [cmake-developers] Integration of clang-tidy

2016-04-26 Thread Daniel Pfeifer
On Mon, Apr 11, 2016 at 5:26 PM, Brad King wrote: > On 04/08/2016 06:31 PM, Daniel Pfeifer wrote: >> I implemented the integration of `clang-tidy` along the lines of the >> `include-what-you-use` integration. >> There is a new `_CLANG_TIDY` target property that is

Re: [cmake-developers] Integration of clang-tidy

2016-04-11 Thread Brad King
On 04/08/2016 06:31 PM, Daniel Pfeifer wrote: > I implemented the integration of `clang-tidy` along the lines of the > `include-what-you-use` integration. > There is a new `_CLANG_TIDY` target property that is initialized > with the value of the `CMAKE__CLANG_TIDY` variable. > It contains the

[cmake-developers] Integration of clang-tidy

2016-04-08 Thread Daniel Pfeifer
Hi, I implemented the integration of `clang-tidy` along the lines of the `include-what-you-use` integration. There is a new `_CLANG_TIDY` target property that is initialized with the value of the `CMAKE__CLANG_TIDY` variable. It contains the command line for `clang-tidy` as a ;-list. Example